Checkstyle Results
The following document contains the results of Checkstyle. 
Files
Rules
| Rules | Violations | Severity |
|---|---|---|
JavadocPackage
| 11 |  Error |
| NewlineAtEndOfFile | 45 | Error |
| Translation | 0 | Error |
| FileLength | 0 | Error |
FileTabCharacter
| 3237 | Error |
RegexpSingleline
| 1757 | Error |
| JavadocMethod | 2755 | Error |
| JavadocType | 425 | Error |
| JavadocVariable | 1520 | Error |
| JavadocStyle | 374 | Error |
| ConstantName | 169 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 5 | Error |
| MemberName | 632 | Error |
| MethodName | 4 | Error |
| PackageName | 0 | Error |
| ParameterName | 2 | Error |
| StaticVariableName | 88 | Error |
| TypeName | 0 | Error |
| AvoidStarImport | 2 | Error |
| IllegalImport | 0 | Error |
| RedundantImport | 5 | Error |
| UnusedImports | 149 | Error |
| LineLength | 3183 | Error |
| MethodLength | 9 | Error |
| ParameterNumber | 3 | Error |
| EmptyForIteratorPad | 0 | Error |
| MethodParamPad | 0 | Error |
| NoWhitespaceAfter | 29 | Error |
| NoWhitespaceBefore | 7 | Error |
| OperatorWrap | 23 | Error |
| ParenPad | 30 | Error |
| TypecastParenPad | 0 | Error |
| WhitespaceAfter | 159 | Error |
| WhitespaceAround | 974 | Error |
| ModifierOrder | 77 | Error |
| RedundantModifier | 75 | Error |
| AvoidNestedBlocks | 6 | Error |
| EmptyBlock | 48 | Error |
| LeftCurly | 5863 | Error |
| NeedBraces | 48 | Error |
| RightCurly | 701 | Error |
| AvoidInlineConditionals | 61 | Error |
| DoubleCheckedLocking | 3 | Error |
| EmptyStatement | 9 | Error |
| EqualsHashCode | 3 | Error |
| HiddenField | 142 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 5 | Error |
| MagicNumber | 247 | Error |
| MissingSwitchDefault | 3 | Error |
| RedundantThrows | 148 | Error |
| SimplifyBooleanExpression | 25 | Error |
| SimplifyBooleanReturn | 1 | Error |
| DesignForExtension | 1588 | Error |
| FinalClass | 5 | Error |
| HideUtilityClassConstructor | 40 | Error |
| InterfaceIsType | 1 | Error |
| VisibilityModifier | 464 | Error |
| ArrayTypeStyle | 29 | Error |
| FinalParameters | 3248 | Error |
| TodoComment | 101 | Error |
| UpperEll | 0 | Error |
Details
org/apache/helix/AccessOption.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 24 |
| Utility classes should not have a public or default constructor. | 24 |
| '{' should be on the previous line. | 25 |
| Missing a Javadoc comment. | 26 |
| Name 'PERSISTENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 26 |
| Variable 'PERSISTENT' must be private and have accessor methods. | 26 |
| Missing a Javadoc comment. | 27 |
| Name 'EPHEMERAL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 27 |
| Variable 'EPHEMERAL' must be private and have accessor methods. | 27 |
| Missing a Javadoc comment. | 28 |
| Name 'PERSISTENT_SEQUENTIAL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 28 |
| Variable 'PERSISTENT_SEQUENTIAL' must be private and have accessor methods. | 28 |
| '0x4' is a magic number. | 28 |
| Missing a Javadoc comment. | 29 |
| Name 'EPHEMERAL_SEQUENTIAL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 29 |
| Variable 'EPHEMERAL_SEQUENTIAL' must be private and have accessor methods. | 29 |
| '0x8' is a magic number. | 29 |
| Missing a Javadoc comment. | 30 |
| Name 'THROW_EXCEPTION_IFNOTEXIST' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 30 |
| Variable 'THROW_EXCEPTION_IFNOTEXIST' must be private and have accessor methods. | 30 |
| '0x10' is a magic number. | 30 |
| First sentence should end with a period. | 32 |
| Line has trailing spaces. | 34 |
| Parameter options should be final. | 38 |
| Expected @param tag for 'options'. | 38 |
| '{' should be on the previous line. | 39 |
| '{' should be on the previous line. | 41 |
| '}' should be on the same line. | 43 |
| '{' should be on the previous line. | 45 |
| '}' should be on the same line. | 47 |
| '{' should be on the previous line. | 49 |
| '}' should be on the same line. | 51 |
| '{' should be on the previous line. | 53 |
| First sentence should end with a period. | 60 |
| Line has trailing spaces. | 62 |
| Expected an @return tag. | 66 |
| Parameter options should be final. | 66 |
| Expected @param tag for 'options'. | 66 |
| '{' should be on the previous line. | 67 |
org/apache/helix/BaseDataAccessor.java
| Violation | Message | Line |
|---|---|---|
| Unused import - org.apache.zookeeper.CreateMode. | 27 |
| Missing a Javadoc comment. | 30 |
| '{' should be on the previous line. | 31 |
| Line is longer than 80 characters. | 33 |
| Line is longer than 80 characters. | 34 |
| Line has trailing spaces. | 36 |
| Expected an @return tag. | 41 |
| Expected @param tag for 'path'. | 41 |
| Expected @param tag for 'record'. | 41 |
| Expected @param tag for 'options'. | 41 |
| Line is longer than 80 characters. | 44 |
| Line has trailing spaces. | 46 |
| Line is longer than 80 characters. | 49 |
| Expected an @return tag. | 52 |
| Expected @param tag for 'path'. | 52 |
| Expected @param tag for 'record'. | 52 |
| First sentence should end with a period. | 54 |
| Line is longer than 80 characters. | 55 |
| Line has trailing spaces. | 57 |
| Line is longer than 80 characters. | 60 |
| Expected an @return tag. | 63 |
| Expected @param tag for 'path'. | 63 |
| Expected @param tag for 'updater'. | 63 |
| First sentence should end with a period. | 65 |
| Line has trailing spaces. | 67 |
| Line is longer than 80 characters. | 69 |
| Expected an @return tag. | 72 |
| Expected @param tag for 'path'. | 72 |
| Line is longer than 80 characters. | 75 |
| Line has trailing spaces. | 77 |
| Line is longer than 80 characters. | 80 |
| Expected an @return tag. | 83 |
| Expected @param tag for 'paths'. | 83 |
| Expected @param tag for 'records'. | 83 |
| Line is longer than 80 characters. | 86 |
| Line has trailing spaces. | 88 |
| Line is longer than 80 characters. | 91 |
| Expected an @return tag. | 93 |
| Expected @param tag for 'paths'. | 93 |
| Expected @param tag for 'records'. | 93 |
| Line is longer than 80 characters. | 96 |
| Line has trailing spaces. | 98 |
| Line is longer than 80 characters. | 101 |
| Expected an @return tag. | 104 |
| Line is longer than 80 characters. | 104 |
| Expected @param tag for 'paths'. | 104 |
| Expected @param tag for 'updaters'. | 104 |
| Line has trailing spaces. | 108 |
| Line is longer than 80 characters. | 110 |
| Expected an @return tag. | 113 |
| Expected @param tag for 'paths'. | 113 |
| First sentence should end with a period. | 115 |
| Line has trailing spaces. | 117 |
| Line is longer than 80 characters. | 119 |
| Expected an @return tag. | 122 |
| Expected @param tag for 'path'. | 122 |
| Expected @param tag for 'stat'. | 122 |
| First sentence should end with a period. | 124 |
| Line has trailing spaces. | 126 |
| Line is longer than 80 characters. | 128 |
| Expected an @return tag. | 131 |
| Expected @param tag for 'paths'. | 131 |
| Expected @param tag for 'stats'. | 131 |
| First sentence should end with a period. | 133 |
| Line has trailing spaces. | 135 |
| Line is longer than 80 characters. | 137 |
| Expected an @return tag. | 140 |
| Expected @param tag for 'parentPath'. | 140 |
| Expected @param tag for 'stats'. | 140 |
| First sentence should end with a period. | 142 |
| Line has trailing spaces. | 144 |
| Line is longer than 80 characters. | 147 |
| Expected an @return tag. | 150 |
| Expected @param tag for 'parentPath'. | 150 |
| First sentence should end with a period. | 152 |
| Line has trailing spaces. | 154 |
| Line is longer than 80 characters. | 156 |
| Expected an @return tag. | 159 |
| Expected @param tag for 'path'. | 159 |
| First sentence should end with a period. | 161 |
| Line has trailing spaces. | 163 |
| Line is longer than 80 characters. | 165 |
| Expected an @return tag. | 168 |
| Expected @param tag for 'paths'. | 168 |
| First sentence should end with a period. | 170 |
| Line has trailing spaces. | 172 |
| Line is longer than 80 characters. | 174 |
| Expected an @return tag. | 177 |
| Expected @param tag for 'paths'. | 177 |
| First sentence should end with a period. | 179 |
| Line has trailing spaces. | 181 |
| Line is longer than 80 characters. | 183 |
| Expected an @return tag. | 186 |
| Expected @param tag for 'path'. | 186 |
| First sentence should end with a period. | 188 |
| Line has trailing spaces. | 190 |
| Expected @param tag for 'path'. | 195 |
| Expected @param tag for 'listener'. | 195 |
| First sentence should end with a period. | 197 |
| Line has trailing spaces. | 199 |
| Expected @param tag for 'path'. | 203 |
| Expected @param tag for 'listener'. | 203 |
| First sentence should end with a period. | 205 |
| Line has trailing spaces. | 207 |
| Expected an @return tag. | 212 |
| Expected @param tag for 'path'. | 212 |
| Expected @param tag for 'listener'. | 212 |
| First sentence should end with a period. | 214 |
| Line has trailing spaces. | 216 |
| Expected @param tag for 'path'. | 220 |
| Expected @param tag for 'listener'. | 220 |
| First sentence should end with a period. | 222 |
org/apache/helix/CMConnector.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| Line contains a tab character. | 24 |
| Missing a Javadoc comment. | 24 |
| Name '_manager' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 24 |
| Variable '_manager' must be private and have accessor methods. | 24 |
| Line is longer than 80 characters. | 26 |
| Line contains a tab character. | 26 |
| Missing a Javadoc comment. | 26 |
| Line contains a tab character. | 27 |
| Line contains a tab character. | 28 |
| Line contains a tab character. | 29 |
| Line is longer than 80 characters. | 30 |
| Line contains a tab character. | 30 |
| Line contains a tab character. | 31 |
| Line contains a tab character. | 32 |
| Line contains a tab character. | 34 |
| Method 'getManager' is not designed for extension - needs to be abstract, final or empty. | 34 |
| Missing a Javadoc comment. | 34 |
| Line contains a tab character. | 35 |
| Line contains a tab character. | 36 |
| Line contains a tab character. | 38 |
| Method 'disconnect' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Missing a Javadoc comment. | 38 |
| Line contains a tab character. | 39 |
| Line contains a tab character. | 40 |
org/apache/helix/ClusterMessagingService.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 32 |
| Line is longer than 80 characters. | 33 |
| Line has trailing spaces. | 36 |
| '{' should be on the previous line. | 39 |
| Line has trailing spaces. | 42 |
| Expected @param tag for 'recipientCriteria'. | 50 |
| Line has trailing spaces. | 60 |
| Expected an @return tag. | 68 |
| Expected @param tag for 'receipientCriteria'. | 68 |
| Expected @param tag for 'message'. | 68 |
| Expected @param tag for 'callbackOnReply'. | 69 |
| Expected @param tag for 'timeOut'. | 69 |
| Missing a Javadoc comment. | 71 |
| Line is longer than 80 characters. | 79 |
| Line has trailing spaces. | 84 |
| Expected an @return tag. | 92 |
| Expected @param tag for 'receipientCriteria'. | 92 |
| Expected @param tag for 'message'. | 92 |
| Expected @param tag for 'callbackOnReply'. | 93 |
| Expected @param tag for 'timeOut'. | 93 |
| Missing a Javadoc comment. | 95 |
| Line has trailing spaces. | 105 |
| Line has trailing spaces. | 108 |
| Unused @param tag for 'threadpoolSize'. | 113 |
| Line has trailing spaces. | 114 |
| Redundant 'public' modifier. | 117 |
| Line has trailing spaces. | 119 |
| Line is longer than 80 characters. | 121 |
| Line has trailing spaces. | 123 |
| Expected an @return tag. | 128 |
| Line is longer than 80 characters. | 128 |
| Redundant 'public' modifier. | 128 |
| Expected @param tag for 'recipientCriteria'. | 128 |
| Expected @param tag for 'messageTemplate'. | 129 |
org/apache/helix/ConfigAccessor.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 39 |
| '{' should be on the previous line. | 40 |
| Line is longer than 80 characters. | 41 |
| Missing a Javadoc comment. | 41 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 41 |
| Missing a Javadoc comment. | 43 |
| Name 'template' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 43 |
| Line is longer than 80 characters. | 47 |
| Line is longer than 80 characters. | 50 |
| Line is longer than 80 characters. | 56 |
| Line is longer than 80 characters. | 57 |
| Line is longer than 80 characters. | 60 |
| '3' is a magic number. | 65 |
| Line is longer than 80 characters. | 66 |
| Missing a Javadoc comment. | 70 |
| Missing a Javadoc comment. | 72 |
| Parameter zkClient should be final. | 72 |
| 'zkClient' hides a field. | 72 |
| '{' should be on the previous line. | 73 |
| First sentence should end with a period. | 77 |
| Line has trailing spaces. | 80 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Parameter scope should be final. | 86 |
| Expected @param tag for 'scope'. | 86 |
| Parameter key should be final. | 86 |
| Expected @param tag for 'key'. | 86 |
| '{' should be on the previous line. | 87 |
| Line has trailing spaces. | 91 |
| First sentence should end with a period. | 92 |
| Line has trailing spaces. | 95 |
| Expected an @return tag. | 100 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Parameter scope should be final. | 101 |
| Expected @param tag for 'scope'. | 101 |
| Parameter keys should be final. | 101 |
| Expected @param tag for 'keys'. | 101 |
| '{' should be on the previous line. | 102 |
| '{' should be on the previous line. | 104 |
| '{' should be on the previous line. | 113 |
| '{' should be on the previous line. | 123 |
| '{' should be on the previous line. | 125 |
| '}' should be on the same line. | 131 |
| '{' should be on the previous line. | 133 |
| '{' should be on the previous line. | 135 |
| Line has trailing spaces. | 147 |
| First sentence should end with a period. | 148 |
| Line has trailing spaces. | 150 |
| Expected an @return tag. | 155 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 155 |
| Parameter scope should be final. | 155 |
| Expected @param tag for 'scope'. | 155 |
| Parameter key should be final. | 155 |
| Expected @param tag for 'key'. | 155 |
| Line has trailing spaces. | 162 |
| First sentence should end with a period. | 163 |
| Line has trailing spaces. | 165 |
| Expected an @return tag. | 170 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 170 |
| Parameter scope should be final. | 170 |
| Expected @param tag for 'scope'. | 170 |
| Parameter keys should be final. | 170 |
| Expected @param tag for 'keys'. | 170 |
| '==' is not preceded with whitespace. | 171 |
| Line is longer than 80 characters. | 172 |
| Line is longer than 80 characters. | 178 |
| Line has trailing spaces. | 188 |
| Line is longer than 80 characters. | 199 |
| Line has trailing spaces. | 202 |
| Line has trailing spaces. | 210 |
| Line has trailing spaces. | 212 |
| First sentence should end with a period. | 213 |
| Line has trailing spaces. | 216 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 221 |
| Parameter scope should be final. | 222 |
| Expected @param tag for 'scope'. | 222 |
| Parameter key should be final. | 222 |
| Expected @param tag for 'key'. | 222 |
| Parameter value should be final. | 222 |
| Expected @param tag for 'value'. | 222 |
| Line has trailing spaces. | 227 |
| First sentence should end with a period. | 228 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 235 |
| Parameter scope should be final. | 236 |
| Expected @param tag for 'scope'. | 236 |
| Parameter keyValueMap should be final. | 236 |
| Expected @param tag for 'keyValueMap'. | 236 |
| '{' should be on the previous line. | 237 |
| '{' should be on the previous line. | 239 |
| '{' should be on the previous line. | 246 |
| Line is longer than 80 characters. | 253 |
| Line is longer than 80 characters. | 254 |
| Line is longer than 80 characters. | 258 |
| '{' should be on the previous line. | 265 |
| '}' should be on the same line. | 270 |
| '{' should be on the previous line. | 272 |
| '{' should be on the previous line. | 274 |
| Line has trailing spaces. | 288 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 293 |
| Parameter scope should be final. | 293 |
| Expected @param tag for 'scope'. | 293 |
| Parameter key should be final. | 293 |
| Expected @param tag for 'key'. | 293 |
| Parameter value should be final. | 293 |
| Expected @param tag for 'value'. | 293 |
| Line has trailing spaces. | 301 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 305 |
| Parameter scope should be final. | 305 |
| Expected @param tag for 'scope'. | 305 |
| Parameter keyValueMap should be final. | 305 |
| Expected @param tag for 'keyValueMap'. | 305 |
| '{' should be on the previous line. | 306 |
| Line is longer than 80 characters. | 314 |
| Line has trailing spaces. | 318 |
| Line is longer than 80 characters. | 318 |
| Line has trailing spaces. | 320 |
| Line is longer than 80 characters. | 320 |
| Line has trailing spaces. | 337 |
| First sentence should end with a period. | 338 |
| Line has trailing spaces. | 341 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 345 |
| Parameter scope should be final. | 346 |
| Expected @param tag for 'scope'. | 346 |
| Parameter key should be final. | 346 |
| Expected @param tag for 'key'. | 346 |
| Line has trailing spaces. | 349 |
| First sentence should end with a period. | 350 |
| Line has trailing spaces. | 353 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 357 |
| Parameter scope should be final. | 358 |
| Expected @param tag for 'scope'. | 358 |
| Parameter keys should be final. | 358 |
| Expected @param tag for 'keys'. | 358 |
| '{' should be on the previous line. | 359 |
| '{' should be on the previous line. | 361 |
| '{' should be on the previous line. | 368 |
| '{' should be on the previous line. | 378 |
| '}' should be on the same line. | 383 |
| '{' should be on the previous line. | 385 |
| '{' should be on the previous line. | 387 |
| First sentence should end with a period. | 400 |
| Line has trailing spaces. | 402 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 406 |
| Parameter scope should be final. | 406 |
| Expected @param tag for 'scope'. | 406 |
| Parameter key should be final. | 406 |
| Expected @param tag for 'key'. | 406 |
| First sentence should end with a period. | 410 |
| Line has trailing spaces. | 412 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 416 |
| Parameter scope should be final. | 416 |
| Expected @param tag for 'scope'. | 416 |
| Parameter keys should be final. | 416 |
| Expected @param tag for 'keys'. | 416 |
| '{' should be on the previous line. | 417 |
| Line is longer than 80 characters. | 425 |
| Line has trailing spaces. | 448 |
| First sentence should end with a period. | 449 |
| Line has trailing spaces. | 452 |
| Expected an @return tag. | 458 |
| Method 'getKeys' is not designed for extension - needs to be abstract, final or empty. | 458 |
| Parameter type should be final. | 459 |
| Expected @param tag for 'type'. | 459 |
| Parameter clusterName should be final. | 460 |
| Expected @param tag for 'clusterName'. | 460 |
| Parameter keys should be final. | 461 |
| Expected @param tag for 'keys'. | 461 |
| '{' should be on the previous line. | 462 |
| '{' should be on the previous line. | 464 |
| '{' should be on the previous line. | 470 |
| '{' should be on the previous line. | 472 |
| '{' should be on the previous line. | 484 |
| '}' should be on the same line. | 486 |
| '{' should be on the previous line. | 488 |
| '{' should be on the previous line. | 492 |
| '}' should be on the same line. | 495 |
| '{' should be on the previous line. | 497 |
| '}' should be on the same line. | 499 |
| '{' should be on the previous line. | 501 |
| Line is longer than 80 characters. | 502 |
| '{' should be on the previous line. | 506 |
| Line is longer than 80 characters. | 507 |
| '}' should be on the same line. | 513 |
| '{' should be on the previous line. | 515 |
| Line has trailing spaces. | 520 |
| Line has trailing spaces. | 521 |
| First sentence should end with a period. | 522 |
| Line has trailing spaces. | 524 |
| Expected an @return tag. | 528 |
| Method 'getKeys' is not designed for extension - needs to be abstract, final or empty. | 528 |
| Parameter scope should be final. | 528 |
| Expected @param tag for 'scope'. | 528 |
| Line has trailing spaces. | 533 |
| '{' is not preceded with whitespace. | 534 |
| Line is longer than 80 characters. | 535 |
| Line has trailing spaces. | 538 |
| Line has trailing spaces. | 542 |
| Line has trailing spaces. | 558 |
org/apache/helix/ConfigChangeListener.java
| Violation | Message | Line |
|---|---|---|
| Line has trailing spaces. | 28 |
| '{' should be on the previous line. | 32 |
| First sentence should end with a period. | 34 |
| Line has trailing spaces. | 36 |
| Redundant 'public' modifier. | 40 |
| Expected @param tag for 'configs'. | 40 |
| Expected @param tag for 'changeContext'. | 41 |
org/apache/helix/ControllerChangeListener.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| '{' should be on the previous line. | 23 |
| First sentence should end with a period. | 24 |
| Line has trailing spaces. | 26 |
| Redundant 'public' modifier. | 29 |
| Expected @param tag for 'changeContext'. | 29 |
org/apache/helix/Criteria.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| '{' should be on the previous line. | 23 |
| Missing a Javadoc comment. | 24 |
| '{' should be on the previous line. | 25 |
| Missing a Javadoc comment. | 26 |
| Missing a Javadoc comment. | 26 |
| First sentence should end with a period. | 28 |
| Variable 'recipientInstanceType' must be private and have accessor methods. | 31 |
| Variable 'sessionSpecific' must be private and have accessor methods. | 37 |
| First sentence should end with a period. | 38 |
| Variable 'instanceName' must be private and have accessor methods. | 41 |
| Variable 'resourceName' must be private and have accessor methods. | 46 |
| Variable 'partitionName' must be private and have accessor methods. | 51 |
| First sentence should end with a period. | 52 |
| Variable 'partitionState' must be private and have accessor methods. | 55 |
| Variable 'selfExcluded' must be private and have accessor methods. | 59 |
| First sentence should end with a period. | 60 |
| Name '_dataSource' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 63 |
| Variable '_dataSource' must be private and have accessor methods. | 63 |
| Line has trailing spaces. | 64 |
| Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Missing a Javadoc comment. | 65 |
| '{' should be on the previous line. | 66 |
| Line has trailing spaces. | 69 |
| Method 'setDataSource' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Missing a Javadoc comment. | 70 |
| Parameter source should be final. | 70 |
| '{' should be on the previous line. | 71 |
| Method 'isSelfExcluded' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Missing a Javadoc comment. | 75 |
| '{' should be on the previous line. | 76 |
| Method 'setSelfExcluded' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Missing a Javadoc comment. | 80 |
| Parameter selfExcluded should be final. | 80 |
| 'selfExcluded' hides a field. | 80 |
| '{' should be on the previous line. | 81 |
| Method 'getRecipientInstanceType' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Missing a Javadoc comment. | 85 |
| '{' should be on the previous line. | 86 |
| Method 'setRecipientInstanceType' is not designed for extension - needs to be abstract, final or empty. | 90 |
| Missing a Javadoc comment. | 90 |
| Parameter recipientInstanceType should be final. | 90 |
| 'recipientInstanceType' hides a field. | 90 |
| '{' should be on the previous line. | 91 |
| Method 'isSessionSpecific' is not designed for extension - needs to be abstract, final or empty. | 95 |
| Missing a Javadoc comment. | 95 |
| '{' should be on the previous line. | 96 |
| Method 'setSessionSpecific' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Missing a Javadoc comment. | 100 |
| Parameter sessionSpecific should be final. | 100 |
| 'sessionSpecific' hides a field. | 100 |
| '{' should be on the previous line. | 101 |
| Method 'getInstanceName' is not designed for extension - needs to be abstract, final or empty. | 105 |
| Missing a Javadoc comment. | 105 |
| '{' should be on the previous line. | 106 |
| Method 'setInstanceName' is not designed for extension - needs to be abstract, final or empty. | 110 |
| Missing a Javadoc comment. | 110 |
| Parameter instanceName should be final. | 110 |
| 'instanceName' hides a field. | 110 |
| '{' should be on the previous line. | 111 |
| Method 'getResource' is not designed for extension - needs to be abstract, final or empty. | 115 |
| Missing a Javadoc comment. | 115 |
| '{' should be on the previous line. | 116 |
| Method 'setResource' is not designed for extension - needs to be abstract, final or empty. | 120 |
| Missing a Javadoc comment. | 120 |
| Parameter resourceName should be final. | 120 |
| 'resourceName' hides a field. | 120 |
| '{' should be on the previous line. | 121 |
| Method 'getPartition' is not designed for extension - needs to be abstract, final or empty. | 125 |
| Missing a Javadoc comment. | 125 |
| '{' should be on the previous line. | 126 |
| Method 'setPartition' is not designed for extension - needs to be abstract, final or empty. | 130 |
| Missing a Javadoc comment. | 130 |
| Parameter partitionName should be final. | 130 |
| 'partitionName' hides a field. | 130 |
| '{' should be on the previous line. | 131 |
| Method 'getPartitionState' is not designed for extension - needs to be abstract, final or empty. | 135 |
| Missing a Javadoc comment. | 135 |
| '{' should be on the previous line. | 136 |
| Method 'setPartitionState' is not designed for extension - needs to be abstract, final or empty. | 140 |
| Missing a Javadoc comment. | 140 |
| Parameter partitionState should be final. | 140 |
| 'partitionState' hides a field. | 140 |
| '{' should be on the previous line. | 141 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 145 |
| Missing a Javadoc comment. | 145 |
| '{' should be on the previous line. | 146 |
org/apache/helix/CurrentStateChangeListener.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 27 |
| '{' should be on the previous line. | 28 |
| First sentence should end with a period. | 30 |
| Line has trailing spaces. | 32 |
| Redundant 'public' modifier. | 37 |
| Expected @param tag for 'instanceName'. | 37 |
| Expected @param tag for 'statesInfo'. | 38 |
| Expected @param tag for 'changeContext'. | 39 |
org/apache/helix/EspressoResource.java
| Violation | Message | Line |
|---|---|---|
| Unused import - java.nio.ByteBuffer. | 22 |
| Unused import - java.nio.CharBuffer. | 23 |
| Unused import - java.nio.channels.ReadableByteChannel. | 24 |
| Unused import - java.util.List. | 25 |
| Unused import - org.apache.helix.tools.ClusterSetup. | 28 |
| Unused import - org.codehaus.jackson.JsonGenerationException. | 30 |
| Unused import - org.codehaus.jackson.map.JsonMappingException. | 31 |
| Missing a Javadoc comment. | 46 |
| Line has trailing spaces. | 47 |
| Line contains a tab character. | 47 |
| Line contains a tab character. | 48 |
| Missing a Javadoc comment. | 48 |
| '*' is not preceded with whitespace. | 48 |
| '*' is not followed by whitespace. | 48 |
| Line has trailing spaces. | 49 |
| Line contains a tab character. | 49 |
| Line contains a tab character. | 50 |
| Missing a Javadoc comment. | 50 |
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 50 |
| Line contains a tab character. | 51 |
| Line has trailing spaces. | 52 |
| Line contains a tab character. | 52 |
| Line contains a tab character. | 53 |
| Missing a Javadoc comment. | 53 |
| Name '_context' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 53 |
| Variable '_context' must be private and have accessor methods. | 53 |
| Line has trailing spaces. | 54 |
| Line contains a tab character. | 54 |
| Line contains a tab character. | 55 |
| Missing a Javadoc comment. | 55 |
| Parameter context should be final. | 55 |
| Line contains a tab character. | 56 |
| Parameter request should be final. | 56 |
| Line has trailing spaces. | 57 |
| Line contains a tab character. | 57 |
| Parameter response should be final. | 57 |
| Line contains a tab character. | 58 |
| '{' should be on the previous line. | 58 |
| Line contains a tab character. | 59 |
| Line contains a tab character. | 60 |
| Line contains a tab character. | 61 |
| Line contains a tab character. | 62 |
| Line contains a tab character. | 63 |
| Line has trailing spaces. | 64 |
| Line contains a tab character. | 64 |
| Line contains a tab character. | 65 |
| Method 'allowGet' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Missing a Javadoc comment. | 65 |
| Line contains a tab character. | 66 |
| '{' should be on the previous line. | 66 |
| Line contains a tab character. | 67 |
| Line contains a tab character. | 68 |
| Line contains a tab character. | 69 |
| Line has trailing spaces. | 70 |
| Line contains a tab character. | 70 |
| Line contains a tab character. | 71 |
| Method 'allowPost' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Missing a Javadoc comment. | 71 |
| Line contains a tab character. | 72 |
| '{' should be on the previous line. | 72 |
| Line contains a tab character. | 73 |
| Line contains a tab character. | 74 |
| Line contains a tab character. | 75 |
| Line has trailing spaces. | 76 |
| Line contains a tab character. | 76 |
| Line contains a tab character. | 77 |
| Method 'allowPut' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Missing a Javadoc comment. | 77 |
| Line contains a tab character. | 78 |
| '{' should be on the previous line. | 78 |
| Line contains a tab character. | 79 |
| Line contains a tab character. | 80 |
| Line contains a tab character. | 81 |
| Line has trailing spaces. | 82 |
| Line contains a tab character. | 82 |
| Line contains a tab character. | 83 |
| Method 'allowDelete' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Missing a Javadoc comment. | 83 |
| Line contains a tab character. | 84 |
| '{' should be on the previous line. | 84 |
| Line contains a tab character. | 85 |
| Line contains a tab character. | 86 |
| Line has trailing spaces. | 87 |
| Line contains a tab character. | 87 |
| Line contains a tab character. | 88 |
| Line contains a tab character. | 89 |
| Line is longer than 80 characters. | 90 |
| Line contains a tab character. | 90 |
| Line contains a tab character. | 91 |
| Line contains a tab character. | 92 |
| Method 'represent' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Missing a Javadoc comment. | 92 |
| Parameter variant should be final. | 92 |
| Line contains a tab character. | 93 |
| '{' should be on the previous line. | 93 |
| Line contains a tab character. | 94 |
| Line contains a tab character. | 95 |
| Line contains a tab character. | 96 |
| '{' should be on the previous line. | 96 |
| Line is longer than 80 characters. | 97 |
| Line contains a tab character. | 97 |
| 'cast' is not followed by whitespace. | 97 |
| Line is longer than 80 characters. | 98 |
| Line contains a tab character. | 98 |
| 'cast' is not followed by whitespace. | 98 |
| Line is longer than 80 characters. | 99 |
| Line contains a tab character. | 99 |
| 'cast' is not followed by whitespace. | 99 |
| Line is longer than 80 characters. | 100 |
| Line contains a tab character. | 100 |
| 'cast' is not followed by whitespace. | 100 |
| Line contains a tab character. | 101 |
| Line contains a tab character. | 102 |
| '+' is not preceded with whitespace. | 102 |
| '+' is not followed by whitespace. | 102 |
| Line is longer than 80 characters. | 103 |
| Line contains a tab character. | 103 |
| Line is longer than 80 characters. | 104 |
| Line contains a tab character. | 104 |
| 'cast' is not followed by whitespace. | 104 |
| Line has trailing spaces. | 106 |
| Line contains a tab character. | 106 |
| Line contains a tab character. | 107 |
| Line contains a tab character. | 108 |
| Line contains a tab character. | 109 |
| Comment matches to-do format 'TODO:'. | 110 |
| Line contains a tab character. | 110 |
| Line has trailing spaces. | 111 |
| Line is longer than 80 characters. | 111 |
| Line contains a tab character. | 111 |
| Line contains a tab character. | 112 |
| Line contains a tab character. | 113 |
| Line contains a tab character. | 114 |
| '+' is not preceded with whitespace. | 114 |
| '+' is not followed by whitespace. | 114 |
| Line is longer than 80 characters. | 115 |
| Line contains a tab character. | 115 |
| Line is longer than 80 characters. | 116 |
| Line contains a tab character. | 116 |
| Line contains a tab character. | 117 |
| '}' should be on the same line. | 117 |
| Line contains a tab character. | 118 |
| Line contains a tab character. | 119 |
| Line contains a tab character. | 120 |
| Line contains a tab character. | 121 |
| '+' is not preceded with whitespace. | 121 |
| '+' is not followed by whitespace. | 121 |
| Line contains a tab character. | 122 |
| Line is longer than 80 characters. | 123 |
| Line contains a tab character. | 123 |
| Line is longer than 80 characters. | 124 |
| Line contains a tab character. | 124 |
| ',' is not followed by whitespace. | 124 |
| Line contains a tab character. | 125 |
| '}' should be on the same line. | 125 |
| Line contains a tab character. | 126 |
| Line is longer than 80 characters. | 127 |
| Line contains a tab character. | 127 |
| ',' is not followed by whitespace. | 127 |
| Line is longer than 80 characters. | 128 |
| Line contains a tab character. | 128 |
| Line contains a tab character. | 129 |
| Line contains a tab character. | 130 |
| Line contains a tab character. | 131 |
| '}' should be on the same line. | 131 |
| Line contains a tab character. | 133 |
| Line is longer than 80 characters. | 134 |
| Line contains a tab character. | 134 |
| Line contains a tab character. | 135 |
| Line contains a tab character. | 136 |
| '}' should be on the same line. | 136 |
| Line contains a tab character. | 138 |
| 'catch' is not followed by whitespace. | 138 |
| Line contains a tab character. | 139 |
| '{' should be on the previous line. | 139 |
| Line is longer than 80 characters. | 140 |
| Line contains a tab character. | 140 |
| Line has trailing spaces. | 141 |
| Line is longer than 80 characters. | 141 |
| Line contains a tab character. | 141 |
| Line contains a tab character. | 142 |
| Line has trailing spaces. | 143 |
| Line contains a tab character. | 143 |
| Line contains a tab character. | 144 |
| Line contains a tab character. | 145 |
| Line has trailing spaces. | 146 |
| Line contains a tab character. | 146 |
| Line contains a tab character. | 147 |
| Line contains a tab character. | 148 |
| Line is longer than 80 characters. | 149 |
| Line contains a tab character. | 149 |
| Line contains a tab character. | 150 |
| Line is longer than 80 characters. | 151 |
| Line contains a tab character. | 151 |
| Method 'storeRepresentation' is not designed for extension - needs to be abstract, final or empty. | 151 |
| Missing a Javadoc comment. | 151 |
| Parameter entity should be final. | 151 |
| Unable to get class information for ResourceException. | 151 |
| Line contains a tab character. | 152 |
| Line contains a tab character. | 153 |
| Line contains a tab character. | 154 |
| Line is longer than 80 characters. | 155 |
| Line contains a tab character. | 155 |
| Line contains a tab character. | 156 |
| Line contains a tab character. | 157 |
| Line contains a tab character. | 158 |
| Line contains a tab character. | 159 |
| '+' is not preceded with whitespace. | 159 |
| '+' is not followed by whitespace. | 159 |
| '+' is not preceded with whitespace. | 159 |
| '+' is not followed by whitespace. | 159 |
| Line contains a tab character. | 160 |
| Line contains a tab character. | 161 |
| Line contains a tab character. | 162 |
| Line contains a tab character. | 163 |
| Line has trailing spaces. | 164 |
| Line contains a tab character. | 164 |
| Line contains a tab character. | 165 |
| Line contains a tab character. | 166 |
| '{' should be on the previous line. | 166 |
| Line contains a tab character. | 167 |
| Line is longer than 80 characters. | 168 |
| Line contains a tab character. | 168 |
| 'cast' is not followed by whitespace. | 168 |
| Line is longer than 80 characters. | 169 |
| Line contains a tab character. | 169 |
| 'cast' is not followed by whitespace. | 169 |
| Line is longer than 80 characters. | 170 |
| Line contains a tab character. | 170 |
| 'cast' is not followed by whitespace. | 170 |
| Line is longer than 80 characters. | 171 |
| Line contains a tab character. | 171 |
| 'cast' is not followed by whitespace. | 171 |
| Line contains a tab character. | 172 |
| Line contains a tab character. | 173 |
| '+' is not preceded with whitespace. | 173 |
| '+' is not followed by whitespace. | 173 |
| Line is longer than 80 characters. | 174 |
| Line contains a tab character. | 174 |
| Line is longer than 80 characters. | 175 |
| Line contains a tab character. | 175 |
| 'cast' is not followed by whitespace. | 175 |
| Line contains a tab character. | 177 |
| Line contains a tab character. | 178 |
| Line contains a tab character. | 179 |
| Comment matches to-do format 'TODO:'. | 180 |
| Line contains a tab character. | 180 |
| Line is longer than 80 characters. | 181 |
| Line contains a tab character. | 181 |
| Line is longer than 80 characters. | 182 |
| Line contains a tab character. | 182 |
| Line contains a tab character. | 183 |
| Line contains a tab character. | 184 |
| '+' is not preceded with whitespace. | 184 |
| '+' is not followed by whitespace. | 184 |
| Line is longer than 80 characters. | 185 |
| Line contains a tab character. | 185 |
| Line is longer than 80 characters. | 186 |
| Line contains a tab character. | 186 |
| Line contains a tab character. | 187 |
| '}' should be on the same line. | 187 |
| Line contains a tab character. | 188 |
| Line contains a tab character. | 189 |
| Line is longer than 80 characters. | 190 |
| Line contains a tab character. | 190 |
| Line contains a tab character. | 191 |
| '+' is not preceded with whitespace. | 191 |
| '+' is not followed by whitespace. | 191 |
| Line contains a tab character. | 192 |
| Line is longer than 80 characters. | 193 |
| Line contains a tab character. | 193 |
| Line contains a tab character. | 194 |
| '}' should be on the same line. | 194 |
| Line contains a tab character. | 195 |
| Line is longer than 80 characters. | 196 |
| Line contains a tab character. | 196 |
| Line contains a tab character. | 197 |
| Line contains a tab character. | 198 |
| Line contains a tab character. | 199 |
| '}' should be on the same line. | 199 |
| Line contains a tab character. | 201 |
| Line is longer than 80 characters. | 202 |
| Line contains a tab character. | 202 |
| Line contains a tab character. | 203 |
| Line contains a tab character. | 204 |
| '}' should be on the same line. | 204 |
| Line contains a tab character. | 206 |
| 'catch' is not followed by whitespace. | 206 |
| Line contains a tab character. | 207 |
| '{' should be on the previous line. | 207 |
| Line contains a tab character. | 208 |
| Line has trailing spaces. | 209 |
| Line is longer than 80 characters. | 209 |
| Line contains a tab character. | 209 |
| Line contains a tab character. | 210 |
| Line has trailing spaces. | 211 |
| Line contains a tab character. | 211 |
| '}' should be on the same line. | 211 |
| Line contains a tab character. | 212 |
| Line contains a tab character. | 213 |
| Line contains a tab character. | 214 |
| Line contains a tab character. | 215 |
org/apache/helix/EspressoStorageMockNode.java
| Violation | Message | Line |
|---|---|---|
| Redundant import from the same package - org.apache.helix.EspressoStorageMockStateModelFactory. | 27 |
| Redundant import from the same package - org.apache.helix.HelixDataAccessor. | 28 |
| Redundant import from the same package - org.apache.helix.PropertyType. | 29 |
| Unused import - org.apache.helix.PropertyType. | 29 |
| Redundant import from the same package - org.apache.helix.ZNRecord. | 30 |
| Unused import - org.apache.helix.healthcheck.PerformanceHealthReportProvider. | 32 |
| Unused import - org.apache.helix.model.Message.MessageType. | 35 |
| Missing a Javadoc comment. | 40 |
| Line contains a tab character. | 42 |
| Missing a Javadoc comment. | 42 |
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 42 |
| Line contains a tab character. | 43 |
| Line contains a tab character. | 45 |
| Missing a Javadoc comment. | 45 |
| Name 'GET_STAT_NAME' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 45 |
| Line contains a tab character. | 46 |
| Missing a Javadoc comment. | 46 |
| Name 'SET_STAT_NAME' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 46 |
| Line contains a tab character. | 47 |
| Missing a Javadoc comment. | 47 |
| Name 'COUNT_STAT_TYPE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 47 |
| Line contains a tab character. | 48 |
| Missing a Javadoc comment. | 48 |
| Name 'REPORT_NAME' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 48 |
| Line contains a tab character. | 50 |
| Missing a Javadoc comment. | 50 |
| Name '_healthProvider' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 50 |
| Variable '_healthProvider' must be private and have accessor methods. | 50 |
| Line contains a tab character. | 51 |
| Line contains a tab character. | 52 |
| Missing a Javadoc comment. | 52 |
| Name '_stateModelFactory' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 52 |
| Variable '_stateModelFactory' must be private and have accessor methods. | 52 |
| Line contains a tab character. | 54 |
| Missing a Javadoc comment. | 54 |
| Name '_partitions' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 54 |
| Variable '_partitions' must be private and have accessor methods. | 54 |
| Line contains a tab character. | 56 |
| Missing a Javadoc comment. | 56 |
| Name '_keyValueMap' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 56 |
| Variable '_keyValueMap' must be private and have accessor methods. | 56 |
| Line contains a tab character. | 57 |
| Missing a Javadoc comment. | 57 |
| Name '_hashFunction' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 57 |
| Variable '_hashFunction' must be private and have accessor methods. | 57 |
| Line contains a tab character. | 58 |
| Missing a Javadoc comment. | 58 |
| Name '_numTotalEspressoPartitions' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 58 |
| Variable '_numTotalEspressoPartitions' must be private and have accessor methods. | 58 |
| Line contains a tab character. | 60 |
| Missing a Javadoc comment. | 60 |
| Parameter cm should be final. | 60 |
| Line contains a tab character. | 61 |
| Line is longer than 80 characters. | 62 |
| Line contains a tab character. | 62 |
| Line is longer than 80 characters. | 64 |
| Line contains a tab character. | 64 |
| Line is longer than 80 characters. | 65 |
| Line contains a tab character. | 65 |
| Line is longer than 80 characters. | 66 |
| Line contains a tab character. | 66 |
| Line contains a tab character. | 67 |
| Line contains a tab character. | 68 |
| Line contains a tab character. | 69 |
| Line contains a tab character. | 70 |
| Line is longer than 80 characters. | 71 |
| Line contains a tab character. | 71 |
| Line contains a tab character. | 72 |
| Line contains a tab character. | 74 |
| Line contains a tab character. | 75 |
| Line contains a tab character. | 78 |
| Line contains a tab character. | 79 |
| Line contains a tab character. | 81 |
| Line contains a tab character. | 82 |
| Line contains a tab character. | 83 |
| Line contains a tab character. | 84 |
| Line contains a tab character. | 85 |
| Line contains a tab character. | 87 |
| Line is longer than 80 characters. | 88 |
| Line contains a tab character. | 88 |
| Line contains a tab character. | 89 |
| Line contains a tab character. | 90 |
| Line contains a tab character. | 91 |
| Line is longer than 80 characters. | 93 |
| Line contains a tab character. | 93 |
| Method 'formStatName' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Missing a Javadoc comment. | 93 |
| Parameter dbName should be final. | 93 |
| Parameter partitionName should be final. | 93 |
| Parameter metricName should be final. | 93 |
| Line contains a tab character. | 94 |
| Line contains a tab character. | 95 |
| Line is longer than 80 characters. | 96 |
| Line contains a tab character. | 96 |
| '+' is not preceded with whitespace. | 96 |
| '+' is not followed by whitespace. | 96 |
| '+' is not preceded with whitespace. | 96 |
| '+' is not followed by whitespace. | 96 |
| '+' is not preceded with whitespace. | 96 |
| '+' is not followed by whitespace. | 96 |
| '+' is not preceded with whitespace. | 96 |
| '+' is not followed by whitespace. | 96 |
| '+' is not preceded with whitespace. | 96 |
| '+' is not followed by whitespace. | 96 |
| Line contains a tab character. | 97 |
| Line contains a tab character. | 99 |
| Line contains a tab character. | 101 |
| Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 101 |
| Missing a Javadoc comment. | 101 |
| Parameter dbId should be final. | 101 |
| Parameter key should be final. | 101 |
| Line is longer than 80 characters. | 102 |
| Line contains a tab character. | 102 |
| Line contains a tab character. | 103 |
| Line is longer than 80 characters. | 104 |
| Line contains a tab character. | 104 |
| '+' is not preceded with whitespace. | 104 |
| '+' is not followed by whitespace. | 104 |
| '+' is not preceded with whitespace. | 104 |
| '+' is not followed by whitespace. | 104 |
| '+' is not preceded with whitespace. | 104 |
| '+' is not followed by whitespace. | 104 |
| '+' is not followed by whitespace. | 104 |
| Line contains a tab character. | 105 |
| Line contains a tab character. | 106 |
| Line is longer than 80 characters. | 108 |
| Line contains a tab character. | 108 |
| Line is longer than 80 characters. | 109 |
| Line contains a tab character. | 109 |
| Line is longer than 80 characters. | 110 |
| Line contains a tab character. | 110 |
| Line contains a tab character. | 111 |
| Line contains a tab character. | 112 |
| Line contains a tab character. | 114 |
| Method 'doPut' is not designed for extension - needs to be abstract, final or empty. | 114 |
| Missing a Javadoc comment. | 114 |
| Parameter dbId should be final. | 114 |
| Parameter key should be final. | 114 |
| Parameter value should be final. | 114 |
| Line is longer than 80 characters. | 115 |
| Line contains a tab character. | 115 |
| Line contains a tab character. | 116 |
| Line is longer than 80 characters. | 117 |
| Line contains a tab character. | 117 |
| '+' is not preceded with whitespace. | 117 |
| '+' is not followed by whitespace. | 117 |
| '+' is not preceded with whitespace. | 117 |
| '+' is not followed by whitespace. | 117 |
| '+' is not preceded with whitespace. | 117 |
| '+' is not followed by whitespace. | 117 |
| '+' is not followed by whitespace. | 117 |
| Line contains a tab character. | 118 |
| Line contains a tab character. | 119 |
| Line is longer than 80 characters. | 121 |
| Line contains a tab character. | 121 |
| Line is longer than 80 characters. | 122 |
| Line contains a tab character. | 122 |
| Line contains a tab character. | 123 |
| Line is longer than 80 characters. | 124 |
| Line contains a tab character. | 124 |
| Line is longer than 80 characters. | 125 |
| Line contains a tab character. | 125 |
| Line contains a tab character. | 127 |
| Line contains a tab character. | 128 |
| Line contains a tab character. | 130 |
| Missing a Javadoc comment. | 130 |
| Parameter databaseName should be final. | 130 |
| Parameter partitionNum should be final. | 130 |
| Line contains a tab character. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| Line contains a tab character. | 132 |
| Line contains a tab character. | 134 |
| Missing a Javadoc comment. | 134 |
| Parameter partitionName should be final. | 134 |
| Line contains a tab character. | 135 |
| Line contains a tab character. | 136 |
| Line contains a tab character. | 137 |
| '+' is not preceded with whitespace. | 137 |
| '+' is not followed by whitespace. | 137 |
| Line contains a tab character. | 139 |
| Line contains a tab character. | 140 |
| Line contains a tab character. | 142 |
| Missing a Javadoc comment. | 142 |
| Parameter dbName should be final. | 142 |
| Parameter key should be final. | 142 |
| Line contains a tab character. | 143 |
| Line contains a tab character. | 144 |
| '+' is not preceded with whitespace. | 144 |
| '+' is not followed by whitespace. | 144 |
| Line is longer than 80 characters. | 145 |
| Line contains a tab character. | 145 |
| 'cast' is not followed by whitespace. | 145 |
| Line contains a tab character. | 146 |
| '+' is not preceded with whitespace. | 146 |
| '+' is not followed by whitespace. | 146 |
| Line contains a tab character. | 147 |
| Line contains a tab character. | 148 |
| Line contains a tab character. | 150 |
| Missing a Javadoc comment. | 150 |
| Parameter dbName should be final. | 150 |
| Line contains a tab character. | 151 |
| '+' is not preceded with whitespace. | 151 |
| '+' is not followed by whitespace. | 151 |
| Line is longer than 80 characters. | 152 |
| Line contains a tab character. | 152 |
| Line contains a tab character. | 153 |
| Line is longer than 80 characters. | 154 |
| Line contains a tab character. | 155 |
| Line contains a tab character. | 156 |
| Line contains a tab character. | 157 |
| Line contains a tab character. | 158 |
| Line contains a tab character. | 159 |
| Line contains a tab character. | 160 |
| Missing a Javadoc comment. | 162 |
| Line contains a tab character. | 162 |
| Line contains a tab character. | 164 |
| Line contains a tab character. | 165 |
| Line contains a tab character. | 166 |
| Line contains a tab character. | 167 |
| Line is longer than 80 characters. | 168 |
| Line contains a tab character. | 168 |
| Line contains a tab character. | 169 |
| Line is longer than 80 characters. | 170 |
| Line contains a tab character. | 170 |
| Line contains a tab character. | 171 |
| Line contains a tab character. | 172 |
| Line contains a tab character. | 173 |
| '+' is not preceded with whitespace. | 173 |
| '+' is not followed by whitespace. | 173 |
| Line contains a tab character. | 174 |
| Line contains a tab character. | 175 |
| Line contains a tab character. | 176 |
| Line contains a tab character. | 177 |
| Line contains a tab character. | 178 |
| Line contains a tab character. | 179 |
| '60000' is a magic number. | 179 |
| Line contains a tab character. | 180 |
| Line contains a tab character. | 181 |
| Line contains a tab character. | 182 |
| Line contains a tab character. | 183 |
| Line contains a tab character. | 184 |
| Line contains a tab character. | 185 |
| Line contains a tab character. | 186 |
| Line contains a tab character. | 188 |
| Line contains a tab character. | 189 |
| Line contains a tab character. | 191 |
org/apache/helix/EspressoStorageMockStateModelFactory.java
| Violation | Message | Line |
|---|---|---|
| Redundant import from the same package - org.apache.helix.NotificationContext. | 20 |
| Missing a Javadoc comment. | 25 |
| Line is longer than 80 characters. | 26 |
| Line contains a tab character. | 27 |
| Missing a Javadoc comment. | 27 |
| Name '_delay' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 27 |
| Variable '_delay' must be private and have accessor methods. | 27 |
| Line contains a tab character. | 29 |
| Missing a Javadoc comment. | 29 |
| Parameter delay should be final. | 29 |
| Line contains a tab character. | 30 |
| Line contains a tab character. | 31 |
| Line contains a tab character. | 33 |
| Method 'createNewStateModel' is not designed for extension - needs to be abstract, final or empty. | 33 |
| Line contains a tab character. | 34 |
| Parameter stateUnitKey should be final. | 34 |
| Line is longer than 80 characters. | 35 |
| Line contains a tab character. | 35 |
| Line contains a tab character. | 36 |
| Line contains a tab character. | 37 |
| Line contains a tab character. | 38 |
| Line contains a tab character. | 39 |
| Missing a Javadoc comment. | 41 |
| Line contains a tab character. | 41 |
| Line contains a tab character. | 42 |
| Missing a Javadoc comment. | 42 |
| Name '_transDelay' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 42 |
| Variable '_transDelay' must be private and have accessor methods. | 42 |
| Line contains a tab character. | 43 |
| Missing a Javadoc comment. | 43 |
| Variable 'stateUnitKey' must be private and have accessor methods. | 43 |
| Line has trailing spaces. | 44 |
| Line contains a tab character. | 44 |
| Line contains a tab character. | 45 |
| Method 'getStateUnitKey' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Missing a Javadoc comment. | 45 |
| Line contains a tab character. | 46 |
| Line contains a tab character. | 47 |
| Line contains a tab character. | 49 |
| Method 'setStateUnitKey' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Missing a Javadoc comment. | 49 |
| Parameter stateUnitKey should be final. | 49 |
| 'stateUnitKey' hides a field. | 49 |
| Line contains a tab character. | 50 |
| Line contains a tab character. | 51 |
| Line contains a tab character. | 53 |
| Method 'setDelay' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Missing a Javadoc comment. | 53 |
| Parameter delay should be final. | 53 |
| Line contains a tab character. | 54 |
| Avoid inline conditionals. | 54 |
| Line contains a tab character. | 55 |
| Line contains a tab character. | 57 |
| Method 'onBecomeSlaveFromOffline' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Missing a Javadoc comment. | 57 |
| Parameter message should be final. | 57 |
| Line contains a tab character. | 58 |
| Parameter context should be final. | 58 |
| Line is longer than 80 characters. | 60 |
| Line contains a tab character. | 60 |
| '+' is not preceded with whitespace. | 60 |
| Line contains a tab character. | 61 |
| Line contains a tab character. | 62 |
| Line contains a tab character. | 64 |
| Missing a Javadoc comment. | 64 |
| Line contains a tab character. | 65 |
| Line contains a tab character. | 66 |
| Line contains a tab character. | 67 |
| Line contains a tab character. | 68 |
| Line contains a tab character. | 69 |
| Line contains a tab character. | 70 |
| Line contains a tab character. | 72 |
| Method 'onBecomeSlaveFromMaster' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Missing a Javadoc comment. | 72 |
| Parameter message should be final. | 72 |
| Line contains a tab character. | 73 |
| Parameter context should be final. | 73 |
| Line is longer than 80 characters. | 74 |
| Line contains a tab character. | 74 |
| '+' is not preceded with whitespace. | 74 |
| Line contains a tab character. | 75 |
| Line contains a tab character. | 77 |
| Line contains a tab character. | 79 |
| Method 'onBecomeMasterFromSlave' is not designed for extension - needs to be abstract, final or empty. | 79 |
| Missing a Javadoc comment. | 79 |
| Parameter message should be final. | 79 |
| Line contains a tab character. | 80 |
| Parameter context should be final. | 80 |
| Line is longer than 80 characters. | 81 |
| Line contains a tab character. | 81 |
| '+' is not preceded with whitespace. | 81 |
| Line contains a tab character. | 82 |
| Line contains a tab character. | 84 |
| Line contains a tab character. | 86 |
| Method 'onBecomeOfflineFromSlave' is not designed for extension - needs to be abstract, final or empty. | 86 |
| Missing a Javadoc comment. | 86 |
| Parameter message should be final. | 86 |
| Line contains a tab character. | 87 |
| Parameter context should be final. | 87 |
| Line is longer than 80 characters. | 88 |
| Line contains a tab character. | 88 |
| '+' is not preceded with whitespace. | 88 |
| Line contains a tab character. | 89 |
| Line contains a tab character. | 91 |
| Line has trailing spaces. | 92 |
| Line contains a tab character. | 92 |
| Line contains a tab character. | 93 |
| Method 'onBecomeDroppedFromOffline' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Missing a Javadoc comment. | 93 |
| Parameter message should be final. | 93 |
| Parameter context should be final. | 94 |
| '+' is not preceded with whitespace. | 95 |
| Line contains a tab character. | 99 |
org/apache/helix/ExternalCommand.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 36 |
| '{' should be on the previous line. | 37 |
| Missing a Javadoc comment. | 38 |
| Missing a Javadoc comment. | 39 |
| Missing a Javadoc comment. | 41 |
| Name '_processBuilder' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 41 |
| Missing a Javadoc comment. | 43 |
| Name '_process' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 43 |
| Missing a Javadoc comment. | 44 |
| Name '_out' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 44 |
| Missing a Javadoc comment. | 45 |
| Name '_err' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 45 |
| Missing a Javadoc comment. | 47 |
| '{' should be on the previous line. | 48 |
| Missing a Javadoc comment. | 49 |
| Missing a Javadoc comment. | 51 |
| Name '_in' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 51 |
| Missing a Javadoc comment. | 52 |
| Name '_out' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 52 |
| Missing a Javadoc comment. | 53 |
| Name '_running' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 53 |
| Missing a Javadoc comment. | 55 |
| Parameter in should be final. | 55 |
| '{' should be on the previous line. | 56 |
| '{' should be on the previous line. | 63 |
| '{' should be on the previous line. | 69 |
| 'while' construct must use '{}'s. | 70 |
| 'while' is not followed by whitespace. | 70 |
| '}' should be on the same line. | 72 |
| 'catch' is not followed by whitespace. | 73 |
| '{' should be on the previous line. | 74 |
| Missing a Javadoc comment. | 81 |
| '{' should be on the previous line. | 82 |
| 'if' construct must use '{}'s. | 83 |
| 'if' is not followed by whitespace. | 83 |
| First sentence should end with a period. | 89 |
| Parameter processBuilder should be final. | 91 |
| Expected @param tag for 'processBuilder'. | 91 |
| '{' should be on the previous line. | 92 |
| Method 'start' is not designed for extension - needs to be abstract, final or empty. | 101 |
| Expected @throws tag for 'IOException'. | 101 |
| '{' should be on the previous line. | 102 |
| Expected an @return tag. | 114 |
| Method 'getEnvironment' is not designed for extension - needs to be abstract, final or empty. | 114 |
| '{' should be on the previous line. | 115 |
| Expected an @return tag. | 122 |
| Method 'getWorkingDirectory' is not designed for extension - needs to be abstract, final or empty. | 122 |
| '{' should be on the previous line. | 123 |
| Method 'setWorkingDirectory' is not designed for extension - needs to be abstract, final or empty. | 130 |
| Parameter directory should be final. | 130 |
| Expected @param tag for 'directory'. | 130 |
| '{' should be on the previous line. | 131 |
| Expected an @return tag. | 138 |
| Method 'getRedirectErrorStream' is not designed for extension - needs to be abstract, final or empty. | 138 |
| '{' should be on the previous line. | 139 |
| Method 'setRedirectErrorStream' is not designed for extension - needs to be abstract, final or empty. | 146 |
| Parameter redirectErrorStream should be final. | 146 |
| Expected @param tag for 'redirectErrorStream'. | 146 |
| '{' should be on the previous line. | 147 |
| Method 'getOutput' is not designed for extension - needs to be abstract, final or empty. | 151 |
| Missing a Javadoc comment. | 151 |
| '{' should be on the previous line. | 152 |
| Method 'getError' is not designed for extension - needs to be abstract, final or empty. | 157 |
| Missing a Javadoc comment. | 157 |
| '{' should be on the previous line. | 158 |
| Method 'getStringOutput' is not designed for extension - needs to be abstract, final or empty. | 171 |
| Parameter encoding should be final. | 171 |
| Expected @param tag for 'encoding'. | 171 |
| Expected @throws tag for 'InterruptedException'. | 171 |
| Line is longer than 80 characters. | 172 |
| Expected @throws tag for 'UnsupportedEncodingException'. | 172 |
| Method 'getStringOutput' is not designed for extension - needs to be abstract, final or empty. | 183 |
| Expected @throws tag for 'InterruptedException'. | 183 |
| '{' should be on the previous line. | 184 |
| '{' should be on the previous line. | 186 |
| '}' should be on the same line. | 188 |
| 'catch' is not followed by whitespace. | 189 |
| '{' should be on the previous line. | 190 |
| Method 'getStringError' is not designed for extension - needs to be abstract, final or empty. | 204 |
| Parameter encoding should be final. | 204 |
| Expected @param tag for 'encoding'. | 204 |
| Expected @throws tag for 'InterruptedException'. | 204 |
| Line is longer than 80 characters. | 205 |
| Expected @throws tag for 'UnsupportedEncodingException'. | 205 |
| Method 'getStringError' is not designed for extension - needs to be abstract, final or empty. | 216 |
| Expected @throws tag for 'InterruptedException'. | 216 |
| '{' should be on the previous line. | 217 |
| '{' should be on the previous line. | 219 |
| '}' should be on the same line. | 221 |
| 'catch' is not followed by whitespace. | 222 |
| '{' should be on the previous line. | 223 |
| Method 'waitFor' is not designed for extension - needs to be abstract, final or empty. | 237 |
| Expected @throws tag for 'InterruptedException'. | 237 |
| '{' should be on the previous line. | 238 |
| 'if' construct must use '{}'s. | 239 |
| 'if' is not followed by whitespace. | 239 |
| Method 'waitFor' is not designed for extension - needs to be abstract, final or empty. | 258 |
| Parameter timeout should be final. | 258 |
| Expected @param tag for 'timeout'. | 258 |
| Expected @throws tag for 'InterruptedException'. | 258 |
| Expected @throws tag for 'TimeoutException'. | 258 |
| 'if' construct must use '{}'s. | 260 |
| 'if' is not followed by whitespace. | 260 |
| 'if' construct must use '{}'s. | 266 |
| 'if' construct must use '{}'s. | 270 |
| Method 'exitValue' is not designed for extension - needs to be abstract, final or empty. | 278 |
| Missing a Javadoc comment. | 278 |
| '{' should be on the previous line. | 279 |
| 'if' construct must use '{}'s. | 280 |
| 'if' is not followed by whitespace. | 280 |
| Method 'destroy' is not designed for extension - needs to be abstract, final or empty. | 286 |
| Missing a Javadoc comment. | 286 |
| '{' should be on the previous line. | 287 |
| 'if' construct must use '{}'s. | 288 |
| 'if' is not followed by whitespace. | 288 |
| Line is longer than 80 characters. | 295 |
| Parameter commands should be final. | 300 |
| '{' should be on the previous line. | 301 |
| Line is longer than 80 characters. | 307 |
| Parameter commands should be final. | 312 |
| '{' should be on the previous line. | 313 |
| Parameter commands should be final. | 324 |
| '{' should be on the previous line. | 325 |
| Line is longer than 80 characters. | 332 |
| Line is longer than 80 characters. | 336 |
| Line has trailing spaces. | 338 |
| Parameter workingDirectory should be final. | 340 |
| Parameter command should be final. | 341 |
| Parameter args should be final. | 342 |
| Expected @throws tag for 'IOException'. | 343 |
| Expected @throws tag for 'InterruptedException'. | 343 |
| '{' should be on the previous line. | 344 |
| '{' should be on the previous line. | 346 |
| '}' should be on the same line. | 348 |
| '{' should be on the previous line. | 350 |
| Line is longer than 80 characters. | 352 |
| Line is longer than 80 characters. | 357 |
| Parameter workingDirectory should be final. | 371 |
| Parameter command should be final. | 372 |
| Parameter timeout should be final. | 373 |
| Parameter args should be final. | 374 |
| Expected @throws tag for 'IOException'. | 375 |
| Expected @throws tag for 'InterruptedException'. | 375 |
| Expected @throws tag for 'TimeoutException'. | 375 |
| '{' should be on the previous line. | 376 |
| 'if' construct must use '{}'s. | 391 |
| 'else' construct must use '{}'s. | 393 |
| 'if' construct must use '{}'s. | 396 |
org/apache/helix/ExternalViewChangeListener.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 27 |
| '{' should be on the previous line. | 28 |
| First sentence should end with a period. | 30 |
| Line has trailing spaces. | 32 |
| Redundant 'public' modifier. | 36 |
| Expected @param tag for 'externalViewList'. | 36 |
| Expected @param tag for 'changeContext'. | 37 |
org/apache/helix/FnvHashFunction.java
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 |
| Missing a Javadoc comment. | 22 |
| '{' should be on the previous line. | 23 |
| Missing a Javadoc comment. | 24 |
| Missing a Javadoc comment. | 25 |
| '24' is a magic number. | 25 |
| '0x193' is a magic number. | 25 |
| Method 'hash' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter buf should be final. | 28 |
| '{' should be on the previous line. | 29 |
| Line contains a tab character. | 30 |
| Method 'hash' is not designed for extension - needs to be abstract, final or empty. | 34 |
| Parameter buf should be final. | 35 |
| Parameter off should be final. | 35 |
| Parameter len should be final. | 35 |
| '{' should be on the previous line. | 36 |
| '=' is not preceded with whitespace. | 41 |
| '=' is not followed by whitespace. | 41 |
| '<' is not preceded with whitespace. | 41 |
| '{' should be on the previous line. | 42 |
| '0xFF' is a magic number. | 43 |
| Line contains a tab character. | 49 |
| Method 'hash' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Missing a Javadoc comment. | 49 |
| Parameter key should be final. | 49 |
| Line contains a tab character. | 50 |
| '{' should be on the previous line. | 50 |
| 'for' is not followed by whitespace. | 52 |
| '0xFF' is a magic number. | 53 |
| Line contains a tab character. | 58 |
| Line contains a tab character. | 60 |
| Method 'hash' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Line contains a tab character. | 61 |
| Parameter key should be final. | 61 |
| Parameter numBuckets should be final. | 61 |
| Line contains a tab character. | 62 |
| '{' should be on the previous line. | 62 |
| Line contains a tab character. | 63 |
| '%' is not preceded with whitespace. | 63 |
| '%' is not followed by whitespace. | 63 |
| Line contains a tab character. | 64 |
| Line contains a tab character. | 67 |
| Missing a Javadoc comment. | 67 |
| Parameter val should be final. | 67 |
| Line contains a tab character. | 68 |
| '{' should be on the previous line. | 68 |
| Line contains a tab character. | 69 |
| Line contains a tab character. | 71 |
| 'for' is not followed by whitespace. | 71 |
| '8' is a magic number. | 71 |
| Line contains a tab character. | 72 |
| '{' should be on the previous line. | 72 |
| Line contains a tab character. | 73 |
| '0x00ff' is a magic number. | 73 |
| Line contains a tab character. | 74 |
| '8' is a magic number. | 74 |
| Line contains a tab character. | 76 |
| Line contains a tab character. | 77 |
| Line contains a tab character. | 78 |
| Line contains a tab character. | 79 |
| 'cast' is not followed by whitespace. | 79 |
| Line contains a tab character. | 80 |
| Line contains a tab character. | 82 |
| Method 'hash' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Line contains a tab character. | 83 |
| Parameter val should be final. | 83 |
| Parameter numBuckets should be final. | 83 |
| Line contains a tab character. | 84 |
| '{' should be on the previous line. | 84 |
| Line contains a tab character. | 85 |
| '%' is not preceded with whitespace. | 85 |
| '%' is not followed by whitespace. | 85 |
| Line contains a tab character. | 86 |
| Line contains a tab character. | 88 |
| Line contains a tab character. | 89 |
| Line contains a tab character. | 90 |
| Line contains a tab character. | 91 |
| Line is longer than 80 characters. | 92 |
| Line contains a tab character. | 92 |
| Line contains a tab character. | 93 |
| Line contains a tab character. | 94 |
| Line contains a tab character. | 95 |
| Line contains a tab character. | 97 |
| Line contains a tab character. | 98 |
| Line contains a tab character. | 99 |
| Line contains a tab character. | 101 |
| Line contains a tab character. | 102 |
| Line contains a tab character. | 103 |
| Line contains a tab character. | 104 |
| Line contains a tab character. | 105 |
| Line contains a tab character. | 107 |
| Line contains a tab character. | 108 |
| Line contains a tab character. | 109 |
| Line contains a tab character. | 110 |
| Line contains a tab character. | 111 |
| Line contains a tab character. | 112 |
| Line contains a tab character. | 113 |
| Line contains a tab character. | 114 |
| Line contains a tab character. | 115 |
| Line contains a tab character. | 116 |
| Line contains a tab character. | 117 |
| Line contains a tab character. | 118 |
| Line contains a tab character. | 119 |
| Line contains a tab character. | 121 |
| Line is longer than 80 characters. | 123 |
| Line contains a tab character. | 123 |
| Line contains a tab character. | 125 |
| Line contains a tab character. | 126 |
| Line contains a tab character. | 127 |
| Line contains a tab character. | 128 |
| Line contains a tab character. | 129 |
| Line contains a tab character. | 130 |
| Line contains a tab character. | 131 |
| Line contains a tab character. | 132 |
| Line contains a tab character. | 133 |
| Line contains a tab character. | 134 |
| Line is longer than 80 characters. | 135 |
| Line contains a tab character. | 135 |
| Line contains a tab character. | 137 |
| Line contains a tab character. | 138 |
| Line contains a tab character. | 139 |
| Line contains a tab character. | 140 |
| Line contains a tab character. | 141 |
| Line contains a tab character. | 142 |
| Line contains a tab character. | 143 |
| Line contains a tab character. | 144 |
| Line contains a tab character. | 145 |
| Line contains a tab character. | 146 |
| Line is longer than 80 characters. | 147 |
| Line contains a tab character. | 147 |
| Line contains a tab character. | 149 |
| Line contains a tab character. | 150 |
| Line contains a tab character. | 151 |
| Line contains a tab character. | 152 |
| Line contains a tab character. | 153 |
| Line contains a tab character. | 154 |
| Line contains a tab character. | 155 |
| Line contains a tab character. | 156 |
| Line contains a tab character. | 157 |
| Line contains a tab character. | 158 |
| Line is longer than 80 characters. | 159 |
| Line contains a tab character. | 159 |
| Line is longer than 80 characters. | 161 |
| Line contains a tab character. | 161 |
| Line contains a tab character. | 163 |
| Line contains a tab character. | 164 |
| Line contains a tab character. | 165 |
| Line contains a tab character. | 166 |
| Line contains a tab character. | 167 |
| Line contains a tab character. | 168 |
| Line contains a tab character. | 169 |
| Line contains a tab character. | 170 |
| Line contains a tab character. | 171 |
| Line contains a tab character. | 172 |
| Line is longer than 80 characters. | 173 |
| Line contains a tab character. | 173 |
| Line is longer than 80 characters. | 174 |
| Line contains a tab character. | 174 |
| Line contains a tab character. | 176 |
| Line contains a tab character. | 177 |
| Line contains a tab character. | 178 |
| Line contains a tab character. | 179 |
| Line contains a tab character. | 180 |
| Line contains a tab character. | 181 |
| Line contains a tab character. | 182 |
| Line contains a tab character. | 183 |
| Line contains a tab character. | 184 |
| Line contains a tab character. | 185 |
| Line is longer than 80 characters. | 186 |
| Line contains a tab character. | 186 |
| Line is longer than 80 characters. | 187 |
| Line contains a tab character. | 187 |
| Line contains a tab character. | 188 |
| Line contains a tab character. | 189 |
| Line contains a tab character. | 190 |
| Line contains a tab character. | 191 |
| Line contains a tab character. | 192 |
| Line contains a tab character. | 193 |
| Line contains a tab character. | 194 |
| Line contains a tab character. | 195 |
| Line contains a tab character. | 196 |
| Line contains a tab character. | 197 |
| Line is longer than 80 characters. | 198 |
| Line contains a tab character. | 198 |
| Line is longer than 80 characters. | 200 |
| Line contains a tab character. | 200 |
| Line contains a tab character. | 201 |
| Line contains a tab character. | 202 |
org/apache/helix/GroupCommit.java
| Violation | Message | Line |
|---|---|---|
| Comment matches to-do format 'TODO:'. | 31 |
| Missing a Javadoc comment. | 32 |
| Line has trailing spaces. | 33 |
| '{' should be on the previous line. | 33 |
| Missing a Javadoc comment. | 34 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 34 |
| Missing a Javadoc comment. | 35 |
| '{' should be on the previous line. | 36 |
| Missing a Javadoc comment. | 37 |
| Name '_running' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 37 |
| Variable '_running' must be private and have accessor methods. | 37 |
| Line is longer than 80 characters. | 38 |
| Missing a Javadoc comment. | 38 |
| Name '_pending' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
| Variable '_pending' must be private and have accessor methods. | 38 |
| Missing a Javadoc comment. | 41 |
| '{' should be on the previous line. | 42 |
| Missing a Javadoc comment. | 43 |
| Name '_key' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 43 |
| Variable '_key' must be private and have accessor methods. | 43 |
| Missing a Javadoc comment. | 44 |
| Name '_record' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 44 |
| Variable '_record' must be private and have accessor methods. | 44 |
| Missing a Javadoc comment. | 45 |
| Name '_sent' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 45 |
| Variable '_sent' must be private and have accessor methods. | 45 |
| Missing a Javadoc comment. | 47 |
| Parameter key should be final. | 47 |
| Parameter record should be final. | 47 |
| '{' should be on the previous line. | 48 |
| Missing a Javadoc comment. | 54 |
| Name '_queues' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 54 |
| '100' is a magic number. | 54 |
| Line has trailing spaces. | 55 |
| Comment matches to-do format 'TODO:'. | 57 |
| Line is longer than 80 characters. | 58 |
| Line has trailing spaces. | 60 |
| Missing a Javadoc comment. | 61 |
| '{' should be on the previous line. | 62 |
| '{' should be on the previous line. | 65 |
| Missing a Javadoc comment. | 70 |
| Parameter key should be final. | 70 |
| '{' should be on the previous line. | 71 |
| Line is longer than 80 characters. | 75 |
| Method 'commit' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Missing a Javadoc comment. | 75 |
| Parameter accessor should be final. | 75 |
| Parameter options should be final. | 75 |
| Parameter key should be final. | 75 |
| Parameter record should be final. | 75 |
| '{' should be on the previous line. | 83 |
| '{' should be on the previous line. | 85 |
| '{' should be on the previous line. | 88 |
| 'if' construct must use '{}'s. | 89 |
| Line has trailing spaces. | 99 |
| '{' should be on the previous line. | 101 |
| '}' should be on the same line. | 104 |
| '{' should be on the previous line. | 106 |
| Must have at least one statement. | 106 |
| Line has trailing spaces. | 109 |
| Line has trailing spaces. | 111 |
| Line is longer than 80 characters. | 111 |
| '{' should be on the previous line. | 115 |
| Line is longer than 80 characters. | 130 |
| Avoid nested blocks. | 131 |
| '}' should be on the same line. | 134 |
| '{' should be on the previous line. | 136 |
| '{' should be on the previous line. | 141 |
| 'if' construct must use '{}'s. | 143 |
| Line is longer than 80 characters. | 152 |
| '}' should be on the same line. | 154 |
| '{' should be on the previous line. | 156 |
| '{' should be on the previous line. | 159 |
| '{' should be on the previous line. | 161 |
| '}' should be on the same line. | 167 |
| '{' should be on the previous line. | 169 |
| '{' should be on the previous line. | 171 |
| '{' should be on the previous line. | 173 |
| '10' is a magic number. | 174 |
| '}' should be on the same line. | 175 |
| '{' should be on the previous line. | 177 |
org/apache/helix/HashFunction.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| Line has trailing spaces. | 23 |
| Line contains a tab character. | 23 |
| Line contains a tab character. | 25 |
| Line contains a tab character. | 26 |
| Line contains a tab character. | 27 |
| Line contains a tab character. | 28 |
| Line contains a tab character. | 29 |
| Line contains a tab character. | 30 |
| Missing a Javadoc comment. | 30 |
| Redundant 'public' modifier. | 30 |
| Line has trailing spaces. | 31 |
| Line contains a tab character. | 31 |
| Line contains a tab character. | 32 |
| Line contains a tab character. | 33 |
| Line contains a tab character. | 34 |
| Line has trailing spaces. | 35 |
| Line contains a tab character. | 35 |
| Line contains a tab character. | 36 |
| Line contains a tab character. | 37 |
| Line has trailing spaces. | 38 |
| Line contains a tab character. | 38 |
| Line contains a tab character. | 39 |
| Line contains a tab character. | 40 |
| Line contains a tab character. | 41 |
| Missing a Javadoc comment. | 41 |
| Redundant 'public' modifier. | 41 |
| Line has trailing spaces. | 42 |
| Line contains a tab character. | 42 |
| Line contains a tab character. | 43 |
| Line contains a tab character. | 44 |
| Line contains a tab character. | 45 |
| Line has trailing spaces. | 46 |
| Line contains a tab character. | 46 |
| Line contains a tab character. | 47 |
| Line contains a tab character. | 48 |
| Line has trailing spaces. | 49 |
| Line contains a tab character. | 49 |
| Line contains a tab character. | 50 |
| Line contains a tab character. | 51 |
| Line contains a tab character. | 52 |
| Missing a Javadoc comment. | 52 |
| Redundant 'public' modifier. | 52 |
| Line has trailing spaces. | 53 |
| Line contains a tab character. | 53 |
| Line contains a tab character. | 54 |
| Line contains a tab character. | 55 |
| Line contains a tab character. | 56 |
| Line has trailing spaces. | 57 |
| Line contains a tab character. | 57 |
| Line contains a tab character. | 58 |
| Line contains a tab character. | 59 |
| Line has trailing spaces. | 60 |
| Line contains a tab character. | 60 |
| Line contains a tab character. | 61 |
| Line contains a tab character. | 62 |
| Line contains a tab character. | 63 |
| Missing a Javadoc comment. | 63 |
| Redundant 'public' modifier. | 63 |
org/apache/helix/HealthStateChangeListener.java
| Violation | Message | Line |
|---|---|---|
| Unused import - org.apache.helix.model.Message. | 25 |
| Missing a Javadoc comment. | 28 |
| '{' should be on the previous line. | 29 |
| First sentence should end with a period. | 31 |
| Line has trailing spaces. | 33 |
| Redundant 'public' modifier. | 38 |
| Expected @param tag for 'instanceName'. | 38 |
| Expected @param tag for 'reports'. | 39 |
| Expected @param tag for 'changeContext'. | 40 |
org/apache/helix/HelixAdmin.java
| Violation | Message | Line |
|---|---|---|
| Unused import - java.util.Set. | 25 |
| Using the '.*' form of import should be avoided - org.apache.helix.model.*. | 27 |
| Unused import - org.apache.helix.model.HelixConfigScope.ConfigScopeProperty. | 29 |
| Missing a Javadoc comment. | 32 |
| '{' should be on the previous line. | 33 |
| First sentence should end with a period. | 34 |
| Line has trailing spaces. | 36 |
| Expected an @return tag. | 39 |
| First sentence should end with a period. | 41 |
| Line has trailing spaces. | 43 |
| Expected an @return tag. | 47 |
| Expected @param tag for 'clusterName'. | 47 |
| First sentence should end with a period. | 49 |
| Line has trailing spaces. | 51 |
| Expected an @return tag. | 56 |
| Expected @param tag for 'clusterName'. | 56 |
| Expected @param tag for 'instanceName'. | 56 |
| First sentence should end with a period. | 58 |
| Line has trailing spaces. | 60 |
| Expected an @return tag. | 64 |
| Expected @param tag for 'clusterName'. | 64 |
| First sentence should end with a period. | 66 |
| Line has trailing spaces. | 68 |
| Expected @param tag for 'clusterName'. | 72 |
| First sentence should end with a period. | 73 |
| Line has trailing spaces. | 75 |
| Line is longer than 80 characters. | 77 |
| Expected @param tag for 'clusterName'. | 80 |
| First sentence should end with a period. | 82 |
| Line is longer than 80 characters. | 83 |
| Line has trailing spaces. | 84 |
| Expected @param tag for 'clusterName'. | 88 |
| Expected @param tag for 'grandCluster'. | 88 |
| First sentence should end with a period. | 90 |
| Line has trailing spaces. | 92 |
| Expected @param tag for 'clusterName'. | 98 |
| Expected @param tag for 'resourceName'. | 99 |
| Expected @param tag for 'numResources'. | 100 |
| Expected @param tag for 'stateModelRef'. | 101 |
| Line has trailing spaces. | 103 |
| Expected @param tag for 'clusterName'. | 108 |
| Expected @param tag for 'resourceName'. | 109 |
| Expected @param tag for 'idealstate'. | 110 |
| First sentence should end with a period. | 112 |
| Line has trailing spaces. | 114 |
| Expected @param tag for 'clusterName'. | 121 |
| Expected @param tag for 'resourceName'. | 122 |
| Expected @param tag for 'numResources'. | 123 |
| Expected @param tag for 'stateModelRef'. | 124 |
| Expected @param tag for 'idealStateMode'. | 125 |
| First sentence should end with a period. | 127 |
| Line has trailing spaces. | 129 |
| Expected @param tag for 'clusterName'. | 137 |
| Expected @param tag for 'resourceName'. | 138 |
| Expected @param tag for 'numResources'. | 139 |
| Expected @param tag for 'stateModelRef'. | 140 |
| Expected @param tag for 'idealStateMode'. | 141 |
| Expected @param tag for 'bucketSize'. | 142 |
| Line has trailing spaces. | 143 |
| First sentence should end with a period. | 144 |
| Line has trailing spaces. | 146 |
| Expected @param tag for 'clusterName'. | 155 |
| Expected @param tag for 'resourceName'. | 156 |
| Expected @param tag for 'numResources'. | 157 |
| Expected @param tag for 'stateModelRef'. | 158 |
| Expected @param tag for 'idealStateMode'. | 159 |
| Expected @param tag for 'bucketSize'. | 160 |
| Expected @param tag for 'maxPartitionsPerInstance'. | 161 |
| Line has trailing spaces. | 162 |
| First sentence should end with a period. | 163 |
| Line has trailing spaces. | 165 |
| Expected @param tag for 'clusterName'. | 169 |
| Expected @param tag for 'instanceConfig'. | 169 |
| First sentence should end with a period. | 171 |
| Line has trailing spaces. | 173 |
| Expected @param tag for 'clusterName'. | 177 |
| Expected @param tag for 'instanceConfig'. | 177 |
| First sentence should end with a period. | 179 |
| Line has trailing spaces. | 181 |
| Expected an @return tag. | 186 |
| Expected @param tag for 'clusterName'. | 186 |
| Expected @param tag for 'resourceName'. | 186 |
| First sentence should end with a period. | 188 |
| Line has trailing spaces. | 190 |
| Expected @param tag for 'clusterName'. | 195 |
| Expected @param tag for 'resourceName'. | 196 |
| Expected @param tag for 'idealState'. | 197 |
| First sentence should end with a period. | 199 |
| Line has trailing spaces. | 201 |
| Expected @param tag for 'clusterName'. | 206 |
| Expected @param tag for 'instanceName'. | 206 |
| Expected @param tag for 'enabled'. | 206 |
| First sentence should end with a period. | 208 |
| Line has trailing spaces. | 210 |
| Expected @param tag for 'enabled'. | 217 |
| Expected @param tag for 'clusterName'. | 218 |
| Expected @param tag for 'instanceName'. | 219 |
| Expected @param tag for 'resourceName'. | 220 |
| Expected @param tag for 'partitionNames'. | 221 |
| First sentence should end with a period. | 223 |
| Line has trailing spaces. | 225 |
| Expected @param tag for 'clusterName'. | 229 |
| Expected @param tag for 'enabled'. | 229 |
| Line has trailing spaces. | 233 |
| Line is longer than 80 characters. | 234 |
| Line is longer than 80 characters. | 235 |
| Line has trailing spaces. | 236 |
| Expected @param tag for 'clusterName'. | 242 |
| Expected @param tag for 'instanceName'. | 243 |
| Expected @param tag for 'resourceName'. | 244 |
| Expected @param tag for 'partitionNames'. | 245 |
| First sentence should end with a period. | 247 |
| Line has trailing spaces. | 249 |
| Expected @param tag for 'clusterName'. | 253 |
| Expected @param tag for 'instanceNames'. | 253 |
| First sentence should end with a period. | 255 |
| Line has trailing spaces. | 257 |
| Expected @param tag for 'clusterName'. | 261 |
| Expected @param tag for 'resourceNames'. | 261 |
| First sentence should end with a period. | 263 |
| Line has trailing spaces. | 265 |
| Expected @param tag for 'clusterName'. | 270 |
| Expected @param tag for 'stateModelDef'. | 271 |
| Expected @param tag for 'record'. | 272 |
| First sentence should end with a period. | 274 |
| Line has trailing spaces. | 276 |
| Expected @param tag for 'clusterName'. | 280 |
| Expected @param tag for 'resourceName'. | 280 |
| First sentence should end with a period. | 282 |
| Line has trailing spaces. | 284 |
| Expected @param tag for 'clusterName'. | 288 |
| Expected @param tag for 'statName'. | 288 |
| First sentence should end with a period. | 290 |
| Line has trailing spaces. | 292 |
| Expected @param tag for 'clusterName'. | 296 |
| Expected @param tag for 'alertName'. | 296 |
| First sentence should end with a period. | 298 |
| Line has trailing spaces. | 300 |
| Expected @param tag for 'clusterName'. | 304 |
| Expected @param tag for 'statName'. | 304 |
| First sentence should end with a period. | 306 |
| Line has trailing spaces. | 308 |
| Expected @param tag for 'clusterName'. | 312 |
| Expected @param tag for 'alertName'. | 312 |
| First sentence should end with a period. | 314 |
| Line has trailing spaces. | 316 |
| Expected an @return tag. | 320 |
| Expected @param tag for 'clusterName'. | 320 |
| First sentence should end with a period. | 322 |
| Line has trailing spaces. | 324 |
| Expected an @return tag. | 329 |
| Line is longer than 80 characters. | 329 |
| Expected @param tag for 'clusterName'. | 329 |
| Expected @param tag for 'stateModelName'. | 329 |
| First sentence should end with a period. | 331 |
| Line has trailing spaces. | 333 |
| Expected an @return tag. | 338 |
| Expected @param tag for 'clusterName'. | 338 |
| Expected @param tag for 'resourceName'. | 338 |
| First sentence should end with a period. | 340 |
| Line has trailing spaces. | 342 |
| Expected @param tag for 'clusterName'. | 345 |
| First sentence should end with a period. | 347 |
| Line has trailing spaces. | 349 |
| Expected @param tag for 'scope'. | 353 |
| Expected @param tag for 'properties'. | 353 |
| First sentence should end with a period. | 355 |
| Line has trailing spaces. | 357 |
| Expected @param tag for 'scope'. | 361 |
| Expected @param tag for 'keys'. | 361 |
| First sentence should end with a period. | 363 |
| Line has trailing spaces. | 365 |
| Expected an @return tag. | 370 |
| Expected @param tag for 'scope'. | 370 |
| Expected @param tag for 'keys'. | 370 |
| First sentence should end with a period. | 372 |
| Line has trailing spaces. | 374 |
| Expected an @return tag. | 378 |
| Expected @param tag for 'scope'. | 378 |
| First sentence should end with a period. | 380 |
| Line has trailing spaces. | 382 |
| Expected @param tag for 'clusterName'. | 387 |
| Expected @param tag for 'resourceName'. | 387 |
| Expected @param tag for 'replica'. | 387 |
| First sentence should end with a period. | 389 |
| Line has trailing spaces. | 391 |
| Line is longer than 80 characters. | 397 |
| Expected @param tag for 'clusterName'. | 397 |
| Expected @param tag for 'resourceName'. | 397 |
| Expected @param tag for 'idealStateFile'. | 397 |
| Expected @throws tag for 'IOException'. | 397 |
| First sentence should end with a period. | 399 |
| Line has trailing spaces. | 401 |
| Expected @param tag for 'clusterName'. | 407 |
| Expected @param tag for 'stateModelDefName'. | 408 |
| Expected @param tag for 'stateModelDefFile'. | 409 |
| Expected @throws tag for 'IOException'. | 409 |
| First sentence should end with a period. | 411 |
| Line has trailing spaces. | 413 |
| Expected @param tag for 'clusterName'. | 419 |
| Expected @param tag for 'constraintType'. | 420 |
| Expected @param tag for 'constraintId'. | 421 |
| Expected @param tag for 'constraintItem'. | 422 |
| First sentence should end with a period. | 424 |
| Line has trailing spaces. | 426 |
| Line has trailing spaces. | 431 |
| Expected @param tag for 'clusterName'. | 431 |
| Line has trailing spaces. | 432 |
| Expected @param tag for 'constraintType'. | 432 |
| Expected @param tag for 'constraintId'. | 433 |
| Line has trailing spaces. | 434 |
| First sentence should end with a period. | 435 |
| Line has trailing spaces. | 437 |
| Expected an @return tag. | 442 |
| Expected @param tag for 'clusterName'. | 442 |
| Expected @param tag for 'constraintType'. | 443 |
| Line has trailing spaces. | 444 |
| Line has trailing spaces. | 446 |
| Line has trailing spaces. | 452 |
| Expected @param tag for 'clusterName'. | 452 |
| Expected @param tag for 'currentIdealState'. | 453 |
| Expected @param tag for 'instanceNames'. | 454 |
| Line has trailing spaces. | 456 |
| Expected @param tag for 'clusterName'. | 462 |
| Expected @param tag for 'resourceName'. | 462 |
| Expected @param tag for 'replica'. | 462 |
| Expected @param tag for 'instances'. | 463 |
| Line has trailing spaces. | 465 |
| Expected @param tag for 'clusterName'. | 471 |
| Expected @param tag for 'resourceName'. | 471 |
| Expected @param tag for 'replica'. | 471 |
| Expected @param tag for 'keyPrefix'. | 472 |
| Expected @param tag for 'group'. | 472 |
| Line has trailing spaces. | 474 |
| Expected an @return tag. | 478 |
| Expected @param tag for 'clusterName'. | 478 |
| Expected @param tag for 'tag'. | 478 |
| Line has trailing spaces. | 479 |
| Line has trailing spaces. | 481 |
| Expected @param tag for 'clusterName'. | 487 |
| Expected @param tag for 'instanceName'. | 487 |
| Expected @param tag for 'tag'. | 487 |
| Line has trailing spaces. | 488 |
| Line has trailing spaces. | 490 |
| Expected @param tag for 'clusterName'. | 496 |
| Expected @param tag for 'instanceName'. | 496 |
| Expected @param tag for 'tag'. | 496 |
| Line has trailing spaces. | 497 |
| First sentence should end with a period. | 498 |
| Line has trailing spaces. | 499 |
org/apache/helix/HelixConstants.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| interfaces should describe a type and hence have methods. | 22 |
| '{' should be on the previous line. | 23 |
| Comment matches to-do format 'TODO:'. | 24 |
| Missing a Javadoc comment. | 25 |
| '{' should be on the previous line. | 26 |
| Missing a Javadoc comment. | 28 |
| Missing a Javadoc comment. | 29 |
| Missing a Javadoc comment. | 30 |
| Missing a Javadoc comment. | 31 |
| Missing a Javadoc comment. | 32 |
| Missing a Javadoc comment. | 33 |
| Missing a Javadoc comment. | 34 |
| Missing a Javadoc comment. | 35 |
| Missing a Javadoc comment. | 36 |
| Missing a Javadoc comment. | 37 |
| Missing a Javadoc comment. | 41 |
| '{' should be on the previous line. | 42 |
| Missing a Javadoc comment. | 43 |
| Missing a Javadoc comment. | 46 |
| '{' should be on the previous line. | 47 |
| Missing a Javadoc comment. | 48 |
| Line has trailing spaces. | 50 |
| Missing a Javadoc comment. | 51 |
| Redundant 'static' modifier. | 51 |
org/apache/helix/HelixDataAccessor.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 30 |
| Line has trailing spaces. | 31 |
| Line has trailing spaces. | 32 |
| '{' should be on the previous line. | 35 |
| Line has trailing spaces. | 38 |
| Expected @param tag for '<T>'. | 45 |
| Expected @param tag for 'key'. | 45 |
| Expected @param tag for 'value'. | 45 |
| Line has trailing spaces. | 52 |
| Expected an @return tag. | 57 |
| Expected @param tag for '<T>'. | 57 |
| Expected @param tag for 'key'. | 57 |
| Expected @param tag for 'value'. | 57 |
| First sentence should end with a period. | 59 |
| Line has trailing spaces. | 61 |
| Expected @param tag for '<T>'. | 66 |
| Expected @param tag for 'key'. | 66 |
| Expected @param tag for 'value'. | 66 |
| Line has trailing spaces. | 71 |
| Expected @param tag for '<T>'. | 75 |
| Expected @param tag for 'key'. | 75 |
| Line is longer than 80 characters. | 78 |
| Line has trailing spaces. | 80 |
| Expected an @return tag. | 84 |
| Redundant 'public' modifier. | 84 |
| Expected @param tag for '<T>'. | 84 |
| Expected @param tag for 'keys'. | 84 |
| First sentence should end with a period. | 86 |
| Line has trailing spaces. | 88 |
| Expected @param tag for 'key'. | 93 |
| Line has trailing spaces. | 98 |
| Expected @param tag for 'key'. | 102 |
| Line has trailing spaces. | 107 |
| Expected @param tag for '<T>'. | 111 |
| Expected @param tag for 'key'. | 111 |
| First sentence should end with a period. | 113 |
| Line has trailing spaces. | 116 |
| Expected an @return tag. | 121 |
| Expected @param tag for '<T>'. | 121 |
| Expected @param tag for 'key'. | 121 |
| Line has trailing spaces. | 125 |
| Expected an @return tag. | 130 |
| Expected @param tag for '<T>'. | 130 |
| Expected @param tag for 'keys'. | 130 |
| Expected @param tag for 'children'. | 131 |
| First sentence should end with a period. | 133 |
| Line has trailing spaces. | 135 |
| Expected an @return tag. | 139 |
| Line is longer than 80 characters. | 139 |
| Expected @param tag for '<T>'. | 139 |
| Expected @param tag for 'keys'. | 139 |
| Expected @param tag for 'children'. | 139 |
| Line has trailing spaces. | 140 |
| First sentence should end with a period. | 141 |
| Comment matches to-do format 'TODO:'. | 143 |
| Line has trailing spaces. | 144 |
| Expected an @return tag. | 148 |
| Expected @param tag for '<T>'. | 148 |
| Expected @param tag for 'paths'. | 148 |
| Expected @param tag for 'updaters'. | 149 |
| Expected @param tag for 'options'. | 150 |
| Line has trailing spaces. | 151 |
| First sentence should end with a period. | 152 |
| Line has trailing spaces. | 154 |
| Expected an @return tag. | 157 |
| First sentence should end with a period. | 159 |
| Line has trailing spaces. | 161 |
| Expected an @return tag. | 164 |
org/apache/helix/HelixDefinedState.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 23 |
| Line is longer than 80 characters. | 27 |
| Line is longer than 80 characters. | 28 |
| Line is longer than 80 characters. | 29 |
| Line is longer than 80 characters. | 30 |
| Line is longer than 80 characters. | 34 |
| Line is longer than 80 characters. | 36 |
| Missing a Javadoc comment. | 41 |
| Missing a Javadoc comment. | 42 |
org/apache/helix/HelixException.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 23 |
| '{' should be on the previous line. | 24 |
| Missing a Javadoc comment. | 26 |
| Parameter message should be final. | 26 |
| '{' should be on the previous line. | 27 |
| Missing a Javadoc comment. | 31 |
| Parameter cause should be final. | 31 |
| '{' should be on the previous line. | 32 |
org/apache/helix/HelixManager.java
| Violation | Message | Line |
|---|---|---|
| Unused import - java.util.List. | 22 |
| Unused import - org.apache.helix.controller.GenericHelixController. | 24 |
| Unused import - org.apache.helix.participant.HelixStateMachineEngine. | 27 |
| Unused import - org.apache.helix.spectator.RoutingTableProvider. | 29 |
| Line has trailing spaces. | 37 |
| Line is longer than 80 characters. | 39 |
| Line is longer than 80 characters. | 43 |
| Line is longer than 80 characters. | 44 |
| Line has trailing spaces. | 50 |
| Line has trailing spaces. | 52 |
| '{' should be on the previous line. | 58 |
| Line is longer than 80 characters. | 60 |
| Missing a Javadoc comment. | 60 |
| Redundant 'public' modifier. | 60 |
| Line has trailing spaces. | 66 |
| Expected @throws tag for 'Exception'. | 69 |
| Line has trailing spaces. | 76 |
| Expected an @return tag. | 79 |
| Expected @param tag for 'listener'. | 93 |
| Expected @throws tag for 'Exception'. | 94 |
| Expected @param tag for 'listener'. | 101 |
| Expected @throws tag for 'Exception'. | 102 |
| Line has trailing spaces. | 107 |
| Expected @param tag for 'listener'. | 110 |
| Expected @throws tag for 'Exception'. | 110 |
| Line is longer than 80 characters. | 113 |
| Line has trailing spaces. | 115 |
| Line is longer than 80 characters. | 117 |
| Expected @param tag for 'listener'. | 117 |
| Expected @throws tag for 'Exception'. | 117 |
| Line is longer than 80 characters. | 124 |
| Expected @param tag for 'listener'. | 124 |
| Expected @param tag for 'scope'. | 124 |
| Expected @throws tag for 'Exception'. | 124 |
| Line has trailing spaces. | 125 |
| Expected @param tag for 'listener'. | 131 |
| Expected @param tag for 'instanceName'. | 131 |
| Expected @throws tag for 'Exception'. | 132 |
| Expected @param tag for 'listener'. | 141 |
| Expected @param tag for 'instanceName'. | 142 |
| Expected @param tag for 'sessionId'. | 142 |
| Expected @throws tag for 'Exception'. | 142 |
| Expected @param tag for 'listener'. | 150 |
| Expected @param tag for 'instanceName'. | 151 |
| Expected @throws tag for 'Exception'. | 151 |
| Expected @param tag for 'listener'. | 158 |
| Expected @throws tag for 'Exception'. | 159 |
| First sentence should end with a period. | 161 |
| Line has trailing spaces. | 163 |
| Expected @param tag for 'listener'. | 166 |
| Line is longer than 80 characters. | 172 |
| Line has trailing spaces. | 178 |
| Expected an @return tag. | 182 |
| Expected @param tag for 'key'. | 182 |
| Expected @param tag for 'listener'. | 182 |
| First sentence should end with a period. | 183 |
| Line has trailing spaces. | 186 |
| First sentence should end with a period. | 191 |
| Line has trailing spaces. | 193 |
| Expected an @return tag. | 196 |
| First sentence should end with a period. | 198 |
| Line has trailing spaces. | 200 |
| Expected an @return tag. | 203 |
| First sentence should end with a period. | 205 |
| Line has trailing spaces. | 207 |
| Expected an @return tag. | 211 |
| Expected an @return tag. | 216 |
| Expected an @return tag. | 224 |
| Line has trailing spaces. | 228 |
| Expected an @return tag. | 231 |
| First sentence should end with a period. | 233 |
| Line has trailing spaces. | 235 |
| Expected an @return tag. | 238 |
| Line has trailing spaces. | 242 |
| Expected an @return tag. | 244 |
| Line has trailing spaces. | 249 |
| Expected an @return tag. | 251 |
| First sentence should end with a period. | 253 |
| Line has trailing spaces. | 255 |
| Expected an @return tag. | 258 |
| First sentence should end with a period. | 260 |
| Line has trailing spaces. | 262 |
| First sentence should end with a period. | 267 |
| Line has trailing spaces. | 268 |
| Line has trailing spaces. | 269 |
| Line has trailing spaces. | 270 |
| Expected an @return tag. | 273 |
| Line has trailing spaces. | 274 |
| Line has trailing spaces. | 276 |
| First sentence should end with a period. | 281 |
| Line has trailing spaces. | 283 |
| First sentence should end with a period. | 288 |
| Line has trailing spaces. | 290 |
| First sentence should end with a period. | 294 |
| Line has trailing spaces. | 296 |
| Line has trailing spaces. | 299 |
| Extra HTML tag found: </br> | 301 |
| Line is longer than 80 characters. | 302 |
| Extra HTML tag found: </br> | 302 |
| Line is longer than 80 characters. | 303 |
| Expected @param tag for 'callback'. | 308 |
| Line has trailing spaces. | 309 |
| Line is longer than 80 characters. | 311 |
| Extra HTML tag found: </br> | 311 |
| Line is longer than 80 characters. | 312 |
| Extra HTML tag found: </br> | 312 |
| Line has trailing spaces. | 313 |
| Line is longer than 80 characters. | 317 |
| Expected @param tag for 'liveInstanceInfoProvider'. | 317 |
org/apache/helix/HelixManagerFactory.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 25 |
| Missing a Javadoc comment. | 32 |
| Utility classes should not have a public or default constructor. | 32 |
| '{' should be on the previous line. | 33 |
| Line is longer than 80 characters. | 34 |
| Missing a Javadoc comment. | 34 |
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 34 |
| First sentence should end with a period. | 36 |
| Line is longer than 80 characters. | 37 |
| Line has trailing spaces. | 39 |
| Expected an @return tag. | 46 |
| Parameter clusterName should be final. | 46 |
| Expected @param tag for 'clusterName'. | 46 |
| Parameter instanceName should be final. | 47 |
| Expected @param tag for 'instanceName'. | 47 |
| Parameter type should be final. | 48 |
| Expected @param tag for 'type'. | 48 |
| Parameter zkAddr should be final. | 49 |
| Expected @param tag for 'zkAddr'. | 49 |
| '{' should be on the previous line. | 50 |
org/apache/helix/HelixManagerProperties.java
| Violation | Message | Line |
|---|---|---|
| Unused import - java.util.Arrays. | 23 |
| First sentence should end with a period. | 28 |
| Line has trailing spaces. | 29 |
| Line has trailing spaces. | 30 |
| '{' should be on the previous line. | 34 |
| Missing a Javadoc comment. | 35 |
| Line has trailing spaces. | 37 |
| Missing a Javadoc comment. | 38 |
| Name '_properties' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
| Missing a Javadoc comment. | 40 |
| Parameter propertyFileName should be final. | 40 |
| '{' should be on the previous line. | 41 |
| '{' should be on the previous line. | 43 |
| Line has trailing spaces. | 47 |
| '}' should be on the same line. | 48 |
| '{' should be on the previous line. | 50 |
| Line has trailing spaces. | 54 |
| Missing a Javadoc comment. | 59 |
| Line has trailing spaces. | 62 |
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Missing a Javadoc comment. | 63 |
| Line has trailing spaces. | 66 |
| First sentence should end with a period. | 67 |
| Expected an @return tag. | 71 |
| Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Line has trailing spaces. | 74 |
| First sentence should end with a period. | 75 |
| Line has trailing spaces. | 77 |
| Expected an @return tag. | 81 |
| Method 'getProperty' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Parameter key should be final. | 81 |
| Expected @param tag for 'key'. | 81 |
| '{' should be on the previous line. | 82 |
| Line has trailing spaces. | 90 |
| Line is longer than 80 characters. | 92 |
| Line is longer than 80 characters. | 93 |
| Line has trailing spaces. | 95 |
| Expected an @return tag. | 100 |
| Parameter version1 should be final. | 100 |
| Expected @param tag for 'version1'. | 100 |
| Parameter version2 should be final. | 100 |
| Expected @param tag for 'version2'. | 100 |
| Line is longer than 80 characters. | 102 |
| Line has trailing spaces. | 105 |
| Line has trailing spaces. | 108 |
| Line has trailing spaces. | 109 |
| Line is longer than 80 characters. | 111 |
| Line has trailing spaces. | 113 |
| Line is longer than 80 characters. | 114 |
| Line has trailing spaces. | 118 |
| Line has trailing spaces. | 127 |
| Line has trailing spaces. | 130 |
| First sentence should end with a period. | 131 |
| Line is longer than 80 characters. | 132 |
| Line has trailing spaces. | 134 |
| Expected an @return tag. | 138 |
| Method 'isParticipantCompatible' is not designed for extension - needs to be abstract, final or empty. | 138 |
| Parameter participantVersion should be final. | 138 |
| Expected @param tag for 'participantVersion'. | 138 |
| Line has trailing spaces. | 141 |
| First sentence should end with a period. | 142 |
| Line is longer than 80 characters. | 143 |
| Line has trailing spaces. | 145 |
| Expected an @return tag. | 150 |
| Line is longer than 80 characters. | 150 |
| Method 'isFeatureSupported' is not designed for extension - needs to be abstract, final or empty. | 150 |
| Parameter featureName should be final. | 150 |
| Expected @param tag for 'featureName'. | 150 |
| Parameter participantVersion should be final. | 150 |
| Expected @param tag for 'participantVersion'. | 150 |
| Line is longer than 80 characters. | 151 |
| Line has trailing spaces. | 152 |
| Line has trailing spaces. | 155 |
org/apache/helix/HelixProperty.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 31 |
| '{' should be on the previous line. | 34 |
| Missing a Javadoc comment. | 35 |
| '{' should be on the previous line. | 36 |
| Missing a Javadoc comment. | 37 |
| Missing a Javadoc comment. | 38 |
| Missing a Javadoc comment. | 41 |
| Name '_record' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 41 |
| Variable '_record' must be private and have accessor methods. | 41 |
| Missing a Javadoc comment. | 43 |
| Parameter id should be final. | 43 |
| '{' should be on the previous line. | 44 |
| Missing a Javadoc comment. | 48 |
| Parameter record should be final. | 48 |
| '{' should be on the previous line. | 49 |
| Missing a Javadoc comment. | 53 |
| '{' should be on the previous line. | 54 |
| Missing a Javadoc comment. | 58 |
| '{' should be on the previous line. | 59 |
| Missing a Javadoc comment. | 63 |
| Parameter deltaList should be final. | 63 |
| '{' should be on the previous line. | 64 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 68 |
| '{' should be on the previous line. | 70 |
| Method 'getBucketSize' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Missing a Javadoc comment. | 74 |
| '{' should be on the previous line. | 75 |
| '{' should be on the previous line. | 80 |
| '{' should be on the previous line. | 82 |
| '}' should be on the same line. | 84 |
| '{' should be on the previous line. | 86 |
| Must have at least one statement. | 86 |
| Method 'setBucketSize' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Missing a Javadoc comment. | 93 |
| Parameter bucketSize should be final. | 93 |
| '{' should be on the previous line. | 94 |
| 'if' construct must use '{}'s. | 95 |
| Line is longer than 80 characters. | 98 |
| First sentence should end with a period. | 101 |
| Line is longer than 80 characters. | 102 |
| Line has trailing spaces. | 103 |
| Expected an @return tag. | 108 |
| Line is longer than 80 characters. | 108 |
| Expected @param tag for '<T>'. | 108 |
| Parameter clazz should be final. | 108 |
| Expected @param tag for 'clazz'. | 108 |
| Line is longer than 80 characters. | 109 |
| Parameter record should be final. | 109 |
| Expected @param tag for 'record'. | 109 |
| '{' should be on the previous line. | 112 |
| '{' should be on the previous line. | 117 |
| Line is longer than 80 characters. | 118 |
| '{' is followed by whitespace. | 118 |
| '}' should be on the same line. | 120 |
| '{' should be on the previous line. | 122 |
| Line is longer than 80 characters. | 130 |
| Missing a Javadoc comment. | 130 |
| Parameter clazz should be final. | 130 |
| Line is longer than 80 characters. | 131 |
| Parameter records should be final. | 131 |
| '{' should be on the previous line. | 134 |
| '{' should be on the previous line. | 140 |
| '{' should be on the previous line. | 143 |
| Line is longer than 80 characters. | 150 |
| Missing a Javadoc comment. | 150 |
| Parameter records should be final. | 150 |
| '{' should be on the previous line. | 153 |
| '{' should be on the previous line. | 159 |
| Line is longer than 80 characters. | 165 |
| Missing a Javadoc comment. | 165 |
| Parameter typedInstances should be final. | 165 |
| '{' should be on the previous line. | 168 |
| '{' should be on the previous line. | 174 |
| Method 'setBatchMessageMode' is not designed for extension - needs to be abstract, final or empty. | 181 |
| Missing a Javadoc comment. | 181 |
| Parameter enable should be final. | 181 |
| '{' should be on the previous line. | 182 |
| Line is longer than 80 characters. | 183 |
| Method 'getBatchMessageMode' is not designed for extension - needs to be abstract, final or empty. | 187 |
| Missing a Javadoc comment. | 187 |
| '{' should be on the previous line. | 188 |
| Line is longer than 80 characters. | 190 |
| '{' should be on the previous line. | 192 |
| '{' should be on the previous line. | 197 |
| '}' should be on the same line. | 199 |
| '{' should be on the previous line. | 201 |
| Line has trailing spaces. | 205 |
| Method 'isValid' is not designed for extension - needs to be abstract, final or empty. | 206 |
| Missing a Javadoc comment. | 206 |
| '{' should be on the previous line. | 207 |
| Definition of 'equals()' without corresponding definition of 'hashCode()'. | 211 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 211 |
| Parameter obj should be final. | 212 |
| '{' should be on the previous line. | 213 |
| '{' should be on the previous line. | 215 |
| '{' should be on the previous line. | 219 |
| '{' should be on the previous line. | 222 |
org/apache/helix/HelixTimerTask.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 24 |
| '{' should be on the previous line. | 25 |
| First sentence should end with a period. | 26 |
| Line has trailing spaces. | 28 |
| Line has trailing spaces. | 31 |
| First sentence should end with a period. | 32 |
| Line has trailing spaces. | 34 |
org/apache/helix/IdealStateChangeListener.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 27 |
| '{' should be on the previous line. | 28 |
| First sentence should end with a period. | 30 |
| Line has trailing spaces. | 32 |
| Line is longer than 80 characters. | 36 |
| Expected @param tag for 'idealState'. | 36 |
| Expected @param tag for 'changeContext'. | 36 |
org/apache/helix/InstanceConfigChangeListener.java
| Violation | Message | Line |
|---|---|---|
| File does not end with a newline. | 0 |
| Line has trailing spaces. | 26 |
| Missing a Javadoc comment. | 26 |
| '{' should be on the previous line. | 27 |
| First sentence should end with a period. | 28 |
| Line has trailing spaces. | 30 |
| Line is longer than 80 characters. | 34 |
| Redundant 'public' modifier. | 34 |
| Expected @param tag for 'instanceConfigs'. | 34 |
| Expected @param tag for 'context'. | 34 |
org/apache/helix/InstanceType.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 22 |
| '{' should be on the previous line. | 32 |
| Missing a Javadoc comment. | 33 |
| Missing a Javadoc comment. | 34 |
| Missing a Javadoc comment. | 35 |
| Missing a Javadoc comment. | 36 |
| Missing a Javadoc comment. | 37 |
org/apache/helix/LiveInstanceChangeListener.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 27 |
| '{' should be on the previous line. | 28 |
| First sentence should end with a period. | 30 |
| Line has trailing spaces. | 32 |
| Redundant 'public' modifier. | 36 |
| Expected @param tag for 'liveInstances'. | 36 |
| Expected @param tag for 'changeContext'. | 37 |
org/apache/helix/LiveInstanceInfoProvider.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 21 |
| '{' should be on the previous line. | 22 |
| Line has trailing spaces. | 24 |
| Line is longer than 80 characters. | 24 |
| Line has trailing spaces. | 25 |
| Line has trailing spaces. | 26 |
| Expected an @return tag. | 30 |
org/apache/helix/MessageListener.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 27 |
| '{' should be on the previous line. | 28 |
| First sentence should end with a period. | 30 |
| Line has trailing spaces. | 32 |
| Redundant 'public' modifier. | 37 |
| Expected @param tag for 'instanceName'. | 37 |
| Expected @param tag for 'messages'. | 37 |
| Expected @param tag for 'changeContext'. | 38 |
org/apache/helix/MockEspressoService.java
| Violation | Message | Line |
|---|---|---|
| Unused import - java.net.InetAddress. | 20 |
| Unused import - org.apache.helix.tools.ClusterSetup. | 30 |
| Missing a Javadoc comment. | 45 |
| '{' should be on the previous line. | 46 |
| Line is longer than 80 characters. | 47 |
| Missing a Javadoc comment. | 47 |
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 47 |
| Line has trailing spaces. | 48 |
| Line contains a tab character. | 48 |
| Missing a Javadoc comment. | 49 |
| Missing a Javadoc comment. | 50 |
| Missing a Javadoc comment. | 51 |
| Missing a Javadoc comment. | 52 |
| Missing a Javadoc comment. | 53 |
| Missing a Javadoc comment. | 54 |
| Missing a Javadoc comment. | 55 |
| Line has trailing spaces. | 57 |
| Missing a Javadoc comment. | 58 |
| Missing a Javadoc comment. | 59 |
| Missing a Javadoc comment. | 60 |
| Missing a Javadoc comment. | 61 |
| Missing a Javadoc comment. | 62 |
| Line has trailing spaces. | 63 |
| Missing a Javadoc comment. | 64 |
| Missing a Javadoc comment. | 65 |
| Line has trailing spaces. | 66 |
| Missing a Javadoc comment. | 67 |
| Name '_applicationContext' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 67 |
| Variable '_applicationContext' must be private and have accessor methods. | 67 |
| Missing a Javadoc comment. | 68 |
| Name '_serverPort' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 68 |
| Variable '_serverPort' must be private and have accessor methods. | 68 |
| Missing a Javadoc comment. | 69 |
| Name '_zkAddr' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 69 |
| Variable '_zkAddr' must be private and have accessor methods. | 69 |
| Missing a Javadoc comment. | 70 |
| Name '_instanceName' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 70 |
| Variable '_instanceName' must be private and have accessor methods. | 70 |
| Missing a Javadoc comment. | 71 |
| Name '_clusterName' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 71 |
| Variable '_clusterName' must be private and have accessor methods. | 71 |
| Missing a Javadoc comment. | 72 |
| Name '_connector' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 72 |
| Variable '_connector' must be private and have accessor methods. | 72 |
| Missing a Javadoc comment. | 73 |
| Name '_mockNode' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 73 |
| Variable '_mockNode' must be private and have accessor methods. | 73 |
| Missing a Javadoc comment. | 74 |
| Name '_context' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 74 |
| Variable '_context' must be private and have accessor methods. | 74 |
| Missing a Javadoc comment. | 75 |
| Name '_component' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 75 |
| Variable '_component' must be private and have accessor methods. | 75 |
| Missing a Javadoc comment. | 77 |
| Parameter context should be final. | 77 |
| '{' should be on the previous line. | 78 |
| Line contains a tab character. | 79 |
| Line contains a tab character. | 80 |
| Line contains a tab character. | 83 |
| Line is longer than 80 characters. | 84 |
| Line contains a tab character. | 84 |
| Line contains a tab character. | 85 |
| '}' should be on the same line. | 85 |
| Line contains a tab character. | 86 |
| Line contains a tab character. | 87 |
| '+' is not preceded with whitespace. | 87 |
| '+' is not followed by whitespace. | 87 |
| Line contains a tab character. | 88 |
| Line contains a tab character. | 89 |
| Line contains a tab character. | 90 |
| Line is longer than 80 characters. | 91 |
| Line contains a tab character. | 91 |
| 'cast' is not followed by whitespace. | 91 |
| Line is longer than 80 characters. | 92 |
| Line contains a tab character. | 92 |
| 'cast' is not followed by whitespace. | 92 |
| Line has trailing spaces. | 94 |
| Method 'createRoot' is not designed for extension - needs to be abstract, final or empty. | 95 |
| '{' should be on the previous line. | 97 |
| Line contains a tab character. | 98 |
| Parameter request should be final. | 103 |
| Parameter response should be final. | 103 |
| '{' should be on the previous line. | 104 |
| Line is longer than 80 characters. | 108 |
| Line has trailing spaces. | 123 |
| Line contains a tab character. | 125 |
| Line has trailing spaces. | 128 |
| Line is longer than 80 characters. | 130 |
| '+' is not preceded with whitespace. | 130 |
| '+' is not followed by whitespace. | 130 |
| '+' is not preceded with whitespace. | 130 |
| '+' is not followed by whitespace. | 130 |
| '+' is not preceded with whitespace. | 130 |
| '+' is not followed by whitespace. | 130 |
| '+' is not preceded with whitespace. | 130 |
| '+' is not followed by whitespace. | 130 |
| '+' is not preceded with whitespace. | 130 |
| '+' is not followed by whitespace. | 130 |
| '+' is not preceded with whitespace. | 130 |
| '+' is not followed by whitespace. | 130 |
| Line is longer than 80 characters. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| '+' is not preceded with whitespace. | 131 |
| '+' is not followed by whitespace. | 131 |
| Line has trailing spaces. | 132 |
| '+' is not preceded with whitespace. | 134 |
| '+' is not followed by whitespace. | 134 |
| '+' is not preceded with whitespace. | 134 |
| '+' is not followed by whitespace. | 134 |
| Line has trailing spaces. | 135 |
| Line has trailing spaces. | 138 |
| Missing a Javadoc comment. | 139 |
| Parameter cliOptions should be final. | 139 |
| '{' should be on the previous line. | 140 |
| Line is longer than 80 characters. | 142 |
| Missing a Javadoc comment. | 145 |
| '{' should be on the previous line. | 147 |
| Line has trailing spaces. | 153 |
| Line has trailing spaces. | 159 |
| Line contains a tab character. | 161 |
| Line contains a tab character. | 167 |
| '+' is not preceded with whitespace. | 176 |
| Line has trailing spaces. | 177 |
| Line has trailing spaces. | 184 |
| Line has trailing spaces. | 187 |
| Missing a Javadoc comment. | 188 |
| Parameter cliArgs should be final. | 188 |
| '{' should be on the previous line. | 189 |
| '{' should be on the previous line. | 195 |
| Line has trailing spaces. | 197 |
| '}' should be on the same line. | 197 |
| '{' should be on the previous line. | 199 |
| Line is longer than 80 characters. | 200 |
| 'if' is not followed by whitespace. | 206 |
| '{' should be on the previous line. | 207 |
| '}' should be on the same line. | 210 |
| 'if' is not followed by whitespace. | 211 |
| '{' should be on the previous line. | 212 |
| Line contains a tab character. | 216 |
| Line contains a tab character. | 219 |
| Line contains a tab character. | 220 |
| '+' is not preceded with whitespace. | 220 |
| '+' is not followed by whitespace. | 220 |
| Line contains a tab character. | 223 |
| Line contains a tab character. | 224 |
| Line contains a tab character. | 225 |
| '+' is not preceded with whitespace. | 225 |
| '+' is not followed by whitespace. | 225 |
| Line has trailing spaces. | 228 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 229 |
| Missing a Javadoc comment. | 229 |
| Line has trailing spaces. | 230 |
| Line contains a tab character. | 230 |
| Line contains a tab character. | 231 |
| Line has trailing spaces. | 232 |
| Line contains a tab character. | 232 |
| Line has trailing spaces. | 233 |
| Line contains a tab character. | 233 |
| Line contains a tab character. | 234 |
| Line contains a tab character. | 235 |
| Line contains a tab character. | 236 |
| '}' should be on the same line. | 236 |
| Line contains a tab character. | 237 |
| Line contains a tab character. | 238 |
| Line contains a tab character. | 239 |
| Line contains a tab character. | 240 |
| Line contains a tab character. | 241 |
| Line contains a tab character. | 242 |
| Line contains a tab character. | 243 |
| Line contains a tab character. | 244 |
| Line contains a tab character. | 245 |
| Line is longer than 80 characters. | 246 |
| Line contains a tab character. | 246 |
| 'cast' is not followed by whitespace. | 246 |
| Line has trailing spaces. | 247 |
| Line is longer than 80 characters. | 247 |
| Line contains a tab character. | 247 |
| Line contains a tab character. | 248 |
| Line contains a tab character. | 249 |
| Line contains a tab character. | 250 |
| Line contains a tab character. | 251 |
| '}' should be on the same line. | 251 |
| Line contains a tab character. | 252 |
| Line contains a tab character. | 253 |
| '+' is not preceded with whitespace. | 253 |
| '+' is not followed by whitespace. | 253 |
| Line contains a tab character. | 254 |
| Line contains a tab character. | 255 |
| Line contains a tab character. | 256 |
| Line has trailing spaces. | 258 |
| Parameter args should be final. | 263 |
| Expected @param tag for 'args'. | 263 |
| Expected @throws tag for 'Exception'. | 263 |
| '{' should be on the previous line. | 264 |
| Line contains a tab character. | 265 |
| Line contains a tab character. | 266 |
| Line contains a tab character. | 267 |
| Line contains a tab character. | 268 |
| Line has trailing spaces. | 269 |
| Line contains a tab character. | 269 |
org/apache/helix/MockNode.java
| Violation | Message | Line |
|---|---|---|
| Unused import - org.apache.log4j.Logger. | 20 |
| Missing a Javadoc comment. | 22 |
| Line contains a tab character. | 23 |
| Missing a Javadoc comment. | 23 |
| Name '_cmConnector' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 23 |
| Variable '_cmConnector' must be private and have accessor methods. | 23 |
| Line has trailing spaces. | 24 |
| Line contains a tab character. | 24 |
| Line contains a tab character. | 25 |
| Missing a Javadoc comment. | 25 |
| Parameter cm should be final. | 25 |
| Line contains a tab character. | 26 |
| Line contains a tab character. | 27 |
| Line contains a tab character. | 29 |
| Missing a Javadoc comment. | 29 |
| Line has trailing spaces. | 30 |
| Line contains a tab character. | 30 |
| Line contains a tab character. | 31 |
| Method 'disconnect' is not designed for extension - needs to be abstract, final or empty. | 31 |
| Missing a Javadoc comment. | 31 |
| Line contains a tab character. | 32 |
| Line contains a tab character. | 33 |
org/apache/helix/MockNodeFactory.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| Utility classes should not have a public or default constructor. | 22 |
| Line has trailing spaces. | 23 |
| Line contains a tab character. | 23 |
| Line is longer than 80 characters. | 24 |
| Line contains a tab character. | 24 |
| Missing a Javadoc comment. | 24 |
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 24 |
| Line has trailing spaces. | 25 |
| Line contains a tab character. | 25 |
| Line contains a tab character. | 26 |
| Missing a Javadoc comment. | 26 |
| Line contains a tab character. | 27 |
| '{' should be on the previous line. | 27 |
| Line contains a tab character. | 28 |
| Line has trailing spaces. | 29 |
| Line contains a tab character. | 29 |
| Line contains a tab character. | 30 |
| Missing a Javadoc comment. | 30 |
| Parameter type should be final. | 30 |
| Parameter cm should be final. | 30 |
| Line contains a tab character. | 31 |
| Line contains a tab character. | 32 |
| Line contains a tab character. | 33 |
| '}' should be on the same line. | 33 |
| Line contains a tab character. | 34 |
| Line contains a tab character. | 35 |
| '+' is not preceded with whitespace. | 35 |
| '+' is not followed by whitespace. | 35 |
| Line contains a tab character. | 36 |
| Line contains a tab character. | 37 |
| Line contains a tab character. | 38 |
org/apache/helix/MockRunner.java
| Violation | Message | Line |
|---|---|---|
| Unused import - org.apache.helix.manager.zk.ZNRecordSerializer. | 20 |
| Unused import - org.apache.helix.manager.zk.ZkClient. | 21 |
| Line has trailing spaces. | 29 |
| Utility classes should not have a public or default constructor. | 29 |
| '{' should be on the previous line. | 30 |
| Line has trailing spaces. | 31 |
| Line contains a tab character. | 31 |
| Line contains a tab character. | 32 |
| Missing a Javadoc comment. | 32 |
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 32 |
| Line has trailing spaces. | 33 |
| Line contains a tab character. | 33 |
| Line contains a tab character. | 34 |
| Missing a Javadoc comment. | 34 |
| Name 'nodeType' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 34 |
| Line contains a tab character. | 35 |
| Missing a Javadoc comment. | 35 |
| Line contains a tab character. | 36 |
| Missing a Javadoc comment. | 36 |
| Line contains a tab character. | 37 |
| Missing a Javadoc comment. | 37 |
| Line has trailing spaces. | 38 |
| Line contains a tab character. | 38 |
| Missing a Javadoc comment. | 39 |
| '(' is followed by whitespace. | 39 |
| Parameter args should be final. | 39 |
| ')' is preceded with whitespace. | 39 |
| '{' should be on the previous line. | 40 |
| Line is longer than 80 characters. | 41 |
| Line contains a tab character. | 41 |
| Line contains a tab character. | 42 |
| Line contains a tab character. | 43 |
| Line is longer than 80 characters. | 44 |
| Line contains a tab character. | 44 |
| Line contains a tab character. | 45 |
| '}' should be on the same line. | 45 |
| Line contains a tab character. | 46 |
| Line contains a tab character. | 47 |
| '+' is not preceded with whitespace. | 47 |
| '+' is not followed by whitespace. | 47 |
| Line contains a tab character. | 48 |
| Line contains a tab character. | 49 |
| Line contains a tab character. | 50 |
| Line contains a tab character. | 53 |
| '}' should be on the same line. | 54 |
| Line contains a tab character. | 56 |
| '+' is not preceded with whitespace. | 56 |
| '+' is not followed by whitespace. | 56 |
| Line contains a tab character. | 57 |
org/apache/helix/NotificationContext.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 25 |
| '{' should be on the previous line. | 26 |
| Line contains a tab character. | 27 |
| Missing a Javadoc comment. | 28 |
| Line contains a tab character. | 28 |
| Line contains a tab character. | 29 |
| Missing a Javadoc comment. | 29 |
| Line contains a tab character. | 30 |
| Missing a Javadoc comment. | 30 |
| Line contains a tab character. | 31 |
| Missing a Javadoc comment. | 31 |
| Line contains a tab character. | 32 |
| Line has trailing spaces. | 33 |
| Missing a Javadoc comment. | 34 |
| Name '_map' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 34 |
| Missing a Javadoc comment. | 36 |
| Name '_manager' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
| Missing a Javadoc comment. | 37 |
| Name '_type' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 37 |
| Missing a Javadoc comment. | 38 |
| Name '_pathChanged' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
| Missing a Javadoc comment. | 39 |
| Name '_eventName' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 39 |
| Method 'getEventName' is not designed for extension - needs to be abstract, final or empty. | 41 |
| Missing a Javadoc comment. | 41 |
| '{' should be on the previous line. | 42 |
| Method 'setEventName' is not designed for extension - needs to be abstract, final or empty. | 46 |
| Missing a Javadoc comment. | 46 |
| Parameter eventName should be final. | 46 |
| '{' should be on the previous line. | 47 |
| Missing a Javadoc comment. | 51 |
| Parameter manager should be final. | 51 |
| '{' should be on the previous line. | 52 |
| Method 'getManager' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Missing a Javadoc comment. | 57 |
| '{' should be on the previous line. | 58 |
| Method 'getMap' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Missing a Javadoc comment. | 62 |
| '{' should be on the previous line. | 63 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Missing a Javadoc comment. | 67 |
| '{' should be on the previous line. | 68 |
| Method 'setManager' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Missing a Javadoc comment. | 72 |
| Parameter manager should be final. | 72 |
| '{' should be on the previous line. | 73 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Missing a Javadoc comment. | 77 |
| Parameter key should be final. | 77 |
| Parameter value should be final. | 77 |
| '{' should be on the previous line. | 78 |
| Method 'setMap' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Missing a Javadoc comment. | 82 |
| Parameter map should be final. | 82 |
| '{' should be on the previous line. | 83 |
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Missing a Javadoc comment. | 87 |
| Parameter type should be final. | 87 |
| '{' should be on the previous line. | 88 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Missing a Javadoc comment. | 92 |
| Parameter key should be final. | 92 |
| '{' should be on the previous line. | 93 |
| Missing a Javadoc comment. | 97 |
| '{' should be on the previous line. | 98 |
| Missing a Javadoc comment. | 99 |
| Missing a Javadoc comment. | 99 |
| Missing a Javadoc comment. | 99 |
| Method 'getPathChanged' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Missing a Javadoc comment. | 102 |
| '{' should be on the previous line. | 103 |
| Method 'setPathChanged' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Missing a Javadoc comment. | 107 |
| Parameter pathChanged should be final. | 107 |
| '{' should be on the previous line. | 108 |
org/apache/helix/PreConnectCallback.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| '{' should be on the previous line. | 23 |
| Line is longer than 80 characters. | 25 |
| Line is longer than 80 characters. | 26 |
| Line has trailing spaces. | 27 |
| Redundant 'public' modifier. | 30 |
org/apache/helix/PropertyKey.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 67 |
| '{' should be on the previous line. | 68 |
| Missing a Javadoc comment. | 69 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 69 |
| Missing a Javadoc comment. | 70 |
| Name '_type' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 70 |
| Variable '_type' must be private and have accessor methods. | 70 |
| Missing a Javadoc comment. | 71 |
| Name '_params' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 71 |
| Missing a Javadoc comment. | 72 |
| Name '_typeClazz' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 72 |
| Variable '_typeClazz' must be private and have accessor methods. | 72 |
| Missing a Javadoc comment. | 75 |
| Name '_configScope' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 75 |
| Variable '_configScope' must be private and have accessor methods. | 75 |
| Line has trailing spaces. | 77 |
| Line is longer than 80 characters. | 77 |
| Missing a Javadoc comment. | 77 |
| Parameter type should be final. | 77 |
| Parameter typeClazz should be final. | 77 |
| Line contains a tab character. | 78 |
| Parameter params should be final. | 78 |
| '{' should be on the previous line. | 79 |
| Line has trailing spaces. | 82 |
| Missing a Javadoc comment. | 83 |
| Parameter type should be final. | 83 |
| Line contains a tab character. | 84 |
| Parameter configScope should be final. | 84 |
| Parameter typeClazz should be final. | 85 |
| Parameter params should be final. | 86 |
| '{' should be on the previous line. | 87 |
| Line is longer than 80 characters. | 89 |
| Line has trailing spaces. | 96 |
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 100 |
| '{' should be on the previous line. | 102 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Line contains a tab character. | 108 |
| Line has trailing spaces. | 110 |
| Method 'getPath' is not designed for extension - needs to be abstract, final or empty. | 111 |
| Missing a Javadoc comment. | 111 |
| '{' should be on the previous line. | 112 |
| '{' should be on the previous line. | 117 |
| Missing a Javadoc comment. | 124 |
| '{' should be on the previous line. | 125 |
| Missing a Javadoc comment. | 126 |
| Name '_clusterName' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 126 |
| Missing a Javadoc comment. | 128 |
| Parameter clusterName should be final. | 128 |
| '{' should be on the previous line. | 129 |
| Method 'idealStates' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Missing a Javadoc comment. | 133 |
| '{' should be on the previous line. | 134 |
| Method 'idealStates' is not designed for extension - needs to be abstract, final or empty. | 138 |
| Missing a Javadoc comment. | 138 |
| Parameter resourceName should be final. | 138 |
| '{' should be on the previous line. | 139 |
| Line is longer than 80 characters. | 140 |
| Method 'stateModelDefs' is not designed for extension - needs to be abstract, final or empty. | 143 |
| Missing a Javadoc comment. | 143 |
| '{' should be on the previous line. | 144 |
| Line is longer than 80 characters. | 145 |
| Method 'stateModelDef' is not designed for extension - needs to be abstract, final or empty. | 148 |
| Missing a Javadoc comment. | 148 |
| Parameter stateModelName should be final. | 148 |
| '{' should be on the previous line. | 149 |
| Method 'clusterConfigs' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Missing a Javadoc comment. | 156 |
| '{' should be on the previous line. | 157 |
| Line contains a tab character. | 159 |
| Line has trailing spaces. | 164 |
| Method 'clusterConfig' is not designed for extension - needs to be abstract, final or empty. | 165 |
| Missing a Javadoc comment. | 165 |
| '{' should be on the previous line. | 166 |
| Line contains a tab character. | 167 |
| Line contains a tab character. | 168 |
| Line has trailing spaces. | 172 |
| Line contains a tab character. | 172 |
| Method 'instanceConfigs' is not designed for extension - needs to be abstract, final or empty. | 175 |
| Missing a Javadoc comment. | 175 |
| '{' should be on the previous line. | 176 |
| Line contains a tab character. | 178 |
| Line has trailing spaces. | 181 |
| Method 'instanceConfig' is not designed for extension - needs to be abstract, final or empty. | 184 |
| Missing a Javadoc comment. | 184 |
| Parameter instanceName should be final. | 184 |
| '{' should be on the previous line. | 185 |
| Line contains a tab character. | 187 |
| Method 'resourceConfigs' is not designed for extension - needs to be abstract, final or empty. | 194 |
| Missing a Javadoc comment. | 194 |
| '{' should be on the previous line. | 195 |
| Line is longer than 80 characters. | 197 |
| Line contains a tab character. | 197 |
| Line contains a tab character. | 198 |
| Line has trailing spaces. | 202 |
| Method 'resourceConfig' is not designed for extension - needs to be abstract, final or empty. | 203 |
| Missing a Javadoc comment. | 203 |
| Parameter resourceName should be final. | 203 |
| '{' should be on the previous line. | 204 |
| Line contains a tab character. | 206 |
| Line contains a tab character. | 207 |
| Line is longer than 80 characters. | 213 |
| Method 'partitionConfig' is not designed for extension - needs to be abstract, final or empty. | 213 |
| Missing a Javadoc comment. | 213 |
| Parameter resourceName should be final. | 213 |
| Parameter partitionName should be final. | 213 |
| Line contains a tab character. | 216 |
| Line contains a tab character. | 217 |
| Method 'partitionConfig' is not designed for extension - needs to be abstract, final or empty. | 223 |
| Missing a Javadoc comment. | 223 |
| Parameter instanceName should be final. | 223 |
| Parameter resourceName should be final. | 224 |
| Parameter partitionName should be final. | 225 |
| '{' should be on the previous line. | 226 |
| Line contains a tab character. | 228 |
| Line contains a tab character. | 229 |
| Line contains a tab character. | 230 |
| Method 'constraints' is not designed for extension - needs to be abstract, final or empty. | 235 |
| Missing a Javadoc comment. | 235 |
| '{' should be on the previous line. | 236 |
| Method 'constraint' is not designed for extension - needs to be abstract, final or empty. | 243 |
| Missing a Javadoc comment. | 243 |
| Parameter constraintType should be final. | 243 |
| '{' should be on the previous line. | 244 |
| Method 'liveInstances' is not designed for extension - needs to be abstract, final or empty. | 252 |
| Missing a Javadoc comment. | 252 |
| '{' should be on the previous line. | 253 |
| Method 'liveInstance' is not designed for extension - needs to be abstract, final or empty. | 257 |
| Missing a Javadoc comment. | 257 |
| Parameter instanceName should be final. | 257 |
| '{' should be on the previous line. | 258 |
| Method 'instances' is not designed for extension - needs to be abstract, final or empty. | 265 |
| Missing a Javadoc comment. | 265 |
| '{' should be on the previous line. | 266 |
| Method 'messages' is not designed for extension - needs to be abstract, final or empty. | 270 |
| Missing a Javadoc comment. | 270 |
| Parameter instanceName should be final. | 270 |
| '{' should be on the previous line. | 271 |
| Line is longer than 80 characters. | 272 |
| Method 'message' is not designed for extension - needs to be abstract, final or empty. | 275 |
| Missing a Javadoc comment. | 275 |
| Parameter instanceName should be final. | 275 |
| Parameter messageId should be final. | 275 |
| '{' should be on the previous line. | 276 |
| Method 'sessions' is not designed for extension - needs to be abstract, final or empty. | 284 |
| Missing a Javadoc comment. | 284 |
| Parameter instanceName should be final. | 284 |
| '{' should be on the previous line. | 285 |
| Method 'currentStates' is not designed for extension - needs to be abstract, final or empty. | 292 |
| Missing a Javadoc comment. | 292 |
| Parameter instanceName should be final. | 292 |
| Parameter sessionId should be final. | 292 |
| '{' should be on the previous line. | 293 |
| Method 'currentState' is not designed for extension - needs to be abstract, final or empty. | 301 |
| Missing a Javadoc comment. | 301 |
| Parameter instanceName should be final. | 301 |
| Parameter sessionId should be final. | 302 |
| Parameter resourceName should be final. | 303 |
| '{' should be on the previous line. | 304 |
| Method 'currentState' is not designed for extension - needs to be abstract, final or empty. | 313 |
| Missing a Javadoc comment. | 313 |
| Parameter instanceName should be final. | 313 |
| Parameter sessionId should be final. | 314 |
| Parameter resourceName should be final. | 315 |
| Parameter bucketName should be final. | 316 |
| '{' should be on the previous line. | 317 |
| '{' should be on the previous line. | 319 |
| '}' should be on the same line. | 327 |
| '{' should be on the previous line. | 329 |
| Method 'stateTransitionStatus' is not designed for extension - needs to be abstract, final or empty. | 340 |
| Missing a Javadoc comment. | 340 |
| Parameter instanceName should be final. | 340 |
| Parameter sessionId should be final. | 341 |
| Parameter resourceName should be final. | 342 |
| Parameter partitionName should be final. | 343 |
| '{' should be on the previous line. | 344 |
| Method 'stateTransitionStatus' is not designed for extension - needs to be abstract, final or empty. | 354 |
| Missing a Javadoc comment. | 354 |
| Parameter instanceName should be final. | 354 |
| Parameter sessionId should be final. | 355 |
| Parameter resourceName should be final. | 356 |
| '{' should be on the previous line. | 357 |
| Line is longer than 80 characters. | 366 |
| Method 'stateTransitionStatus' is not designed for extension - needs to be abstract, final or empty. | 366 |
| Missing a Javadoc comment. | 366 |
| Parameter instanceName should be final. | 366 |
| Parameter sessionId should be final. | 366 |
| First sentence should end with a period. | 375 |
| Line has trailing spaces. | 377 |
| Expected an @return tag. | 384 |
| Method 'taskStatus' is not designed for extension - needs to be abstract, final or empty. | 384 |
| Parameter instanceName should be final. | 384 |
| Expected @param tag for 'instanceName'. | 384 |
| Parameter sessionId should be final. | 385 |
| Expected @param tag for 'sessionId'. | 385 |
| Parameter msgType should be final. | 386 |
| Expected @param tag for 'msgType'. | 386 |
| Parameter msgId should be final. | 387 |
| Expected @param tag for 'msgId'. | 387 |
| '{' should be on the previous line. | 388 |
| Method 'stateTransitionError' is not designed for extension - needs to be abstract, final or empty. | 398 |
| Missing a Javadoc comment. | 398 |
| Parameter instanceName should be final. | 398 |
| Parameter sessionId should be final. | 399 |
| Parameter resourceName should be final. | 400 |
| Parameter partitionName should be final. | 401 |
| '{' should be on the previous line. | 402 |
| Method 'stateTransitionErrors' is not designed for extension - needs to be abstract, final or empty. | 412 |
| Missing a Javadoc comment. | 412 |
| Parameter instanceName should be final. | 412 |
| Parameter sessionId should be final. | 413 |
| Parameter resourceName should be final. | 414 |
| '{' should be on the previous line. | 415 |
| First sentence should end with a period. | 424 |
| Line has trailing spaces. | 426 |
| Expected an @return tag. | 433 |
| Method 'taskError' is not designed for extension - needs to be abstract, final or empty. | 433 |
| Parameter instanceName should be final. | 433 |
| Expected @param tag for 'instanceName'. | 433 |
| Parameter sessionId should be final. | 434 |
| Expected @param tag for 'sessionId'. | 434 |
| Parameter msgType should be final. | 435 |
| Expected @param tag for 'msgType'. | 435 |
| Parameter msgId should be final. | 436 |
| Expected @param tag for 'msgId'. | 436 |
| '{' should be on the previous line. | 437 |
| Method 'externalViews' is not designed for extension - needs to be abstract, final or empty. | 447 |
| Missing a Javadoc comment. | 447 |
| '{' should be on the previous line. | 448 |
| Method 'externalView' is not designed for extension - needs to be abstract, final or empty. | 452 |
| Missing a Javadoc comment. | 452 |
| Parameter resourceName should be final. | 452 |
| '{' should be on the previous line. | 453 |
| Line is longer than 80 characters. | 454 |
| Method 'controller' is not designed for extension - needs to be abstract, final or empty. | 457 |
| Missing a Javadoc comment. | 457 |
| '{' should be on the previous line. | 458 |
| Method 'controllerTaskErrors' is not designed for extension - needs to be abstract, final or empty. | 462 |
| Missing a Javadoc comment. | 462 |
| '{' should be on the previous line. | 463 |
| Line is longer than 80 characters. | 464 |
| Method 'controllerTaskError' is not designed for extension - needs to be abstract, final or empty. | 467 |
| Missing a Javadoc comment. | 467 |
| Parameter errorId should be final. | 467 |
| '{' should be on the previous line. | 468 |
| Line is longer than 80 characters. | 469 |
| Method 'controllerTaskStatuses' is not designed for extension - needs to be abstract, final or empty. | 472 |
| Missing a Javadoc comment. | 472 |
| Parameter subPath should be final. | 472 |
| '{' should be on the previous line. | 473 |
| Method 'controllerTaskStatus' is not designed for extension - needs to be abstract, final or empty. | 480 |
| Missing a Javadoc comment. | 480 |
| Parameter subPath should be final. | 480 |
| Parameter recordName should be final. | 480 |
| '{' should be on the previous line. | 481 |
| Method 'controllerMessages' is not designed for extension - needs to be abstract, final or empty. | 489 |
| Missing a Javadoc comment. | 489 |
| '{' should be on the previous line. | 490 |
| Method 'controllerMessage' is not designed for extension - needs to be abstract, final or empty. | 494 |
| Missing a Javadoc comment. | 494 |
| Parameter msgId should be final. | 494 |
| '{' should be on the previous line. | 495 |
| Line is longer than 80 characters. | 496 |
| Method 'controllerLeaderHistory' is not designed for extension - needs to be abstract, final or empty. | 499 |
| Missing a Javadoc comment. | 499 |
| '{' should be on the previous line. | 500 |
| Method 'controllerLeader' is not designed for extension - needs to be abstract, final or empty. | 504 |
| Missing a Javadoc comment. | 504 |
| '{' should be on the previous line. | 505 |
| Method 'pause' is not designed for extension - needs to be abstract, final or empty. | 509 |
| Missing a Javadoc comment. | 509 |
| '{' should be on the previous line. | 510 |
| Method 'persistantStat' is not designed for extension - needs to be abstract, final or empty. | 514 |
| Missing a Javadoc comment. | 514 |
| '{' should be on the previous line. | 515 |
| Line is longer than 80 characters. | 516 |
| Method 'alerts' is not designed for extension - needs to be abstract, final or empty. | 519 |
| Missing a Javadoc comment. | 519 |
| '{' should be on the previous line. | 520 |
| Method 'alertStatus' is not designed for extension - needs to be abstract, final or empty. | 524 |
| Missing a Javadoc comment. | 524 |
| '{' should be on the previous line. | 525 |
| Method 'alertHistory' is not designed for extension - needs to be abstract, final or empty. | 529 |
| Missing a Javadoc comment. | 529 |
| '{' should be on the previous line. | 530 |
| Method 'healthReport' is not designed for extension - needs to be abstract, final or empty. | 534 |
| Missing a Javadoc comment. | 534 |
| Parameter instanceName should be final. | 534 |
| Parameter id should be final. | 534 |
| '{' should be on the previous line. | 535 |
| Method 'healthReports' is not designed for extension - needs to be abstract, final or empty. | 543 |
| Missing a Javadoc comment. | 543 |
| Parameter instanceName should be final. | 543 |
| '{' should be on the previous line. | 544 |
| Line is longer than 80 characters. | 545 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 550 |
| Missing a Javadoc comment. | 550 |
| '{' should be on the previous line. | 551 |
| Method 'getParams' is not designed for extension - needs to be abstract, final or empty. | 555 |
| Missing a Javadoc comment. | 555 |
| '{' should be on the previous line. | 556 |
| Method 'getTypeClass' is not designed for extension - needs to be abstract, final or empty. | 560 |
| Missing a Javadoc comment. | 560 |
| '{' should be on the previous line. | 561 |
| Method 'getConfigScope' is not designed for extension - needs to be abstract, final or empty. | 565 |
| Missing a Javadoc comment. | 565 |
| '{' should be on the previous line. | 566 |
| Line contains a tab character. | 567 |
| Line has trailing spaces. | 569 |
org/apache/helix/PropertyPathConfig.java
| Violation | Message | Line |
|---|---|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 58 |
| Utility classes should not have a public or default constructor. | 58 |
| '{' should be on the previous line. | 59 |
| Missing a Javadoc comment. | 60 |
| Line is longer than 80 characters. | 62 |
| Missing a Javadoc comment. | 62 |
| Name 'templateMap' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 62 |
| Line is longer than 80 characters. | 63 |
| Missing a Javadoc comment. | 63 |
| Name 'typeToClassMapping' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 63 |
| '=' is not preceded with whitespace. | 63 |
| '{' is not preceded with whitespace. | 64 |
| Line is longer than 80 characters. | 82 |
| '3' is a magic number. | 82 |
| Line is longer than 80 characters. | 85 |
| Line is longer than 80 characters. | 87 |
| Line is longer than 80 characters. | 89 |
| Line is longer than 80 characters. | 91 |
| Line is longer than 80 characters. | 93 |
| Line is longer than 80 characters. | 96 |
| Line is longer than 80 characters. | 99 |
| Line is longer than 80 characters. | 100 |
| '3' is a magic number. | 100 |
| Line is longer than 80 characters. | 101 |
| '3' is a magic number. | 102 |
| '4' is a magic number. | 104 |
| Line is longer than 80 characters. | 105 |
| '5' is a magic number. | 106 |
| Line is longer than 80 characters. | 107 |
| Line is longer than 80 characters. | 108 |
| '3' is a magic number. | 109 |
| '4' is a magic number. | 111 |
| Line is longer than 80 characters. | 112 |
| '5' is a magic number. | 113 |
| Line is longer than 80 characters. | 114 |
| Line is longer than 80 characters. | 115 |
| Line is longer than 80 characters. | 116 |
| '3' is a magic number. | 116 |
| '4' is a magic number. | 117 |
| '5' is a magic number. | 119 |
| Line is longer than 80 characters. | 120 |
| Line is longer than 80 characters. | 121 |
| '3' is a magic number. | 122 |
| Line is longer than 80 characters. | 125 |
| Line is longer than 80 characters. | 126 |
| Line is longer than 80 characters. | 127 |
| Line is longer than 80 characters. | 128 |
| Line is longer than 80 characters. | 129 |
| '3' is a magic number. | 132 |
| Line is longer than 80 characters. | 137 |
| Line is longer than 80 characters. | 139 |
| Line is longer than 80 characters. | 140 |
| Missing a Javadoc comment. | 144 |
| Variable 'pattern' must be private and have accessor methods. | 144 |
| Missing a Javadoc comment. | 146 |
| Parameter type should be final. | 146 |
| Parameter numKeys should be final. | 146 |
| Parameter template should be final. | 146 |
| '{' should be on the previous line. | 149 |
| Line is longer than 80 characters. | 152 |
| Line is longer than 80 characters. | 157 |
| Missing a Javadoc comment. | 157 |
| Parameter type should be final. | 157 |
| Parameter clusterName should be final. | 157 |
| Parameter keys should be final. | 157 |
| '{' should be on the previous line. | 160 |
| '{' should be on the previous line. | 165 |
| '{' should be on the previous line. | 170 |
| '{' should be on the previous line. | 178 |
| '{' should be on the previous line. | 183 |
| '{' should be on the previous line. | 187 |
| '{' should be on the previous line. | 190 |
| Line is longer than 80 characters. | 197 |
| Missing a Javadoc comment. | 202 |
| Parameter path should be final. | 202 |
| '{' should be on the previous line. | 203 |
| '{' should be on the previous line. | 207 |
| '3' is a magic number. | 209 |
| '{' should be on the previous line. | 210 |
| '3' is a magic number. | 211 |
org/apache/helix/PropertyType.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| '{' should be on the previous line. | 23 |
| Missing a Javadoc comment. | 24 |
| Missing a Javadoc comment. | 24 |
| Missing a Javadoc comment. | 24 |
| Missing a Javadoc comment. | 24 |
| Missing a Javadoc comment. | 27 |
| '{' should be on the previous line. | 28 |
| Missing a Javadoc comment. | 32 |
| Missing a Javadoc comment. | 33 |
| Missing a Javadoc comment. | 34 |
| Missing a Javadoc comment. | 35 |
| Missing a Javadoc comment. | 36 |
| Missing a Javadoc comment. | 37 |
| Missing a Javadoc comment. | 38 |
| Missing a Javadoc comment. | 39 |
| Missing a Javadoc comment. | 40 |
| Missing a Javadoc comment. | 43 |
| Missing a Javadoc comment. | 44 |
| Missing a Javadoc comment. | 45 |
| Missing a Javadoc comment. | 46 |
| Missing a Javadoc comment. | 47 |
| Missing a Javadoc comment. | 50 |
| Missing a Javadoc comment. | 51 |
| Missing a Javadoc comment. | 52 |
| Missing a Javadoc comment. | 53 |
| Missing a Javadoc comment. | 54 |
| Missing a Javadoc comment. | 55 |
| Missing a Javadoc comment. | 56 |
| Missing a Javadoc comment. | 57 |
| Missing a Javadoc comment. | 58 |
| Missing a Javadoc comment. | 59 |
| Missing a Javadoc comment. | 63 |
| Variable 'type' must be private and have accessor methods. | 63 |
| Line has trailing spaces. | 64 |
| Missing a Javadoc comment. | 65 |
| Variable 'isPersistent' must be private and have accessor methods. | 65 |
| Missing a Javadoc comment. | 67 |
| Variable 'mergeOnUpdate' must be private and have accessor methods. | 67 |
| Missing a Javadoc comment. | 69 |
| Variable 'updateOnlyOnExists' must be private and have accessor methods. | 69 |
| Missing a Javadoc comment. | 71 |
| Variable 'createOnlyIfAbsent' must be private and have accessor methods. | 71 |
| First sentence should end with a period. | 73 |
| Line is longer than 80 characters. | 74 |
| Variable 'isCached' must be private and have accessor methods. | 77 |
| Missing a Javadoc comment. | 79 |
| Variable 'usePropertyTransferServer' must be private and have accessor methods. | 79 |
| Missing a Javadoc comment. | 81 |
| Parameter type should be final. | 81 |
| 'type' hides a field. | 81 |
| Parameter isPersistent should be final. | 81 |
| 'isPersistent' hides a field. | 81 |
| Parameter mergeOnUpdate should be final. | 81 |
| 'mergeOnUpdate' hides a field. | 81 |
| '{' should be on the previous line. | 82 |
| Missing a Javadoc comment. | 86 |
| Parameter type should be final. | 86 |
| 'type' hides a field. | 86 |
| Parameter isPersistent should be final. | 87 |
| 'isPersistent' hides a field. | 87 |
| Parameter mergeOnUpdate should be final. | 88 |
| 'mergeOnUpdate' hides a field. | 88 |
| Parameter updateOnlyOnExists should be final. | 89 |
| 'updateOnlyOnExists' hides a field. | 89 |
| '{' should be on the previous line. | 90 |
| Missing a Javadoc comment. | 94 |
| Parameter type should be final. | 94 |
| 'type' hides a field. | 94 |
| Parameter isPersistent should be final. | 95 |
| 'isPersistent' hides a field. | 95 |
| Parameter mergeOnUpdate should be final. | 96 |
| 'mergeOnUpdate' hides a field. | 96 |
| Parameter updateOnlyOnExists should be final. | 97 |
| 'updateOnlyOnExists' hides a field. | 97 |
| Parameter createOnlyIfAbsent should be final. | 98 |
| 'createOnlyIfAbsent' hides a field. | 98 |
| '{' should be on the previous line. | 99 |
| Line is longer than 80 characters. | 100 |
| Missing a Javadoc comment. | 103 |
| Parameter type should be final. | 103 |
| 'type' hides a field. | 103 |
| Parameter isPersistent should be final. | 104 |
| 'isPersistent' hides a field. | 104 |
| Parameter mergeOnUpdate should be final. | 105 |
| 'mergeOnUpdate' hides a field. | 105 |
| Parameter updateOnlyOnExists should be final. | 106 |
| 'updateOnlyOnExists' hides a field. | 106 |
| Parameter createOnlyIfAbsent should be final. | 107 |
| 'createOnlyIfAbsent' hides a field. | 107 |
| Parameter isCached should be final. | 108 |
| 'isCached' hides a field. | 108 |
| '{' should be on the previous line. | 109 |
| Missing a Javadoc comment. | 119 |
| Parameter type should be final. | 119 |
| 'type' hides a field. | 119 |
| Parameter isPersistent should be final. | 120 |
| 'isPersistent' hides a field. | 120 |
| Parameter mergeOnUpdate should be final. | 121 |
| 'mergeOnUpdate' hides a field. | 121 |
| Parameter updateOnlyOnExists should be final. | 122 |
| 'updateOnlyOnExists' hides a field. | 122 |
| Parameter createOnlyIfAbsent should be final. | 123 |
| 'createOnlyIfAbsent' hides a field. | 123 |
| Parameter isCached should be final. | 124 |
| 'isCached' hides a field. | 124 |
| Parameter isAsyncWrite should be final. | 125 |
| '{' should be on the previous line. | 126 |
| Missing a Javadoc comment. | 136 |
| '{' should be on the previous line. | 137 |
| Missing a Javadoc comment. | 141 |
| Parameter createIfAbsent should be final. | 141 |
| '{' should be on the previous line. | 142 |
| Missing a Javadoc comment. | 146 |
| '{' should be on the previous line. | 147 |
| Missing a Javadoc comment. | 151 |
| Parameter type should be final. | 151 |
| 'type' hides a field. | 151 |
| '{' should be on the previous line. | 152 |
| Missing a Javadoc comment. | 156 |
| '{' should be on the previous line. | 157 |
| Missing a Javadoc comment. | 161 |
| Parameter isPersistent should be final. | 161 |
| 'isPersistent' hides a field. | 161 |
| '{' should be on the previous line. | 162 |
| Missing a Javadoc comment. | 166 |
| '{' should be on the previous line. | 167 |
| Missing a Javadoc comment. | 171 |
| Parameter mergeOnUpdate should be final. | 171 |
| 'mergeOnUpdate' hides a field. | 171 |
| '{' should be on the previous line. | 172 |
| Missing a Javadoc comment. | 176 |
| '{' should be on the previous line. | 177 |
| Missing a Javadoc comment. | 181 |
| Parameter updateOnlyOnExists should be final. | 181 |
| 'updateOnlyOnExists' hides a field. | 181 |
| '{' should be on the previous line. | 182 |
| Missing a Javadoc comment. | 186 |
| '{' should be on the previous line. | 187 |
| Missing a Javadoc comment. | 191 |
| '{' should be on the previous line. | 192 |
org/apache/helix/ScopedConfigChangeListener.java
| Violation | Message | Line |
|---|---|---|
| File does not end with a newline. | 0 |
| Line has trailing spaces. | 24 |
| Missing a Javadoc comment. | 24 |
| '{' should be on the previous line. | 25 |
| First sentence should end with a period. | 26 |
| Line is longer than 80 characters. | 27 |
| Line has trailing spaces. | 28 |
| Line is longer than 80 characters. | 32 |
| Redundant 'public' modifier. | 32 |
| Expected @param tag for 'configs'. | 32 |
| Expected @param tag for 'context'. | 32 |
org/apache/helix/StopServiceResource.java
| Violation | Message | Line |
|---|---|---|
| Unused import - java.io.IOException. | 20 |
| Unused import - java.io.Reader. | 21 |
| Unused import - java.nio.ByteBuffer. | 22 |
| Unused import - java.nio.CharBuffer. | 23 |
| Unused import - java.nio.channels.ReadableByteChannel. | 24 |
| Unused import - java.util.List. | 25 |
| Unused import - org.apache.helix.tools.ClusterSetup. | 27 |
| Unused import - org.codehaus.jackson.JsonGenerationException. | 29 |
| Unused import - org.codehaus.jackson.map.JsonMappingException. | 30 |
| Unused import - org.restlet.data.Method. | 34 |
| Unused import - org.restlet.data.Status. | 37 |
| Missing a Javadoc comment. | 45 |
| Line contains a tab character. | 48 |
| Missing a Javadoc comment. | 48 |
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 48 |
| Line contains a tab character. | 49 |
| Line contains a tab character. | 51 |
| Missing a Javadoc comment. | 51 |
| Name '_context' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 51 |
| Variable '_context' must be private and have accessor methods. | 51 |
| Line contains a tab character. | 53 |
| Missing a Javadoc comment. | 53 |
| Parameter context should be final. | 53 |
| Line contains a tab character. | 54 |
| Parameter request should be final. | 54 |
| Line has trailing spaces. | 55 |
| Line contains a tab character. | 55 |
| Parameter response should be final. | 55 |
| Line contains a tab character. | 56 |
| '{' should be on the previous line. | 56 |
| Line contains a tab character. | 57 |
| Line contains a tab character. | 58 |
| Line contains a tab character. | 59 |
| Line contains a tab character. | 60 |
| Line contains a tab character. | 61 |
| Line contains a tab character. | 63 |
| Method 'allowGet' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Missing a Javadoc comment. | 63 |
| Line contains a tab character. | 64 |
| '{' should be on the previous line. | 64 |
| Line contains a tab character. | 65 |
| Line contains a tab character. | 66 |
| Line contains a tab character. | 67 |
| Line contains a tab character. | 69 |
| Method 'allowPost' is not designed for extension - needs to be abstract, final or empty. | 69 |
| Missing a Javadoc comment. | 69 |
| Line contains a tab character. | 70 |
| '{' should be on the previous line. | 70 |
| Line contains a tab character. | 71 |
| Line contains a tab character. | 72 |
| Line contains a tab character. | 73 |
| Line contains a tab character. | 75 |
| Method 'allowPut' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Missing a Javadoc comment. | 75 |
| Line contains a tab character. | 76 |
| '{' should be on the previous line. | 76 |
| Line contains a tab character. | 77 |
| Line contains a tab character. | 78 |
| Line contains a tab character. | 79 |
| Line contains a tab character. | 81 |
| Method 'allowDelete' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Missing a Javadoc comment. | 81 |
| Line contains a tab character. | 82 |
| '{' should be on the previous line. | 82 |
| Line contains a tab character. | 83 |
| Line contains a tab character. | 84 |
| Missing a Javadoc comment. | 87 |
| Line contains a tab character. | 87 |
| Line contains a tab character. | 89 |
| Missing a Javadoc comment. | 89 |
| Name '_component' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 89 |
| Variable '_component' must be private and have accessor methods. | 89 |
| Line contains a tab character. | 90 |
| Missing a Javadoc comment. | 90 |
| Name '_mockNode' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 90 |
| Variable '_mockNode' must be private and have accessor methods. | 90 |
| Line has trailing spaces. | 91 |
| Line contains a tab character. | 91 |
| Line contains a tab character. | 92 |
| Missing a Javadoc comment. | 92 |
| Parameter c should be final. | 92 |
| Parameter m should be final. | 92 |
| Line contains a tab character. | 93 |
| Line contains a tab character. | 94 |
| Line contains a tab character. | 95 |
| Line has trailing spaces. | 96 |
| Line contains a tab character. | 96 |
| Line contains a tab character. | 97 |
| Line contains a tab character. | 98 |
| Line contains a tab character. | 99 |
| Line contains a tab character. | 100 |
| Line contains a tab character. | 101 |
| '1000' is a magic number. | 101 |
| Line contains a tab character. | 102 |
| Line contains a tab character. | 103 |
| Line contains a tab character. | 104 |
| Line contains a tab character. | 105 |
| Line contains a tab character. | 106 |
| '+' is not preceded with whitespace. | 106 |
| '+' is not followed by whitespace. | 106 |
| Line contains a tab character. | 107 |
| Line contains a tab character. | 108 |
| Line contains a tab character. | 109 |
| Line has trailing spaces. | 110 |
| Line contains a tab character. | 110 |
| Line contains a tab character. | 111 |
| Line has trailing spaces. | 112 |
| Line contains a tab character. | 112 |
| Line contains a tab character. | 113 |
| Line contains a tab character. | 114 |
| Method 'represent' is not designed for extension - needs to be abstract, final or empty. | 114 |
| Missing a Javadoc comment. | 114 |
| Parameter variant should be final. | 114 |
| Line contains a tab character. | 115 |
| '{' should be on the previous line. | 115 |
| Line contains a tab character. | 116 |
| Line contains a tab character. | 117 |
| Line contains a tab character. | 118 |
| Line contains a tab character. | 119 |
| '{' should be on the previous line. | 119 |
| Line contains a tab character. | 120 |
| Line is longer than 80 characters. | 121 |
| Line contains a tab character. | 121 |
| 'cast' is not followed by whitespace. | 121 |
| Line is longer than 80 characters. | 122 |
| Line contains a tab character. | 122 |
| 'cast' is not followed by whitespace. | 122 |
| Line is longer than 80 characters. | 123 |
| Line contains a tab character. | 123 |
| Line is longer than 80 characters. | 124 |
| Line contains a tab character. | 124 |
| Line contains a tab character. | 125 |
| Line contains a tab character. | 126 |
| '}' should be on the same line. | 126 |
| Line contains a tab character. | 128 |
| 'catch' is not followed by whitespace. | 128 |
| Line contains a tab character. | 129 |
| '{' should be on the previous line. | 129 |
| Line contains a tab character. | 130 |
| Line has trailing spaces. | 131 |
| Line is longer than 80 characters. | 131 |
| Line contains a tab character. | 131 |
| Line contains a tab character. | 132 |
| Line has trailing spaces. | 133 |
| Line contains a tab character. | 133 |
| Line contains a tab character. | 134 |
| Line contains a tab character. | 135 |
| Line is longer than 80 characters. | 137 |
| Line contains a tab character. | 137 |
| Missing a Javadoc comment. | 137 |
| Parameter entity should be final. | 137 |
| Unable to get class information for ResourceException. | 137 |
| Line contains a tab character. | 139 |
org/apache/helix/ZNRecord.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 35 |
| '{' should be on the previous line. | 41 |
| Missing a Javadoc comment. | 42 |
| Name '_logger' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 42 |
| Variable '_logger' must be private and have accessor methods. | 42 |
| Missing a Javadoc comment. | 43 |
| Missing a Javadoc comment. | 45 |
| Missing a Javadoc comment. | 48 |
| Missing a Javadoc comment. | 52 |
| Name '_deltaList' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 52 |
| Missing a Javadoc comment. | 54 |
| Missing a Javadoc comment. | 55 |
| Missing a Javadoc comment. | 56 |
| Missing a Javadoc comment. | 59 |
| Name '_version' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 59 |
| Missing a Javadoc comment. | 61 |
| Name '_creationTime' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 61 |
| Missing a Javadoc comment. | 63 |
| Name '_modifiedTime' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 63 |
| Missing a Javadoc comment. | 65 |
| Parameter id should be final. | 66 |
| 'id' hides a field. | 66 |
| '{' should be on the previous line. | 67 |
| Missing a Javadoc comment. | 74 |
| Parameter record should be final. | 74 |
| '{' should be on the previous line. | 75 |
| Missing a Javadoc comment. | 79 |
| Parameter record should be final. | 79 |
| Parameter id should be final. | 79 |
| 'id' hides a field. | 79 |
| '{' should be on the previous line. | 80 |
| Missing a Javadoc comment. | 90 |
| Parameter record should be final. | 90 |
| Parameter version should be final. | 90 |
| '{' should be on the previous line. | 91 |
| Method 'setDeltaList' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Missing a Javadoc comment. | 96 |
| Parameter deltaList should be final. | 97 |
| '{' should be on the previous line. | 98 |
| Method 'getDeltaList' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Missing a Javadoc comment. | 102 |
| '{' should be on the previous line. | 104 |
| Method 'getSimpleFields' is not designed for extension - needs to be abstract, final or empty. | 108 |
| Missing a Javadoc comment. | 108 |
| '{' should be on the previous line. | 110 |
| Method 'setSimpleFields' is not designed for extension - needs to be abstract, final or empty. | 114 |
| Missing a Javadoc comment. | 114 |
| Parameter simpleFields should be final. | 115 |
| 'simpleFields' hides a field. | 115 |
| '{' should be on the previous line. | 116 |
| Method 'getMapFields' is not designed for extension - needs to be abstract, final or empty. | 120 |
| Missing a Javadoc comment. | 120 |
| '{' should be on the previous line. | 122 |
| Method 'setMapFields' is not designed for extension - needs to be abstract, final or empty. | 126 |
| Missing a Javadoc comment. | 126 |
| Parameter mapFields should be final. | 127 |
| 'mapFields' hides a field. | 127 |
| '{' should be on the previous line. | 128 |
| Method 'getListFields' is not designed for extension - needs to be abstract, final or empty. | 132 |
| Missing a Javadoc comment. | 132 |
| '{' should be on the previous line. | 134 |
| Method 'setListFields' is not designed for extension - needs to be abstract, final or empty. | 138 |
| Missing a Javadoc comment. | 138 |
| Parameter listFields should be final. | 139 |
| 'listFields' hides a field. | 139 |
| '{' should be on the previous line. | 140 |
| Method 'setSimpleField' is not designed for extension - needs to be abstract, final or empty. | 144 |
| Missing a Javadoc comment. | 144 |
| Parameter k should be final. | 145 |
| Parameter v should be final. | 145 |
| '{' should be on the previous line. | 146 |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 150 |
| Missing a Javadoc comment. | 150 |
| '{' should be on the previous line. | 152 |
| Method 'setMapField' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Missing a Javadoc comment. | 156 |
| Parameter k should be final. | 156 |
| Parameter v should be final. | 156 |
| '{' should be on the previous line. | 157 |
| Method 'setListField' is not designed for extension - needs to be abstract, final or empty. | 161 |
| Missing a Javadoc comment. | 161 |
| Parameter k should be final. | 161 |
| Parameter v should be final. | 161 |
| '{' should be on the previous line. | 162 |
| Method 'getSimpleField' is not designed for extension - needs to be abstract, final or empty. | 166 |
| Missing a Javadoc comment. | 166 |
| Parameter k should be final. | 166 |
| '{' should be on the previous line. | 167 |
| Method 'getMapField' is not designed for extension - needs to be abstract, final or empty. | 171 |
| Missing a Javadoc comment. | 171 |
| Parameter k should be final. | 171 |
| '{' should be on the previous line. | 172 |
| Method 'getListField' is not designed for extension - needs to be abstract, final or empty. | 176 |
| Missing a Javadoc comment. | 176 |
| Parameter k should be final. | 176 |
| '{' should be on the previous line. | 177 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 181 |
| '{' should be on the previous line. | 183 |
| '{' should be on the previous line. | 187 |
| '{' should be on the previous line. | 191 |
| '{' should be on the previous line. | 195 |
| Method 'merge' is not designed for extension - needs to be abstract, final or empty. | 208 |
| Parameter record should be final. | 208 |
| Expected @param tag for 'record'. | 208 |
| '{' should be on the previous line. | 209 |
| '{' should be on the previous line. | 211 |
| '{' should be on the previous line. | 216 |
| '{' should be on the previous line. | 224 |
| '{' should be on the previous line. | 227 |
| '{' should be on the previous line. | 230 |
| '{' should be on the previous line. | 235 |
| '{' should be on the previous line. | 238 |
| '{' should be on the previous line. | 241 |
| Method 'merge' is not designed for extension - needs to be abstract, final or empty. | 247 |
| Missing a Javadoc comment. | 247 |
| Parameter delta should be final. | 247 |
| '{' should be on the previous line. | 248 |
| '{' should be on the previous line. | 250 |
| '{' should be on the previous line. | 253 |
| Method 'merge' is not designed for extension - needs to be abstract, final or empty. | 258 |
| Missing a Javadoc comment. | 258 |
| Parameter deltaList should be final. | 258 |
| '{' should be on the previous line. | 259 |
| '{' should be on the previous line. | 261 |
| Definition of 'equals()' without corresponding definition of 'hashCode()'. | 266 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 266 |
| Parameter obj should be final. | 267 |
| '{' should be on the previous line. | 268 |
| '{' should be on the previous line. | 270 |
| '{' should be on the previous line. | 275 |
| '{' should be on the previous line. | 279 |
| '{' should be on the previous line. | 283 |
| '{' should be on the previous line. | 287 |
| '{' should be on the previous line. | 291 |
| '{' should be on the previous line. | 295 |
| First sentence should end with a period. | 302 |
| Method 'subtract' is not designed for extension - needs to be abstract, final or empty. | 306 |
| Parameter value should be final. | 306 |
| Expected @param tag for 'value'. | 306 |
| '{' should be on the previous line. | 307 |
| '{' should be on the previous line. | 309 |
| '{' should be on the previous line. | 311 |
| '{' should be on the previous line. | 317 |
| '{' should be on the previous line. | 319 |
| '{' should be on the previous line. | 325 |
| '{' should be on the previous line. | 327 |
| Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. | 333 |
| Missing a Javadoc comment. | 333 |
| '{' should be on the previous line. | 335 |
| Method 'setVersion' is not designed for extension - needs to be abstract, final or empty. | 339 |
| Missing a Javadoc comment. | 339 |
| Parameter version should be final. | 340 |
| '{' should be on the previous line. | 341 |
| Method 'getCreationTime' is not designed for extension - needs to be abstract, final or empty. | 345 |
| Missing a Javadoc comment. | 345 |
| '{' should be on the previous line. | 347 |
| Method 'setCreationTime' is not designed for extension - needs to be abstract, final or empty. | 351 |
| Missing a Javadoc comment. | 351 |
| Parameter creationTime should be final. | 352 |
| '{' should be on the previous line. | 353 |
| Method 'getModifiedTime' is not designed for extension - needs to be abstract, final or empty. | 357 |
| Missing a Javadoc comment. | 357 |
| '{' should be on the previous line. | 359 |
| Method 'setModifiedTime' is not designed for extension - needs to be abstract, final or empty. | 363 |
| Missing a Javadoc comment. | 363 |
| Parameter modifiedTime should be final. | 364 |
| '{' should be on the previous line. | 365 |
org/apache/helix/ZNRecordAssembler.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 24 |
| '{' should be on the previous line. | 25 |
| Method 'assemble' is not designed for extension - needs to be abstract, final or empty. | 26 |
| Missing a Javadoc comment. | 26 |
| Parameter records should be final. | 26 |
| '{' should be on the previous line. | 27 |
| '{' should be on the previous line. | 30 |
| '{' should be on the previous line. | 32 |
| '{' should be on the previous line. | 34 |
| '{' should be on the previous line. | 39 |
org/apache/helix/ZNRecordBucketizer.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 27 |
| '{' should be on the previous line. | 28 |
| Missing a Javadoc comment. | 29 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 29 |
| Missing a Javadoc comment. | 30 |
| Name '_bucketSize' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 30 |
| Variable '_bucketSize' must be private and have accessor methods. | 30 |
| Missing a Javadoc comment. | 32 |
| Parameter bucketSize should be final. | 32 |
| '{' should be on the previous line. | 33 |
| '{' should be on the previous line. | 35 |
| First sentence should end with a period. | 44 |
| Line is longer than 80 characters. | 45 |
| Line has trailing spaces. | 46 |
| Expected an @return tag. | 50 |
| Method 'getBucketName' is not designed for extension - needs to be abstract, final or empty. | 50 |
| Parameter key should be final. | 50 |
| Expected @param tag for 'key'. | 50 |
| '{' should be on the previous line. | 51 |
| '{' should be on the previous line. | 53 |
| '{' should be on the previous line. | 60 |
| '{' should be on the previous line. | 66 |
| Line is longer than 80 characters. | 71 |
| '}' should be on the same line. | 72 |
| '{' should be on the previous line. | 74 |
| Method 'bucketize' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Missing a Javadoc comment. | 80 |
| Parameter record should be final. | 80 |
| '{' should be on the previous line. | 81 |
| '{' should be on the previous line. | 84 |
| Line has trailing spaces. | 88 |
| '{' should be on the previous line. | 91 |
| '{' should be on the previous line. | 94 |
| '{' should be on the previous line. | 96 |
| Line is longer than 80 characters. | 100 |
| '}' should be on the same line. | 101 |
| '{' should be on the previous line. | 103 |
| '{' should be on the previous line. | 110 |
| '{' should be on the previous line. | 113 |
| '{' should be on the previous line. | 115 |
| Line is longer than 80 characters. | 119 |
| '}' should be on the same line. | 120 |
| '{' should be on the previous line. | 122 |
| Line has trailing spaces. | 126 |
| '{' should be on the previous line. | 129 |
org/apache/helix/ZNRecordDelta.java
| Violation | Message | Line |
|---|---|---|
| File does not end with a newline. | 0 |
| Missing a Javadoc comment. | 22 |
| '{' should be on the previous line. | 23 |
| Missing a Javadoc comment. | 24 |
| '{' is not followed by whitespace. | 24 |
| Missing a Javadoc comment. | 24 |
| Missing a Javadoc comment. | 24 |
| '}' is not preceded with whitespace. | 24 |
| Missing a Javadoc comment. | 25 |
| Name '_record' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 25 |
| Variable '_record' must be private and have accessor methods. | 25 |
| Missing a Javadoc comment. | 26 |
| Name '_mergeOperation' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 26 |
| Variable '_mergeOperation' must be private and have accessor methods. | 26 |
| Missing a Javadoc comment. | 28 |
| Parameter record should be final. | 28 |
| Parameter _mergeOperation should be final. | 28 |
| '_mergeOperation' hides a field. | 28 |
| Name '_mergeOperation' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 28 |
| '{' should be on the previous line. | 29 |
| Missing a Javadoc comment. | 34 |
| Parameter record should be final. | 34 |
| '{' should be on the previous line. | 35 |
| Missing a Javadoc comment. | 39 |
| '{' should be on the previous line. | 40 |
| Method 'getRecord' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Missing a Javadoc comment. | 44 |
| '{' should be on the previous line. | 45 |
| Method 'getMergeOperation' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Missing a Javadoc comment. | 49 |
| '{' should be on the previous line. | 50 |
org/apache/helix/ZNRecordUpdater.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 24 |
| '{' should be on the previous line. | 25 |
| Missing a Javadoc comment. | 26 |
| Name '_record' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 26 |
| Variable '_record' must be private and have accessor methods. | 26 |
| Missing a Javadoc comment. | 28 |
| Parameter record should be final. | 28 |
| '{' should be on the previous line. | 29 |
| Method 'update' is not designed for extension - needs to be abstract, final or empty. | 33 |
| Parameter current should be final. | 34 |
| '{' should be on the previous line. | 35 |
| '{' should be on the previous line. | 37 |
org/apache/helix/agent/AgentStateModel.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 41 |
| '}' is not preceded with whitespace. | 41 |
| '{' should be on the previous line. | 43 |
| Missing a Javadoc comment. | 44 |
| Name '_logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 44 |
| Missing a Javadoc comment. | 45 |
| Line is longer than 80 characters. | 47 |
| Missing a Javadoc comment. | 47 |
| Parameter fromState should be final. | 47 |
| Parameter toState should be final. | 47 |
| Parameter attribute should be final. | 47 |
| Line has trailing spaces. | 50 |
| Missing a Javadoc comment. | 51 |
| Parameter string should be final. | 51 |
| Parameter message should be final. | 51 |
| Line is longer than 80 characters. | 56 |
| Line has trailing spaces. | 61 |
| Method 'genericStateTransitionHandler' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Missing a Javadoc comment. | 62 |
| Parameter message should be final. | 63 |
| Parameter context should be final. | 64 |
| '{' should be on the previous line. | 65 |
| Line is longer than 80 characters. | 67 |
| Line is longer than 80 characters. | 68 |
| Line is longer than 80 characters. | 69 |
| Line is longer than 80 characters. | 70 |
| Line has trailing spaces. | 71 |
| Line has trailing spaces. | 76 |
| Line is longer than 80 characters. | 79 |
| Line is longer than 80 characters. | 82 |
| Line has trailing spaces. | 83 |
| Line is longer than 80 characters. | 86 |
| Line is longer than 80 characters. | 88 |
| Line is longer than 80 characters. | 90 |
| Line has trailing spaces. | 98 |
| Line is longer than 80 characters. | 99 |
| Line is longer than 80 characters. | 101 |
| Line is longer than 80 characters. | 104 |
| Line has trailing spaces. | 105 |
| '{' should be on the previous line. | 115 |
| Line is longer than 80 characters. | 119 |
| Line has trailing spaces. | 121 |
| Line has trailing spaces. | 126 |
| Array brackets at illegal position. | 128 |
| Array brackets at illegal position. | 130 |
| Line has trailing spaces. | 131 |
| Must have at least one statement. | 137 |
| Line has trailing spaces. | 141 |
| Line is longer than 80 characters. | 141 |
| Line has trailing spaces. | 143 |
| Line has trailing spaces. | 146 |
| Line has trailing spaces. | 149 |
| Line has trailing spaces. | 152 |
| Line is longer than 80 characters. | 152 |
| Line has trailing spaces. | 155 |
| Line has trailing spaces. | 161 |
org/apache/helix/agent/AgentStateModelFactory.java
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 |
| Missing a Javadoc comment. | 24 |
| '{' is not preceded with whitespace. | 24 |
| Line has trailing spaces. | 25 |
| Method 'createNewStateModel' is not designed for extension - needs to be abstract, final or empty. | 26 |
| Parameter partitionKey should be final. | 27 |
| '{' should be on the previous line. | 28 |
org/apache/helix/agent/CommandAttribute.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 25 |
| Missing a Javadoc comment. | 26 |
| Missing a Javadoc comment. | 27 |
| Missing a Javadoc comment. | 28 |
| Missing a Javadoc comment. | 29 |
| Missing a Javadoc comment. | 30 |
| Line has trailing spaces. | 31 |
| Line is longer than 80 characters. | 33 |
| Missing a Javadoc comment. | 33 |
| Name 'map' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 33 |
| Line has trailing spaces. | 39 |
| Missing a Javadoc comment. | 40 |
| Name '_name' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 40 |
| Line has trailing spaces. | 41 |
| Missing a Javadoc comment. | 42 |
| Parameter name should be final. | 42 |
| Missing a Javadoc comment. | 46 |
| Line has trailing spaces. | 49 |
| Missing a Javadoc comment. | 50 |
| Parameter name should be final. | 50 |
org/apache/helix/agent/CommandConfig.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 25 |
| Missing a Javadoc comment. | 26 |
| Name '_fromState' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 26 |
| Missing a Javadoc comment. | 27 |
| Name '_toState' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 27 |
| Missing a Javadoc comment. | 28 |
| Name '_command' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 28 |
| Missing a Javadoc comment. | 29 |
| Name '_workingDir' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 29 |
| Missing a Javadoc comment. | 30 |
| Name '_timeout' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 30 |
| Missing a Javadoc comment. | 31 |
| Name '_pidFile' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 31 |
| Missing a Javadoc comment. | 33 |
| Parameter fromState should be final. | 33 |
| Parameter toState should be final. | 33 |
| Parameter command should be final. | 33 |
| Parameter workingDir should be final. | 34 |
| Parameter timeout should be final. | 34 |
| Parameter pidFile should be final. | 34 |
| Line has trailing spaces. | 43 |
| Line is longer than 80 characters. | 44 |
| Missing a Javadoc comment. | 44 |
| Parameter fromState should be final. | 44 |
| Parameter toState should be final. | 44 |
| Parameter attribute should be final. | 44 |
| Method 'toKeyValueMap' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Missing a Javadoc comment. | 48 |
| Line is longer than 80 characters. | 52 |
| Line is longer than 80 characters. | 53 |
| Line is longer than 80 characters. | 54 |
| Line has trailing spaces. | 55 |
| Line has trailing spaces. | 58 |
| First sentence should end with a period. | 59 |
| Missing a Javadoc comment. | 64 |
| Name '_fromState' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 64 |
| Missing a Javadoc comment. | 65 |
| Name '_toState' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 65 |
| Missing a Javadoc comment. | 66 |
| Name '_command' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 66 |
| Missing a Javadoc comment. | 67 |
| Name '_workingDir' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 67 |
| Missing a Javadoc comment. | 68 |
| Name '_timeout' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 68 |
| Missing a Javadoc comment. | 69 |
| Name '_pidFile' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 69 |
| Line has trailing spaces. | 70 |
| Method 'setTransition' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Missing a Javadoc comment. | 71 |
| Parameter fromState should be final. | 71 |
| Parameter toState should be final. | 71 |
| Line has trailing spaces. | 76 |
| Method 'setCommand' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Missing a Javadoc comment. | 77 |
| Parameter command should be final. | 77 |
| Line has trailing spaces. | 81 |
| Method 'setCommandWorkingDir' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Missing a Javadoc comment. | 82 |
| Parameter workingDir should be final. | 82 |
| Line has trailing spaces. | 86 |
| Method 'setCommandTimeout' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Missing a Javadoc comment. | 87 |
| Parameter timeout should be final. | 87 |
| Line has trailing spaces. | 91 |
| Method 'setPidFile' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Missing a Javadoc comment. | 92 |
| Parameter pidFile should be final. | 92 |
| Line has trailing spaces. | 96 |
| Method 'build' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Missing a Javadoc comment. | 97 |
| Line has trailing spaces. | 98 |
org/apache/helix/agent/HelixAgentMain.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 38 |
| Utility classes should not have a public or default constructor. | 38 |
| Missing a Javadoc comment. | 39 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 39 |
| Missing a Javadoc comment. | 41 |
| Name 'zkAddr' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 41 |
| Missing a Javadoc comment. | 42 |
| Name 'cluster' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 42 |
| Missing a Javadoc comment. | 43 |
| Name 'help' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 43 |
| Missing a Javadoc comment. | 44 |
| Name 'instanceName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 44 |
| Missing a Javadoc comment. | 45 |
| Name 'stateModel' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 45 |
| Missing a Javadoc comment. | 48 |
| 'private' modifier out of order with the JLS suggestions. | 49 |
| '{' should be on the previous line. | 50 |
| Missing a Javadoc comment. | 88 |
| Parameter cliOptions should be final. | 88 |
| '{' should be on the previous line. | 89 |
| '1000' is a magic number. | 91 |
| Line is longer than 80 characters. | 92 |
| Line is longer than 80 characters. | 95 |
| Missing a Javadoc comment. | 95 |
| Parameter cliArgs should be final. | 95 |
| '{' should be on the previous line. | 101 |
| '{' should be on the previous line. | 104 |
| Line is longer than 80 characters. | 105 |
| Missing a Javadoc comment. | 113 |
| '{' should be on the previous line. | 114 |
| Missing a Javadoc comment. | 115 |
| Name '_manager' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 115 |
| Variable '_manager' must be private and have accessor methods. | 115 |
| Missing a Javadoc comment. | 117 |
| Parameter manager should be final. | 117 |
| '{' should be on the previous line. | 118 |
| '{' should be on the previous line. | 124 |
| Line is longer than 80 characters. | 125 |
| 'if' construct must use '{}'s. | 126 |
| Missing a Javadoc comment. | 131 |
| Parameter args should be final. | 131 |
| Line has trailing spaces. | 138 |
| Line has trailing spaces. | 140 |
| Line is longer than 80 characters. | 142 |
org/apache/helix/agent/ProcessMonitorThread.java
| Violation | Message | Line |
|---|---|---|
| Unused import - java.io.File. | 3 |
| First sentence should end with a period. | 28 |
| Line has trailing spaces. | 29 |
| Line is longer than 80 characters. | 33 |
| Missing a Javadoc comment. | 33 |
| Missing a Javadoc comment. | 34 |
| Missing a Javadoc comment. | 36 |
| Name '_pid' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
| Line has trailing spaces. | 37 |
| Missing a Javadoc comment. | 38 |
| Parameter pid should be final. | 38 |
| Line has trailing spaces. | 41 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 42 |
| Line has trailing spaces. | 44 |
| Line is longer than 80 characters. | 53 |
| Line has trailing spaces. | 59 |
org/apache/helix/agent/SystemUtil.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 30 |
| Utility classes should not have a public or default constructor. | 30 |
| Missing a Javadoc comment. | 31 |
| Missing a Javadoc comment. | 32 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 32 |
| First sentence should end with a period. | 34 |
| Line has trailing spaces. | 38 |
| Line is longer than 80 characters. | 38 |
| Missing a Javadoc comment. | 40 |
| Missing a Javadoc comment. | 41 |
| Missing a Javadoc comment. | 42 |
| Line is longer than 80 characters. | 43 |
| Missing a Javadoc comment. | 43 |
| Missing a Javadoc comment. | 44 |
| Missing a Javadoc comment. | 45 |
| Line is longer than 80 characters. | 46 |
| Missing a Javadoc comment. | 46 |
| Missing a Javadoc comment. | 48 |
| Name '_description' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 48 |
| Line has trailing spaces. | 49 |
| Missing a Javadoc comment. | 50 |
| Parameter description should be final. | 50 |
| Line has trailing spaces. | 53 |
| Missing a Javadoc comment. | 54 |
| Line has trailing spaces. | 58 |
| Line is longer than 80 characters. | 59 |
| Missing a Javadoc comment. | 59 |
| Parameter processId should be final. | 59 |
| Line has trailing spaces. | 63 |
| Line is longer than 80 characters. | 65 |
| Array brackets at illegal position. | 66 |
| Line has trailing spaces. | 71 |
| Array brackets at illegal position. | 74 |
| Array brackets at illegal position. | 75 |
| Line has trailing spaces. | 76 |
| Line has trailing spaces. | 87 |
| Line has trailing spaces. | 93 |
| Missing a Javadoc comment. | 94 |
| Parameter file should be final. | 94 |
org/apache/helix/alerts/AccumulateAggregator.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 25 |
| Line has trailing spaces. | 27 |
| Line contains a tab character. | 27 |
| Line has trailing spaces. | 28 |
| Line contains a tab character. | 28 |
| Missing a Javadoc comment. | 28 |
| Line contains a tab character. | 29 |
| '{' should be on the previous line. | 29 |
| Line contains a tab character. | 30 |
| Line contains a tab character. | 31 |
| Line has trailing spaces. | 32 |
| Line contains a tab character. | 32 |
| Line contains a tab character. | 33 |
| Method 'merge' is not designed for extension - needs to be abstract, final or empty. | 33 |
| Line contains a tab character. | 34 |
| Parameter currValTup should be final. | 34 |
| Parameter newValTup should be final. | 34 |
| Line is longer than 80 characters. | 35 |
| Line contains a tab character. | 35 |
| Parameter currTimeTup should be final. | 35 |
| Parameter newTimeTup should be final. | 35 |
| Parameter args should be final. | 35 |
| Line has trailing spaces. | 36 |
| Line contains a tab character. | 36 |
| Line contains a tab character. | 37 |
| Line contains a tab character. | 38 |
| Line contains a tab character. | 39 |
| Line contains a tab character. | 40 |
| Line contains a tab character. | 41 |
| Line contains a tab character. | 42 |
| Line has trailing spaces. | 43 |
| Line contains a tab character. | 43 |
| Line is longer than 80 characters. | 44 |
| Line contains a tab character. | 44 |
| '||' should be on a new line. | 44 |
| Line contains a tab character. | 45 |
| Line contains a tab character. | 46 |
| Line contains a tab character. | 47 |
| Line has trailing spaces. | 48 |
| Line contains a tab character. | 48 |
| Line contains a tab character. | 49 |
| Line contains a tab character. | 50 |
| Line is longer than 80 characters. | 51 |
| Line contains a tab character. | 51 |
| Line is longer than 80 characters. | 52 |
| Line contains a tab character. | 52 |
| Line contains a tab character. | 53 |
| Line contains a tab character. | 54 |
| Line contains a tab character. | 55 |
| Line has trailing spaces. | 56 |
| Line contains a tab character. | 56 |
| Line contains a tab character. | 57 |
| Line is longer than 80 characters. | 58 |
| Line contains a tab character. | 58 |
| '+' is not preceded with whitespace. | 58 |
| '+' is not followed by whitespace. | 58 |
| Line contains a tab character. | 59 |
| Line contains a tab character. | 60 |
| '}' should be on the same line. | 60 |
| Line contains a tab character. | 61 |
| Line contains a tab character. | 62 |
| Line contains a tab character. | 63 |
| Line contains a tab character. | 64 |
| Line has trailing spaces. | 65 |
| Line contains a tab character. | 65 |
| Line contains a tab character. | 66 |
| Line contains a tab character. | 67 |
| Line contains a tab character. | 68 |
| Line contains a tab character. | 69 |
| Line contains a tab character. | 70 |
| Line has trailing spaces. | 72 |
| Line contains a tab character. | 72 |
org/apache/helix/alerts/Aggregator.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| Line contains a tab character. | 24 |
| Missing a Javadoc comment. | 24 |
| Name '_numArgs' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 24 |
| Variable '_numArgs' must be private and have accessor methods. | 24 |
| Line has trailing spaces. | 25 |
| Line contains a tab character. | 25 |
| Line contains a tab character. | 26 |
| Missing a Javadoc comment. | 26 |
| Line contains a tab character. | 27 |
| '{' should be on the previous line. | 27 |
| Line has trailing spaces. | 28 |
| Line contains a tab character. | 28 |
| Line contains a tab character. | 29 |
| Line has trailing spaces. | 30 |
| Line contains a tab character. | 30 |
| Line contains a tab character. | 31 |
| Line contains a tab character. | 32 |
| Line contains a tab character. | 33 |
| Line has trailing spaces. | 34 |
| Line contains a tab character. | 34 |
| Missing a Javadoc comment. | 34 |
| Line is longer than 80 characters. | 35 |
| Line contains a tab character. | 35 |
| Line has trailing spaces. | 36 |
| Line contains a tab character. | 36 |
| Line contains a tab character. | 37 |
| Method 'getRequiredNumArgs' is not designed for extension - needs to be abstract, final or empty. | 37 |
| Missing a Javadoc comment. | 37 |
| Line contains a tab character. | 38 |
| '{' should be on the previous line. | 38 |
| Line contains a tab character. | 39 |
| Line contains a tab character. | 40 |
| Line has trailing spaces. | 41 |
| Line contains a tab character. | 41 |
org/apache/helix/alerts/Alert.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| Line has trailing spaces. | 23 |
| Line contains a tab character. | 23 |
| Line contains a tab character. | 24 |
| Missing a Javadoc comment. | 24 |
| Name '_name' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 24 |
| Variable '_name' must be private and have accessor methods. | 24 |
| Line has trailing spaces. | 25 |
| Line contains a tab character. | 25 |
| Line contains a tab character. | 26 |
| Missing a Javadoc comment. | 26 |
| Name '_expression' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 26 |
| Variable '_expression' must be private and have accessor methods. | 26 |
| Line contains a tab character. | 27 |
| Missing a Javadoc comment. | 27 |
| Name '_comparator' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 27 |
| Variable '_comparator' must be private and have accessor methods. | 27 |
| Line contains a tab character. | 28 |
| Missing a Javadoc comment. | 28 |
| Name '_constant' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 28 |
| Variable '_constant' must be private and have accessor methods. | 28 |
| Line has trailing spaces. | 29 |
| Line contains a tab character. | 29 |
| Line is longer than 80 characters. | 30 |
| Line contains a tab character. | 30 |
| Missing a Javadoc comment. | 30 |
| Parameter name should be final. | 30 |
| Parameter expression should be final. | 30 |
| Parameter comparator should be final. | 30 |
| Parameter constant should be final. | 30 |
| Line contains a tab character. | 31 |
| Line contains a tab character. | 32 |
| '=' is not preceded with whitespace. | 32 |
| '=' is not followed by whitespace. | 32 |
| Line contains a tab character. | 33 |
| '=' is not preceded with whitespace. | 33 |
| '=' is not followed by whitespace. | 33 |
| Line contains a tab character. | 34 |
| '=' is not preceded with whitespace. | 34 |
| '=' is not followed by whitespace. | 34 |
| Line contains a tab character. | 35 |
| '=' is not preceded with whitespace. | 35 |
| '=' is not followed by whitespace. | 35 |
| Line contains a tab character. | 36 |
| Line has trailing spaces. | 37 |
| Line contains a tab character. | 37 |
| Line contains a tab character. | 38 |
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Missing a Javadoc comment. | 38 |
| Line contains a tab character. | 39 |
| '{' should be on the previous line. | 39 |
| Line contains a tab character. | 40 |
| Line contains a tab character. | 41 |
| Line has trailing spaces. | 42 |
| Line contains a tab character. | 42 |
| Line contains a tab character. | 43 |
| Method 'getExpression' is not designed for extension - needs to be abstract, final or empty. | 43 |
| Missing a Javadoc comment. | 43 |
| Line contains a tab character. | 44 |
| '{' should be on the previous line. | 44 |
| Line contains a tab character. | 45 |
| Line contains a tab character. | 46 |
| Line has trailing spaces. | 47 |
| Line contains a tab character. | 47 |
| Line contains a tab character. | 48 |
| Method 'getComparator' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Missing a Javadoc comment. | 48 |
| Line contains a tab character. | 49 |
| '{' should be on the previous line. | 49 |
| Line contains a tab character. | 50 |
| Line contains a tab character. | 51 |
| Line has trailing spaces. | 52 |
| Line contains a tab character. | 52 |
| Line has trailing spaces. | 53 |
| Line contains a tab character. | 53 |
| Method 'getConstant' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Missing a Javadoc comment. | 53 |
| Line contains a tab character. | 54 |
| '{' should be on the previous line. | 54 |
| Line contains a tab character. | 55 |
| Line contains a tab character. | 56 |
org/apache/helix/alerts/AlertComparator.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| Line contains a tab character. | 24 |
| Missing a Javadoc comment. | 24 |
| Line contains a tab character. | 25 |
| '{' should be on the previous line. | 25 |
| Line has trailing spaces. | 26 |
| Line contains a tab character. | 26 |
| Line contains a tab character. | 27 |
| Line has trailing spaces. | 28 |
| Line contains a tab character. | 28 |
| Line is longer than 80 characters. | 29 |
| Line contains a tab character. | 29 |
| Missing a Javadoc comment. | 29 |
| Line has trailing spaces. | 30 |
| Line contains a tab character. | 30 |
org/apache/helix/alerts/AlertParser.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 26 |
| Missing a Javadoc comment. | 30 |
| Utility classes should not have a public or default constructor. | 30 |
| Line contains a tab character. | 31 |
| Missing a Javadoc comment. | 31 |
| Line has trailing spaces. | 32 |
| Line contains a tab character. | 32 |
| Line contains a tab character. | 33 |
| Missing a Javadoc comment. | 33 |
| Line contains a tab character. | 34 |
| Missing a Javadoc comment. | 34 |
| Line contains a tab character. | 35 |
| Missing a Javadoc comment. | 35 |
| Line contains a tab character. | 36 |
| Missing a Javadoc comment. | 36 |
| Line has trailing spaces. | 37 |
| Line contains a tab character. | 37 |
| Line is longer than 80 characters. | 38 |
| Line contains a tab character. | 38 |
| Missing a Javadoc comment. | 38 |
| Variable 'comparatorMap' must be private and have accessor methods. | 38 |
| Line has trailing spaces. | 39 |
| Line contains a tab character. | 39 |
| Line contains a tab character. | 40 |
| Line contains a tab character. | 41 |
| Line has trailing spaces. | 42 |
| Line contains a tab character. | 42 |
| Line contains a tab character. | 43 |
| Line contains a tab character. | 44 |
| Line has trailing spaces. | 45 |
| Line contains a tab character. | 45 |
| Line is longer than 80 characters. | 46 |
| Line contains a tab character. | 46 |
| Missing a Javadoc comment. | 46 |
| Parameter label should be final. | 46 |
| Parameter comp should be final. | 46 |
| Line contains a tab character. | 47 |
| '{' should be on the previous line. | 47 |
| Line contains a tab character. | 48 |
| Line contains a tab character. | 49 |
| '{' should be on the previous line. | 49 |
| Line contains a tab character. | 50 |
| Line contains a tab character. | 51 |
| Line contains a tab character. | 52 |
| '+' is not preceded with whitespace. | 52 |
| '+' is not followed by whitespace. | 52 |
| Line contains a tab character. | 53 |
| Line has trailing spaces. | 54 |
| Line contains a tab character. | 54 |
| Line contains a tab character. | 55 |
| Missing a Javadoc comment. | 55 |
| Parameter compName should be final. | 55 |
| Line contains a tab character. | 56 |
| '{' should be on the previous line. | 56 |
| Line contains a tab character. | 57 |
| Line contains a tab character. | 58 |
| Line is longer than 80 characters. | 59 |
| Line contains a tab character. | 59 |
| '+' is not preceded with whitespace. | 59 |
| '+' is not followed by whitespace. | 59 |
| '+' is not preceded with whitespace. | 59 |
| '+' is not followed by whitespace. | 59 |
| Line contains a tab character. | 60 |
| Line contains a tab character. | 61 |
| Line contains a tab character. | 62 |
| Line has trailing spaces. | 63 |
| Line contains a tab character. | 63 |
| Line is longer than 80 characters. | 64 |
| Line contains a tab character. | 64 |
| Missing a Javadoc comment. | 64 |
| Parameter component should be final. | 64 |
| Parameter alert should be final. | 64 |
| Redundant throws: 'HelixException' is unchecked exception. | 64 |
| Line contains a tab character. | 65 |
| Line contains a tab character. | 66 |
| Line contains a tab character. | 67 |
| Line contains a tab character. | 68 |
| Line is longer than 80 characters. | 69 |
| Line contains a tab character. | 69 |
| '+' is not preceded with whitespace. | 69 |
| '+' is not followed by whitespace. | 69 |
| '+' is not preceded with whitespace. | 69 |
| '+' is not followed by whitespace. | 69 |
| Line contains a tab character. | 70 |
| Line is longer than 80 characters. | 71 |
| Line contains a tab character. | 71 |
| '+' is not preceded with whitespace. | 71 |
| '+' is not followed by whitespace. | 71 |
| Line contains a tab character. | 72 |
| Line contains a tab character. | 73 |
| Line contains a tab character. | 74 |
| Line contains a tab character. | 75 |
| Line contains a tab character. | 76 |
| Line contains a tab character. | 77 |
| '}' should be on the same line. | 77 |
| Line contains a tab character. | 78 |
| Line contains a tab character. | 79 |
| Line contains a tab character. | 80 |
| Line contains a tab character. | 81 |
| Line contains a tab character. | 82 |
| Line contains a tab character. | 83 |
| Line is longer than 80 characters. | 84 |
| Line contains a tab character. | 84 |
| '+' is not preceded with whitespace. | 84 |
| '+' is not followed by whitespace. | 84 |
| '+' is not preceded with whitespace. | 84 |
| '+' is not followed by whitespace. | 84 |
| '+' is not preceded with whitespace. | 84 |
| '+' is not followed by whitespace. | 84 |
| '+' should be on a new line. | 84 |
| Line contains a tab character. | 85 |
| Line contains a tab character. | 86 |
| Line contains a tab character. | 87 |
| Line contains a tab character. | 88 |
| '-' is not preceded with whitespace. | 88 |
| '-' is not followed by whitespace. | 88 |
| Line contains a tab character. | 89 |
| Line has trailing spaces. | 90 |
| Line contains a tab character. | 90 |
| Line contains a tab character. | 91 |
| Missing a Javadoc comment. | 91 |
| Parameter alert should be final. | 91 |
| Redundant throws: 'HelixException' is unchecked exception. | 91 |
| Line contains a tab character. | 92 |
| '{' should be on the previous line. | 92 |
| Comment matches to-do format 'TODO:'. | 93 |
| Line is longer than 80 characters. | 93 |
| Line contains a tab character. | 93 |
| Line contains a tab character. | 94 |
| Line contains a tab character. | 95 |
| Line contains a tab character. | 96 |
| Line contains a tab character. | 97 |
| Line contains a tab character. | 98 |
| '+' is not preceded with whitespace. | 98 |
| '+' is not followed by whitespace. | 98 |
| Line contains a tab character. | 99 |
| '+' is not preceded with whitespace. | 99 |
| '+' is not followed by whitespace. | 99 |
| Line contains a tab character. | 100 |
| '+' is not preceded with whitespace. | 100 |
| '+' is not followed by whitespace. | 100 |
| Line has trailing spaces. | 101 |
| Line contains a tab character. | 101 |
| Line contains a tab character. | 102 |
| Line contains a tab character. | 103 |
| Line has trailing spaces. | 104 |
| Line contains a tab character. | 104 |
| Line contains a tab character. | 105 |
| Line contains a tab character. | 106 |
| Line is longer than 80 characters. | 107 |
| Line contains a tab character. | 107 |
| '+' is not preceded with whitespace. | 107 |
| '+' is not followed by whitespace. | 107 |
| Line contains a tab character. | 108 |
| Line contains a tab character. | 109 |
| '{' should be on the previous line. | 111 |
| '}' should be on the same line. | 113 |
| 'catch' is not followed by whitespace. | 114 |
| '{' should be on the previous line. | 115 |
| 'if' is not followed by whitespace. | 119 |
| '{' should be on the previous line. | 120 |
| Line is longer than 80 characters. | 123 |
| Line contains a tab character. | 123 |
| Line is longer than 80 characters. | 124 |
| Line contains a tab character. | 124 |
| Line is longer than 80 characters. | 125 |
| Line contains a tab character. | 125 |
| Line has trailing spaces. | 126 |
| Line contains a tab character. | 126 |
| Comment matches to-do format 'TODO:'. | 127 |
| Line is longer than 80 characters. | 127 |
| Line contains a tab character. | 127 |
| Line has trailing spaces. | 128 |
| Line contains a tab character. | 128 |
| Line has trailing spaces. | 129 |
| Line contains a tab character. | 129 |
| Line is longer than 80 characters. | 130 |
| Line contains a tab character. | 130 |
| Line has trailing spaces. | 131 |
| Line contains a tab character. | 131 |
| Line contains a tab character. | 132 |
| Line contains a tab character. | 133 |
| Line has trailing spaces. | 134 |
| Line contains a tab character. | 134 |
| Missing a Javadoc comment. | 135 |
| Parameter actionValue should be final. | 135 |
| '{' should be on the previous line. | 136 |
| '{' should be on the previous line. | 138 |
| '}' should be on the same line. | 140 |
| 'catch' is not followed by whitespace. | 141 |
| '{' should be on the previous line. | 142 |
| '{' should be on the previous line. | 145 |
| Line is longer than 80 characters. | 148 |
org/apache/helix/alerts/AlertProcessor.java
| Violation | Message | Line |
|---|---|---|
| Unused import - java.util.LinkedList. | 25 |
| Unused import - java.util.ListIterator. | 27 |
| Unused import - org.apache.helix.healthcheck.StatHealthReportProvider. | 32 |
| Missing a Javadoc comment. | 36 |
| '{' should be on the previous line. | 37 |
| Missing a Javadoc comment. | 38 |
| Missing a Javadoc comment. | 40 |
| Name 'bindingDelim' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 40 |
| Missing a Javadoc comment. | 41 |
| Name 'noWildcardAlertKey' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 41 |
| Missing a Javadoc comment. | 43 |
| Name '_statsHolder' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 43 |
| Variable '_statsHolder' must be private and have accessor methods. | 43 |
| Line has trailing spaces. | 49 |
| Missing a Javadoc comment. | 53 |
| Parameter sh should be final. | 53 |
| '{' should be on the previous line. | 54 |
| Line is longer than 80 characters. | 58 |
| Missing a Javadoc comment. | 58 |
| Parameter alert should be final. | 58 |
| Line is longer than 80 characters. | 63 |
| '{' should be on the previous line. | 65 |
| Missing a Javadoc comment. | 90 |
| Parameter bindings should be final. | 90 |
| '{' should be on the previous line. | 91 |
| '{' should be on the previous line. | 93 |
| '{' should be on the previous line. | 99 |
| '{' should be on the previous line. | 101 |
| Missing a Javadoc comment. | 112 |
| Parameter alertStats should be final. | 113 |
| Parameter persistentStats should be final. | 113 |
| '{' should be on the previous line. | 114 |
| Line is longer than 80 characters. | 115 |
| '{' should be on the previous line. | 119 |
| '{' should be on the previous line. | 123 |
| '{' should be on the previous line. | 127 |
| '{' should be on the previous line. | 136 |
| '{' should be on the previous line. | 139 |
| '}' should be on the same line. | 141 |
| '{' should be on the previous line. | 143 |
| '{' should be on the previous line. | 147 |
| '{' should be on the previous line. | 151 |
| Comment matches to-do format 'TODO:'. | 162 |
| '{' should be on the previous line. | 165 |
| '{' should be on the previous line. | 168 |
| '{' should be on the previous line. | 170 |
| 'for' is not followed by whitespace. | 176 |
| '{' should be on the previous line. | 177 |
| Missing a Javadoc comment. | 186 |
| Parameter tupleMap should be final. | 187 |
| '{' should be on the previous line. | 188 |
| Line is longer than 80 characters. | 193 |
| Line is longer than 80 characters. | 194 |
| '{' should be on the previous line. | 196 |
| '{' should be on the previous line. | 199 |
| '{' should be on the previous line. | 201 |
| '{' should be on the previous line. | 209 |
| Missing a Javadoc comment. | 216 |
| Parameter tupleIters should be final. | 217 |
| Parameter operators should be final. | 217 |
| '{' should be on the previous line. | 218 |
| '{' should be on the previous line. | 221 |
| '{' should be on the previous line. | 223 |
| '{' should be on the previous line. | 230 |
| Comment matches to-do format 'TODO:'. | 239 |
| Missing a Javadoc comment. | 242 |
| Parameter tuples should be final. | 243 |
| Parameter comparatorName should be final. | 243 |
| Parameter constant should be final. | 244 |
| '{' should be on the previous line. | 245 |
| Line is longer than 80 characters. | 246 |
| '{' should be on the previous line. | 250 |
| Comment matches to-do format 'TODO:'. | 264 |
| Line has trailing spaces. | 275 |
| Comment matches to-do format 'TODO:'. | 276 |
| Line has trailing spaces. | 277 |
| Missing a Javadoc comment. | 281 |
| Parameter alertStatBindings should be final. | 282 |
| Parameter evalResults should be final. | 282 |
| Line is longer than 80 characters. | 284 |
| '{' should be on the previous line. | 288 |
| '{' should be on the previous line. | 291 |
| '}' should be on the same line. | 294 |
| '{' should be on the previous line. | 296 |
| '{' should be on the previous line. | 299 |
| Missing a Javadoc comment. | 306 |
| Parameter alert should be final. | 306 |
| Parameter persistedStats should be final. | 307 |
| '{' should be on the previous line. | 308 |
| Line is longer than 80 characters. | 315 |
| '{' should be on the previous line. | 319 |
| Line is longer than 80 characters. | 323 |
| Line is longer than 80 characters. | 338 |
| Missing a Javadoc comment. | 345 |
| Parameter alerts should be final. | 346 |
| Parameter stats should be final. | 346 |
| '{' should be on the previous line. | 347 |
| Line is longer than 80 characters. | 348 |
| '{' should be on the previous line. | 351 |
| Comment matches to-do format 'TODO:'. | 353 |
org/apache/helix/alerts/AlertValueAndStatus.java
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 22 |
| Line contains a tab character. | 23 |
| Missing a Javadoc comment. | 23 |
| 'static' modifier out of order with the JLS suggestions. | 23 |
| Line contains a tab character. | 24 |
| Missing a Javadoc comment. | 24 |
| 'static' modifier out of order with the JLS suggestions. | 24 |
| Line has trailing spaces. | 25 |
| Line contains a tab character. | 25 |
| Line contains a tab character. | 26 |
| Missing a Javadoc comment. | 26 |
| Line contains a tab character. | 27 |
| Missing a Javadoc comment. | 27 |
| Line has trailing spaces. | 28 |
| Line contains a tab character. | 28 |
| Line contains a tab character. | 29 |
| Missing a Javadoc comment. | 29 |
| Parameter value should be final. | 29 |
| 'value' hides a field. | 29 |
| Parameter fired should be final. | 29 |
| 'fired' hides a field. | 29 |
| Line contains a tab character. | 30 |
| '{' should be on the previous line. | 30 |
| Line contains a tab character. | 31 |
| Line contains a tab character. | 32 |
| Line contains a tab character. | 33 |
| Line contains a tab character. | 35 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 35 |
| Missing a Javadoc comment. | 35 |
| Line contains a tab character. | 36 |
| Line contains a tab character. | 37 |
| Line contains a tab character. | 39 |
| Method 'isFired' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Missing a Javadoc comment. | 39 |
| Line contains a tab character. | 40 |
| Line contains a tab character. | 41 |
| Line has trailing spaces. | 42 |
| Line contains a tab character. | 42 |
org/apache/helix/alerts/AlertsHolder.java
| Violation | Message | Line |
|---|---|---|
| Unused import - org.apache.helix.HelixProperty. | 31 |
| Unused import - org.apache.helix.PropertyType. | 33 |
| Unused import - org.apache.helix.ZNRecord. | 34 |
| Missing a Javadoc comment. | 42 |
| Line contains a tab character. | 44 |
| Missing a Javadoc comment. | 44 |
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 44 |
| Line contains a tab character. | 45 |
| Line contains a tab character. | 47 |
| Missing a Javadoc comment. | 47 |
| Name '_accessor' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 47 |
| Variable '_accessor' must be private and have accessor methods. | 47 |
| Line contains a tab character. | 48 |
| Missing a Javadoc comment. | 48 |
| Name '_cache' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 48 |
| Variable '_cache' must be private and have accessor methods. | 48 |
| Line contains a tab character. | 49 |
| Missing a Javadoc comment. | 49 |
| ',' is not followed by whitespace. | 49 |
| Name '_alertsMap' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 49 |
| Variable '_alertsMap' must be private and have accessor methods. | 49 |
| Line contains a tab character. | 50 |
| Missing a Javadoc comment. | 50 |
| ',' is not followed by whitespace. | 50 |
| Name '_alertStatusMap' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 50 |
| Variable '_alertStatusMap' must be private and have accessor methods. | 50 |
| Line contains a tab character. | 51 |
| Line contains a tab character. | 52 |
| Missing a Javadoc comment. | 52 |
| Variable 'alerts' must be private and have accessor methods. | 52 |
| Line contains a tab character. | 53 |
| Missing a Javadoc comment. | 53 |
| Name '_statsHolder' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 53 |
| Variable '_statsHolder' must be private and have accessor methods. | 53 |
| Missing a Javadoc comment. | 55 |
| Name '_manager' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 55 |
| Missing a Javadoc comment. | 57 |
| Name '_keyBuilder' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 57 |
| Line contains a tab character. | 59 |
| Missing a Javadoc comment. | 59 |
| Parameter manager should be final. | 59 |
| Parameter cache should be final. | 59 |
| Line contains a tab character. | 60 |
| '{' should be on the previous line. | 60 |
| Line contains a tab character. | 61 |
| Line contains a tab character. | 62 |
| Line has trailing spaces. | 63 |
| Line contains a tab character. | 63 |
| Line is longer than 80 characters. | 64 |
| Line contains a tab character. | 64 |
| Missing a Javadoc comment. | 64 |
| Parameter manager should be final. | 64 |
| Parameter cache should be final. | 64 |
| Parameter statHolder should be final. | 64 |
| Line contains a tab character. | 74 |
| Method 'refreshAlerts' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Missing a Javadoc comment. | 74 |
| Line contains a tab character. | 75 |
| '{' should be on the previous line. | 75 |
| Line contains a tab character. | 76 |
| Line contains a tab character. | 77 |
| Line contains a tab character. | 80 |
| Line contains a tab character. | 81 |
| Comment matches to-do format 'TODO:'. | 82 |
| Line contains a tab character. | 82 |
| Line contains a tab character. | 83 |
| Line contains a tab character. | 84 |
| Line contains a tab character. | 85 |
| Line contains a tab character. | 86 |
| Line contains a tab character. | 88 |
| Method 'refreshAlertStatus' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Missing a Javadoc comment. | 88 |
| Line contains a tab character. | 89 |
| '{' should be on the previous line. | 89 |
| Line contains a tab character. | 90 |
| Line contains a tab character. | 91 |
| Line contains a tab character. | 92 |
| Line contains a tab character. | 93 |
| '}' should be on the same line. | 93 |
| Line contains a tab character. | 94 |
| Line is longer than 80 characters. | 95 |
| Line contains a tab character. | 95 |
| ',' is not followed by whitespace. | 95 |
| Line contains a tab character. | 96 |
| Line contains a tab character. | 97 |
| Line contains a tab character. | 99 |
| Method 'persistAlerts' is not designed for extension - needs to be abstract, final or empty. | 99 |
| Missing a Javadoc comment. | 99 |
| Line contains a tab character. | 100 |
| '{' should be on the previous line. | 100 |
| Line contains a tab character. | 101 |
| Line has trailing spaces. | 102 |
| Line contains a tab character. | 102 |
| Line contains a tab character. | 103 |
| 'alerts' hides a field. | 103 |
| Comment matches to-do format 'TODO:'. | 105 |
| Line is longer than 80 characters. | 105 |
| Line contains a tab character. | 106 |
| Line contains a tab character. | 107 |
| Line is longer than 80 characters. | 108 |
| Line contains a tab character. | 108 |
| Line contains a tab character. | 109 |
| '+' is not preceded with whitespace. | 109 |
| '+' is not followed by whitespace. | 109 |
| Line contains a tab character. | 110 |
| Line contains a tab character. | 112 |
| Method 'persistAlertStatus' is not designed for extension - needs to be abstract, final or empty. | 112 |
| Missing a Javadoc comment. | 112 |
| Line contains a tab character. | 113 |
| '{' should be on the previous line. | 113 |
| Line contains a tab character. | 114 |
| Line is longer than 80 characters. | 115 |
| Line contains a tab character. | 115 |
| Line contains a tab character. | 116 |
| Comment matches to-do format 'TODO:'. | 117 |
| Line is longer than 80 characters. | 117 |
| Line contains a tab character. | 117 |
| Line contains a tab character. | 118 |
| Line contains a tab character. | 119 |
| Line is longer than 80 characters. | 120 |
| Line contains a tab character. | 120 |
| Line contains a tab character. | 121 |
| '+' is not preceded with whitespace. | 121 |
| '+' is not followed by whitespace. | 121 |
| Line contains a tab character. | 122 |
| Line contains a tab character. | 124 |
| Line contains a tab character. | 125 |
| Missing a Javadoc comment. | 125 |
| Line contains a tab character. | 126 |
| '{' should be on the previous line. | 126 |
| Line contains a tab character. | 128 |
| Line contains a tab character. | 130 |
| Method 'addAlert' is not designed for extension - needs to be abstract, final or empty. | 130 |
| Missing a Javadoc comment. | 130 |
| Parameter alert should be final. | 130 |
| Redundant throws: 'HelixException' is unchecked exception. | 130 |
| Line contains a tab character. | 131 |
| '{' should be on the previous line. | 131 |
| Line contains a tab character. | 132 |
| Line contains a tab character. | 133 |
| Line contains a tab character. | 134 |
| Line contains a tab character. | 135 |
| Line contains a tab character. | 136 |
| ',' is not followed by whitespace. | 136 |
| Line contains a tab character. | 137 |
| Line is longer than 80 characters. | 138 |
| Line contains a tab character. | 138 |
| Line contains a tab character. | 139 |
| Line is longer than 80 characters. | 140 |
| Line contains a tab character. | 140 |
| Line contains a tab character. | 141 |
| Line is longer than 80 characters. | 142 |
| Line contains a tab character. | 142 |
| Line contains a tab character. | 143 |
| Line contains a tab character. | 144 |
| '{' should be on the previous line. | 144 |
| Line contains a tab character. | 145 |
| Line contains a tab character. | 146 |
| Line contains a tab character. | 147 |
| '}' should be on the same line. | 147 |
| Line contains a tab character. | 148 |
| 'catch' is not followed by whitespace. | 148 |
| Line contains a tab character. | 149 |
| '{' should be on the previous line. | 149 |
| Line contains a tab character. | 150 |
| Line contains a tab character. | 151 |
| Line contains a tab character. | 152 |
| Line is longer than 80 characters. | 153 |
| Line contains a tab character. | 153 |
| Line contains a tab character. | 156 |
| Line contains a tab character. | 157 |
| Line contains a tab character. | 158 |
| Line contains a tab character. | 159 |
| Line contains a tab character. | 161 |
| Line contains a tab character. | 162 |
| Line contains a tab character. | 163 |
| Line is longer than 80 characters. | 164 |
| Line contains a tab character. | 164 |
| Method 'addAlertStatusSet' is not designed for extension - needs to be abstract, final or empty. | 164 |
| Missing a Javadoc comment. | 164 |
| Parameter statusSet should be final. | 164 |
| Redundant throws: 'HelixException' is unchecked exception. | 164 |
| Line contains a tab character. | 165 |